Attention is currently required from: osmith, neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29119 )
Change subject: osmocom-list-commits: use proper git clone urls
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This is really weird. It's available at git.osmocom.org over git://, but not over https://.
I created https://osmocom.org/issues/5650 to track this.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2acb9880be57411f11805a2195076b514156aaf3
Gerrit-Change-Number: 29119
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 20:56:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29119 )
Change subject: osmocom-list-commits: use proper git clone urls
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Hmm, so AFAIU, osmo-upf is not available over git.osmocom.org, but only via gerrit.osmocom. […]
This is really weird. It's available at git.osmocom.org over git://, but not over https://.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2acb9880be57411f11805a2195076b514156aaf3
Gerrit-Change-Number: 29119
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 20:38:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29119 )
Change subject: osmocom-list-commits: use proper git clone urls
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Hmm, so AFAIU, osmo-upf is not available over git.osmocom.org, but only via gerrit.osmocom.org?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2acb9880be57411f11805a2195076b514156aaf3
Gerrit-Change-Number: 29119
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 20:35:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 )
Change subject: BSSMAP: add assert to reset resending
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Without coredump or config I don't think we could reproduce this. I'm fine with Harald's suggestion of just adding OSMO_ASSERT() in here.
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/b446ca3c_e9a1f67e
PS2, Line 3393: if (!msc->a.bssmap_reset) {
> did you actually face a situation like this?
No, as explained in the ticket.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
Gerrit-Change-Number: 28892
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 16:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, msuraev.
Hello Jenkins Builder, neels, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28892
to look at the new patch set (#3).
Change subject: BSSMAP: add assert to reset resending
......................................................................
BSSMAP: add assert to reset resending
There seems to be no way for this function to be called with NULL parameter despite unreproducible crash observed in the
past. Let's add assert to show this explicitly.
Fixes: OS#5551
Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
---
M src/osmo-bsc/bssmap_reset.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/28892/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
Gerrit-Change-Number: 28892
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 )
Change subject: manual: update IuCS/IuPS protocol stack chart
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> Did we ever use SUA?
yep, we did. at first i didn't need an osmo-stp to test 3G, and when M3UA came along i was all cranky because suddenly i needed point-codes and SS7 routing, and then you wrote the osmo_sccp_simple_client()...
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I4496a6ffdda511875208bebbe68dbc9e69541fc0
Gerrit-Change-Number: 29093
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 17 Aug 2022 15:45:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, dexter.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 )
Change subject: manual: explain the PFCP port
......................................................................
Patch Set 3:
(2 comments)
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075/comment/fea22780_c4780305
PS2, Line 147: optionally supports
> if this is a compile-time option, it should be stated here to avoid users assuming they can just alw […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075/comment/c4a67703_8e01ff21
PS2, Line 156: remote-addr 127.0.0.1
> Just asking myself while reading: How would I setup the port?
thx, forgot to explain that
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3
Gerrit-Change-Number: 29075
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 15:40:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment