August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs/master-builds: clone from gerrit.osmocom.org

by osmith

Attention is currently required from: laforge, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29153 ) Change subject: jobs/master-builds: clone from gerrit.osmocom.org ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f345be55f5c7eb42655dc346776ad8891af126d Gerrit-Change-Number: 29153 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:08:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: clone from gerrit.osmocom.org

by neels

Attention is currently required from: osmith, laforge, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29153 ) Change subject: jobs/master-builds: clone from gerrit.osmocom.org ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File jobs/master-builds.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29153/comment/5806f3b5_948c1d48 PS2, Line 76: git_base_url: https://gitea.osmocom.org/sdr > fatal: repository 'https://gitea.osmocom. […] sorry https://gitea.osmocom.org/sdr/libosmo-dsp -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f345be55f5c7eb42655dc346776ad8891af126d Gerrit-Change-Number: 29153 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:05:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: clone from gerrit.osmocom.org

by osmith

Attention is currently required from: neels, laforge, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29153 ) Change subject: jobs/master-builds: clone from gerrit.osmocom.org ...................................................................... Patch Set 2: (1 comment) File jobs/master-builds.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29153/comment/bd9a4830_c022d612 PS2, Line 76: git_base_url: https://gitea.osmocom.org/sdr > fatal: repository 'https://gitea.osmocom. […] it is the git base url, jenkins will clone from https://gitea.osmocom.org/sdr/libosmo-dsp -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f345be55f5c7eb42655dc346776ad8891af126d Gerrit-Change-Number: 29153 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:04:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: clone from gerrit.osmocom.org

by neels

Attention is currently required from: osmith, laforge, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29153 ) Change subject: jobs/master-builds: clone from gerrit.osmocom.org ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File jobs/master-builds.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29153/comment/60ccb7a4_7a7e34d3 PS2, Line 76: git_base_url: https://gitea.osmocom.org/sdr fatal: repository 'https://gitea.osmocom.org/sdr/' not found -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f345be55f5c7eb42655dc346776ad8891af126d Gerrit-Change-Number: 29153 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: meaningful error if debian/changelog is empty

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29097 ) Change subject: obs: meaningful error if debian/changelog is empty ...................................................................... obs: meaningful error if debian/changelog is empty If there's an empty debian/changelog, packaging needs to be fixed in the git repository of the project. Print a meaningful error instead of: File "/obs/lib/srcpkg.py", line 68, in get_version_for_feed if ":" in ret: TypeError: argument of type 'NoneType' is not iterable Change-Id: I294d844ccccfa12599b6ba1def087e4a32d289e7 --- M scripts/obs/lib/debian.py M scripts/obs/lib/srcpkg.py 2 files changed, 6 insertions(+), 8 deletions(-) Approvals: neels: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/obs/lib/debian.py b/scripts/obs/lib/debian.py index 89153fb..3bba3ec 100644 --- a/scripts/obs/lib/debian.py +++ b/scripts/obs/lib/debian.py @@ -73,14 +73,15 @@ repo_path = lib.git.get_repo_path(project) changelog_path = f"{repo_path}/debian/changelog" - if not os.path.exists(changelog_path): - return None + assert os.path.exists(changelog_path), f"{project}: missing debian/changelog" changelog = open(changelog_path).read() - if not changelog: - return None + assert changelog, f"{project}: debian/changelog is empty" - return changelog.split("(", 1)[1].split(")", 1)[0] + ret = changelog.split("(", 1)[1].split(")", 1)[0] + assert ret, f"{project}: couldn't find last version in debian/changelog" + + return ret def changelog_add_entry_if_needed(project, feed, version): diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index baf64a9..035cf81 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -70,9 +70,6 @@ if ":" in ret: ret = ret.split(":")[1] - if not ret: - ret = "0.0.0" - # Append the conflict_version to increase the version even if the commit # did not change (OS#5135) if conflict_version: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I294d844ccccfa12599b6ba1def087e4a32d289e7 Gerrit-Change-Number: 29097 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: improve manual: PFCP and GTP interfaces

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29143 ) Change subject: improve manual: PFCP and GTP interfaces ...................................................................... Patch Set 1: (2 comments) File doc/manuals/chapters/overview.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/29143/comment/bcf6c64c_06c431c9 PS1, Line 162: requires Linux kernel features ... requires *the following* Linux kernel features ... File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/29143/comment/c48f718b_80f68c2f PS1, Line 8: [-s] [-T] [-e 'LOGLEVEL'] Remove this (options are not present). -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iccb3f0f52bd5006bc94d0ca06ac5d3271ea89eb9 Gerrit-Change-Number: 29143 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:42:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: clone from gerrit.osmocom.org

by neels

Attention is currently required from: osmith, laforge, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29153 ) Change subject: jobs/master-builds: clone from gerrit.osmocom.org ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/29153/comment/c05eed9e_789a8231 PS2, Line 14: Related: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/message… Related: OS#5650 ? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f345be55f5c7eb42655dc346776ad8891af126d Gerrit-Change-Number: 29153 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:38:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libsmpp34[master]: README.md: fix copy-paste: s/libosmocore/libsmpp34/

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29077 ) Change subject: README.md: fix copy-paste: s/libosmocore/libsmpp34/ ...................................................................... README.md: fix copy-paste: s/libosmocore/libsmpp34/ Change-Id: Ic0b804f5b3e4ddfc7b6e71195f3acf4dae2c4297 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/README.md b/README.md index 2bca502..d2db059 100644 --- a/README.md +++ b/README.md @@ -58,5 +58,5 @@ <https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit> for more details -The current patch queue for libosmocore can be seen at +The current patch queue for libsmpp34 can be seen at <https://gerrit.osmocom.org/#/q/project:libsmpp34+status:open> -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Ic0b804f5b3e4ddfc7b6e71195f3acf4dae2c4297 Gerrit-Change-Number: 29077 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libsmpp34[master]: Makefile.am, configure.ac: fix autoreconf related warnings

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29080 ) Change subject: Makefile.am, configure.ac: fix autoreconf related warnings ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: what mystic sorcery is this -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I3199e7de0a04b4df89d01277cdb305d33902fcc2 Gerrit-Change-Number: 29080 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:31:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libsmpp34[master]: update git URLs (git -> https; gitea)

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29078 ) Change subject: update git URLs (git -> https; gitea) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Ic7adcdb289dff952f9897813ea1243cd1945c1ca Gerrit-Change-Number: 29078 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:30:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022