August 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

by Christian Amsüss

Attention is currently required from: laforge, pespin, dexter. Christian Amsüss has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29033 ) Change subject: Add new pySim.ota library, implement SIM OTA crypto ...................................................................... Patch Set 5: Code-Review+1 (5 comments) Patchset: PS5: Looks good to me, with some comments. I have yet to run the encryption and integrity protection against my current reference implementation; once that passes, I'll update to +2. File pySim/ota.py: https://gerrit.osmocom.org/c/pysim/+/29033/comment/ddba9d13_d60daa0d PS4, Line 44: S 102 225 Table 5 : ota_status_codes = bidict({ : 0x00: 'PoR OK', : 0x01: 'RC/CC/DS failed', : 0x02: 'CNTR low', : 0x03: 'CNTR high', : 0x04: 'CNTR blocked', : 0x05: 'Ciphering error', : 0x06: 'Unidentified security error', : 0x07: 'Insufficient memory', : 0x08: 'more time', : 0x09: 'TAR unknown', : 0x0a: 'Insufficient security level', : 0x0b: 'Actual Response in SMS-SUBMIT', # 31.115 : 0x0c: 'Actual Response in USSD', # 31.115 : }) This bidict is redundant with ResponseStatus, and not used anywhere. Maybe left over from earlier revisions? https://gerrit.osmocom.org/c/pysim/+/29033/comment/00b05de6_921f8369 PS4, Line 120: algo_auth: str, kid_idx: int, kid: bytes, cntr: int = 0): I'm very suspicious of the counter having zero as a default; the symmetric algorithm is already initialized with a zero IV, the CNTR and some of the other early bytes kind of take its place after the first round of encryption. I'm not an expert there, but unless someone who knows all the involved algorithms well tells me that this kind of nonce reuse is OK, I'd prefer APIs that guide users towards explicit monotonous CNTR values. File pySim/sms.py: https://gerrit.osmocom.org/c/pysim/+/29033/comment/c397e2d1_9844a98e PS5, Line 30: ie_c = Struct('offset'/Tell, 'iei'/Int8ub, 'length'/Int8ub, 'data'/Bytes(this.length)) There is an updated version of this in your patch series, which is easier to understand and removes the FIXME. https://gerrit.osmocom.org/c/pysim/+/29033/comment/b33ba117_4cde9e79 PS5, Line 39: def __str__(self) -> str: I think this would be more useful as `__repr__`, especially as it does produce an expression that'd recreate the object (ref: <https://docs.python.org/3/reference/datamodel.html#object.__repr__>). The %s could become %r but likely makes no difference for the typical list of ies. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 Gerrit-Change-Number: 29033 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 15:41:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: Fix handling of Re-Synchronization-Info AVP in AIR

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/29160 ) Change subject: Fix handling of Re-Synchronization-Info AVP in AIR ...................................................................... Abandoned You're welcome! -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/29160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ie5eded2f5fb2de01f69d2a9c0e5d70283bf5cbf5 Gerrit-Change-Number: 29160 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

2 years, 10 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: Fix handling of Re-Synchronization-Info AVP in AIR

by daniel

Attention is currently required from: laforge, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/29160 ) Change subject: Fix handling of Re-Synchronization-Info AVP in AIR ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: I tried, but something was still off. https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 did work though, so I merged that instead. In any case thanks for the help! -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/29160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ie5eded2f5fb2de01f69d2a9c0e5d70283bf5cbf5 Gerrit-Change-Number: 29160 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 15:35:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Improve handling resynchronization info

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 ) Change subject: server_cb: Improve handling resynchronization info ...................................................................... server_cb: Improve handling resynchronization info This commit improves handling of the resynchronization information in a DIAMETER request from a UE that has a sync failure. It factors parsing of the resync info into a helper function with a defined spec, and handles the resynchronization info as a binary rather than a string. Change-Id: I2aad313d4d37d07040bc5344de3a023d34fd8ded --- M src/server_cb.erl 1 file changed, 24 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/server_cb.erl b/src/server_cb.erl index dc7fe59..fc8e397 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -100,6 +100,22 @@ req_num_of_vec([#'Requested-UTRAN-GERAN-Authentication-Info'{'Number-Of-Requested-Vectors'=[Num]}]) -> Num; req_num_of_vec(_) -> false. + +-type binary_or_false() :: false | binary(). +-spec req_resynchronization_info([tuple()]) -> binary_or_false(). +req_resynchronization_info([#'Requested-EUTRAN-Authentication-Info'{'Re-Synchronization-Info'=[]}]) -> + false; +req_resynchronization_info([#'Requested-EUTRAN-Authentication-Info'{'Re-Synchronization-Info'=[Info]}]) -> + list_to_binary(Info); + +req_resynchronization_info([#'Requested-UTRAN-GERAN-Authentication-Info'{'Re-Synchronization-Info'=[]}]) -> + false; +req_resynchronization_info([#'Requested-UTRAN-GERAN-Authentication-Info'{'Re-Synchronization-Info'=[Info]}]) -> + list_to_binary(Info); + +req_resynchronization_info(_) -> + false. + -define(PDP_TYPE_DEFAULT, <<0,0,0,16#21>>). % IPv4 -define(PDP_QOS_DEFAULT, <<0,0,0,0,0,0,0,0,0,0,0,0,0,0>>). % fixme @@ -188,13 +204,14 @@ % construct GSUP request to HLR and transceive it GsupTx1 = #{message_type => send_auth_info_req, imsi => list_to_binary(UserName), supported_rat_types => [rat_eutran_sgs], current_rat_type => rat_eutran_sgs}, - case ReqEU of - #'Requested-EUTRAN-Authentication-Info'{'Re-Synchronization-Info' = ReSyncInfo} - when is_binary(ReSyncInfo) -> - GsupTx2 = #{rand => string:substr(ReSyncInfo, 1, 16), - auts => string:substr(ReSyncInfo, 17)}; - _ -> - GsupTx2 = #{} + ResyncInfo = req_resynchronization_info(ReqEU), + case ResyncInfo of + false -> + GsupTx2 = #{}; + ValidResyncInfo -> + lager:info("ResyncInfo is valid ~p", [ResyncInfo]), + GsupTx2 = #{rand => binary:part(ValidResyncInfo, 0, 16), + auts => binary:part(ValidResyncInfo, 16, 14)} end, GsupTx = maps:merge(GsupTx1, GsupTx2), GsupRx = gen_server:call(gsup_client, {transceive_gsup, GsupTx, send_auth_info_res, send_auth_info_err}), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2aad313d4d37d07040bc5344de3a023d34fd8ded Gerrit-Change-Number: 20021 Gerrit-PatchSet: 3 Gerrit-Owner: matt9j <matt9j(a)cs.washington.edu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Improve handling resynchronization info

by daniel

Attention is currently required from: matt9j, laforge, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 ) Change subject: server_cb: Improve handling resynchronization info ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: This fixes OS#5646. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2aad313d4d37d07040bc5344de3a023d34fd8ded Gerrit-Change-Number: 20021 Gerrit-PatchSet: 3 Gerrit-Owner: matt9j <matt9j(a)cs.washington.edu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: matt9j <matt9j(a)cs.washington.edu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Fri, 19 Aug 2022 15:33:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Improve handling resynchronization info

by fixeria

Attention is currently required from: laforge, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 ) Change subject: server_cb: Improve handling resynchronization info ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2aad313d4d37d07040bc5344de3a023d34fd8ded Gerrit-Change-Number: 20021 Gerrit-PatchSet: 3 Gerrit-Owner: matt9j <matt9j(a)cs.washington.edu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Fri, 19 Aug 2022 15:30:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: cosmetic: add spec reference

by neels

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29158 ) Change subject: cosmetic: add spec reference ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29158/comment/387a276a_ad5d637e PS1, Line 184: /* ITU-T Rec Q.713 */ this spec is about SCCP, not SUA? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 Gerrit-Change-Number: 29158 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: cosmetic: constify function parameters, return proper error

by neels

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 ) Change subject: cosmetic: constify function parameters, return proper error ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/8dc9229f_2543b9c4 PS1, Line 7: cosmetic: constify function parameters, return proper error the summary should indicate the scope ("sccp_scoc.c:...") Patchset: PS1: please separate "constify" and "change rc" in distinct commits File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/a872b49f_f0fa1b93 PS1, Line 704: return -ENOMSG; -ENOMEM would be the proper code here. but actually, none of the callers even look at the return code. what is this change about? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I398e3efa3e097de8907617cfdf363e1d3b96f666 Gerrit-Change-Number: 29159 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:49:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-netif[master]: Log more details in osmo_stream_srv_write()

by neels

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29082 ) Change subject: Log more details in osmo_stream_srv_write() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/29082/comment/80d6a6e6_eb3b114b PS1, Line 9: Log error code and amount of data - both are handy for debugging apps using the library. commit log line width is typically 72 this summarizes well: https://stackoverflow.com/questions/2290016/git-commit-messages-50-72-forma… -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f Gerrit-Change-Number: 29082 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:44:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: update git URLs (git -> https; gitea)

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29147 ) Change subject: update git URLs (git -> https; gitea) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: i'm not sure about changing git URLs, in principle: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/… -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7e0190b36861710d8cc8dd0cfd50d3dbe301ede5 Gerrit-Change-Number: 29147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:34:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022