August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: hnbgw: Add test to check for duplicate hnb registrations

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29198 ) Change subject: hnbgw: Add test to check for duplicate hnb registrations ...................................................................... hnbgw: Add test to check for duplicate hnb registrations Change-Id: Ib20d07ffabb91dfa82c212aaa363cafc7496bba8 Related: OS#6084 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 33 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/29198/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 81d9f1a..91b0d64 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -195,7 +195,7 @@ } -const integer NUM_HNB := 1; +const integer NUM_HNB := 2; type record HnbConfig { LocationAreaIdentification lai, @@ -290,13 +290,6 @@ /* global initialization function */ function f_init(charstring id := "HNBGW", float guard_timeout := 30.0) runs on test_CT { - g_hnb_cfg[0] := { - lai := { - mcc_mnc := '00101'H, - lac := 2342 - }, - sac := 55 - } T_guard.start(guard_timeout); activate(as_Tguard()); @@ -306,6 +299,13 @@ unitdata_cb := refers(IuhRanapUnitdataCallback) }; for (var integer i := 0; i < NUM_HNB; i := i+1) { + g_hnb_cfg[i] := { + lai := { + mcc_mnc := '00101'H, + lac := 2342 + i + }, + sac := 55 + }; f_init_hnodeb(testcasename(), i, rua_ops); } @@ -344,7 +344,7 @@ /* helper function to start all of the simulated hNodeBs */ function f_start_hnbs() runs on test_CT { for (var integer i:= 0; i < NUM_HNB; i := i+1) { - f_hnbap_register(i); + f_hnbap_register(i, i); } } @@ -601,13 +601,13 @@ ***********************************************************************/ -function f_hnbap_register(integer hnb_idx := 0) runs on test_CT +function f_hnbap_register(integer hnb_idx := 0, integer cell_id := 0, boolean expect_reject := false) runs on test_CT { timer T := 2.0; HNBAP[hnb_idx].send(tr_HNBAP_HNBRegisterRequest(char2oct("TTCN3 HNodeB"), '00F110'O, - int2bit(1 + hnb_idx, 28), + int2bit(1 + cell_id, 28), int2oct(2, 2), int2oct(3, 1), int2oct(4, 2))); @@ -615,13 +615,24 @@ T.start; alt { [] HNBAP[hnb_idx].receive(tr_HNBAP_HNBRegisterAccept(?)) { - setverdict(pass); + if (expect_reject) { + setverdict(fail); + } else { + setverdict(pass); + } + } + [] HNBAP[hnb_idx].receive(tr_HNBAP_HNBRegisterReject(?)) { + if (expect_reject) { + setverdict(pass); + } else { + setverdict(fail); + } } [] HNBAP[hnb_idx].receive(IUHEM_Event:?) { repeat; } [] T.timeout { - setverdict(fail, "Timeout waiting for HNB Register Accept"); + setverdict(fail, "Timeout waiting for HNB Register response"); } } } @@ -632,6 +643,14 @@ f_shutdown_helper(); } +testcase TC_hnb_register_duplicate() runs on test_CT { + f_init(); + f_hnbap_register(0); + f_hnbap_register(1, 0, expect_reject := true); + f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 1); + f_shutdown_helper(); +} + /*********************************************************************** * RUA / RANAP Testing ***********************************************************************/ @@ -1144,6 +1163,7 @@ control { execute(TC_hnb_register()); + execute(TC_hnb_register_duplicate()); execute(TC_ranap_cs_initial_ue()); execute(TC_ranap_ps_initial_ue()); execute(TC_ranap_cs_initial_ue_empty_cr()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib20d07ffabb91dfa82c212aaa363cafc7496bba8 Gerrit-Change-Number: 29198 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: Install show talloc-context VTY commands

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29196 ) Change subject: Install show talloc-context VTY commands ...................................................................... Install show talloc-context VTY commands Related: OS#5656 Change-Id: Ia4b0023028405ce065f618f536c92ea2bcd0ce15 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/96/29196/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 526622b..fe503f8 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -49,6 +49,7 @@ #include <osmocom/ctrl/ports.h> #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h> +#include <osmocom/vty/misc.h> #include <osmocom/vty/command.h> #include <osmocom/vty/ports.h> @@ -623,6 +624,7 @@ exit(1); } + vty_info.tall_ctx = tall_hnb_ctx; vty_info.copyright = osmo_hnbgw_copyright; vty_init(&vty_info); @@ -631,6 +633,7 @@ hnbgw_vty_init(g_hnb_gw, tall_hnb_ctx); ctrl_vty_init(tall_hnb_ctx); logging_vty_add_cmds(); + osmo_talloc_vty_add_cmds(); /* Handle options after vty_init(), for --version */ handle_options(argc, argv); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia4b0023028405ce065f618f536c92ea2bcd0ce15 Gerrit-Change-Number: 29196 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels, laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 14: (3 comments) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/56fc9585_4b6c502b PS4, Line 580: if (prim && msgb_l2(prim->oph.msg) && msgb_l2len(prim->oph.msg)) { > exit early […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/74875340_b63c288a PS4, Line 585: xua_msg_free(xua); > I agree, it feels rather odd if a function supposedly adding a bit to caller-provided 'xua' suddenly […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/8fa01b13_7a79393a PS4, Line 615: if (!xua_add_data(prim, xua, "4.2")) > this looks like a mem leak of above xua_msg_alloc(). […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 23 Aug 2022 10:15:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by fixeria

Attention is currently required from: neels, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 14: (1 comment) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/c654ca9a_1f862a77 PS8, Line 603: xua_class_msg_name > I don't think it's worth bothering actually: this log is unlikely to be triggered in a first place, […] Ack, not a merge blocker. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Aug 2022 10:10:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 14: (1 comment) This change is ready for review. File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/fd72159f_34145962 PS8, Line 603: xua_class_msg_name > Nope, this does now solve the problem. […] I don't think it's worth bothering actually: this log is unlikely to be triggered in a first place, and for static name collision to happen both expected AND current msg_type have to be unknown - which makes it even more unlikely. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Aug 2022 10:09:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmo-deps.sh: use osmo_git_clone_url

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29191 ) Change subject: scripts/osmo-deps.sh: use osmo_git_clone_url ...................................................................... scripts/osmo-deps.sh: use osmo_git_clone_url Instead of hardcoding https://git.osmocom.org for all clones, use the osmo_git_clone_url function. This clones via https from gerrit where possible, it should fix the many errors we are currently seeing from the master-openbsc job: + osmo-deps.sh libosmo-sccp + project=libosmo-sccp + branch=master + git branch -a + grep -c remotes/origin/master$ + [ x1 != x0 ] + branch=origin/master + test -d libosmo-sccp + git clone https://git.osmocom.org/libosmo-sccp libosmo-sccp Cloning into 'libosmo-sccp'... error: HTTP/2 stream 0 was closed cleanly, but before getting all response header fields, treated as error (curl_result = 92, http_code = 0, sha1 = d23e38020fdbb685570145acd3a35e22a5a91344) error: HTTP/2 stream 0 was closed cleanly, but before getting all response header fields, treated as error (curl_result = 92, http_code = 0, sha1 = 68b450098714e3015a65b6628a7e61ac09dd4d47) error: Unable to find 68b450098714e3015a65b6628a7e61ac09dd4d47 under https://git.osmocom.org/libosmo-sccp Cannot obtain needed tree 68b450098714e3015a65b6628a7e61ac09dd4d47 while processing commit d23e38020fdbb685570145acd3a35e22a5a91344. error: fetch failed. Related: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/… Change-Id: I700d608ff74eca3981ed41f04ee9ced9629436aa --- M scripts/osmo-deps.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/scripts/osmo-deps.sh b/scripts/osmo-deps.sh index af3d555..59ecce0 100755 --- a/scripts/osmo-deps.sh +++ b/scripts/osmo-deps.sh @@ -1,4 +1,5 @@ #!/bin/sh +. "$(dirname "$0")/common.sh" set -ex project="$1" branch="${2:-master}" @@ -8,9 +9,8 @@ fi -if ! test -d "$project"; -then - git clone "https://git.osmocom.org/$project" "$project" +if ! test -d "$project"; then + git clone "$(osmo_git_clone_url "$project")" "$project" fi cd "$project" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I700d608ff74eca3981ed41f04ee9ced9629436aa Gerrit-Change-Number: 29191 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: mobile: fix description of 'test re-selection' command

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29172 ) Change subject: mobile: fix description of 'test re-selection' command ...................................................................... mobile: fix description of 'test re-selection' command Change-Id: I254effd067b64ae0bfe1afe646701c0c6ea942ea --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index 57bc863..d6f6cd1 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -977,8 +977,11 @@ return CMD_SUCCESS; } +#define TEST_CMD_DESC "Special commands for testing\n" + DEFUN(test_reselection, test_reselection_cmd, "test re-selection NAME", - "Manually trigger cell re-selection\nName of MS (see \"show ms\")") + TEST_CMD_DESC "Manually trigger cell re-selection\n" + "Name of MS (see \"show ms\")") { struct osmocom_ms *ms; struct gsm_settings *set; 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I254effd067b64ae0bfe1afe646701c0c6ea942ea Gerrit-Change-Number: 29172 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: Bump version: 0.1.0.32-823b → 0.1.1

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 ) Change subject: Bump version: 0.1.0.32-823b → 0.1.1 ...................................................................... Bump version: 0.1.0.32-823b → 0.1.1 Tag a new release with all the packaging fixes, so building libosmo-pfcp for latest isn't failing anymore on obs.osmocom.org. Related: OS#5654 Change-Id: I9a7be8342754fdbc21b83281c8ebcbf38112c61b --- M debian/changelog 1 file changed, 44 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index e16e70f..10cbd24 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,47 @@ +libosmo-pfcp (0.1.1) unstable; urgency=medium + + [ Vadim Yanitskiy ] + * fix incorrect timeout values: milliseconds vs microseconds + * configure: fix AC_CONFIG_MACRO_DIRS related warnings + * configure: fix warning: AC_OUTPUT should be used without arguments + * gitignore: ignore *.la objects: libosmo-{gtlv,pfcp}.la + * contrib/libosmo-pfcp.spec.in: do not depend on systemd + * contrib/libosmo-pfcp.spec.in: do not disable LTO + * configure.ac: do not require unused dlopen + + [ Neels Hofmeyr ] + * separate pfcp_queue_timer_cb() in req and resp + * fix wrong constants used in osmo_pfcp_tdefs (typo) + * clarify osmo_pfcp_msg alloc API + * apply code review: refactor pfcp_endpoint API + * pfcp_endpoint: fix final PFCP retrans resp_cb + * set LIBVERSION=0:0:0 + * comment / whitespace tweaks in pfcp_endpoint.c + * debian packaging of libosmo-gtlv and libosmo-pfcp + * README.md: tweak clone URL + * configure.ac: drop dependencies on vty and ctrl + * RPM: fix .spec file + * debian: add missing *-dev.install files + * debian/control: fix confusion in description + * debian: fix missing dep gtlv0 <- pfcp0 + * libosmo-gtlv.pc.in: tweak Description + * fix warnings: 'uninitialized' + * .gitignore fixes: generated sources, .spec file + * doc: minor fix in pfcp_cp_peer_fsm.dot + * pfcp_cp_peer: check use count correctness + * RPM: fix configure and typo "gltv" in .spec.in + + [ Oliver Smith ] + * gitreview: fix project + * rpm spec: use --disable-static + * debian/control: move -dev deps of libosmo-gtlv-dev + * packaging: depend on libosmocore >= 1.7.0 + + [ Harald Welte ] + * rpm spec: reduce summary line length + + -- Oliver Smith <osmith(a)sysmocom.de> Mon, 22 Aug 2022 11:38:51 +0200 + libosmo-pfcp (0.1.0) testing; urgency=low Create new Debian package. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I9a7be8342754fdbc21b83281c8ebcbf38112c61b Gerrit-Change-Number: 29186 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: layer23: use $(top_srcdir) instead of relative paths

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29176 ) Change subject: layer23: use $(top_srcdir) instead of relative paths ...................................................................... layer23: use $(top_srcdir) instead of relative paths Change-Id: I320ed2295c0c8e12a46be416e3dbda8865987424 --- M src/host/layer23/src/misc/Makefile.am 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/misc/Makefile.am b/src/host/layer23/src/misc/Makefile.am index 3d32592..4daaf91 100644 --- a/src/host/layer23/src/misc/Makefile.am +++ b/src/host/layer23/src/misc/Makefile.am @@ -32,31 +32,31 @@ $(NULL) bcch_scan_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_bcch_scan.c \ bcch_scan.c \ $(NULL) ccch_scan_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_ccch_scan.c \ rslms.c \ $(NULL) echo_test_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_echo_test.c \ $(NULL) cell_log_LDADD = $(LDADD) -lm cell_log_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_cell_log.c \ cell_log.c \ geo.c \ $(NULL) cbch_sniff_SOURCES = \ - ../common/main.c \ + $(top_srcdir)/src/common/main.c \ app_cbch_sniff.c \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I320ed2295c0c8e12a46be416e3dbda8865987424 Gerrit-Change-Number: 29176 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: layer23: use $(top_builddir) instead of relative paths

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29177 ) Change subject: layer23: use $(top_builddir) instead of relative paths ...................................................................... layer23: use $(top_builddir) instead of relative paths Change-Id: Ib2c9264b2a3cdef9b9852bdead94bae03185fec8 --- M src/host/layer23/src/misc/Makefile.am M src/host/layer23/src/mobile/Makefile.am 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/misc/Makefile.am b/src/host/layer23/src/misc/Makefile.am index 4daaf91..ad48bda 100644 --- a/src/host/layer23/src/misc/Makefile.am +++ b/src/host/layer23/src/misc/Makefile.am @@ -11,7 +11,7 @@ $(NULL) LDADD = \ - ../common/liblayer23.a \ + $(top_builddir)/src/common/liblayer23.a \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCODEC_LIBS) \ diff --git a/src/host/layer23/src/mobile/Makefile.am b/src/host/layer23/src/mobile/Makefile.am index 00f10a9..8fefdfa 100644 --- a/src/host/layer23/src/mobile/Makefile.am +++ b/src/host/layer23/src/mobile/Makefile.am @@ -36,7 +36,7 @@ mobile_SOURCES = main.c app_mobile.c mobile_LDADD = \ libmobile.a \ - ../common/liblayer23.a \ + $(top_builddir)/src/common/liblayer23.a \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOGSM_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib2c9264b2a3cdef9b9852bdead94bae03185fec8 Gerrit-Change-Number: 29177 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022