August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: debian: add missing deps

by neels

Attention is currently required from: neels. Hello osmith, Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/29142 to look at the new patch set (#2). Change subject: debian: add missing deps ...................................................................... debian: add missing deps also we don't really need to depend on gtlv. Related: SYS#5599 Change-Id: I068736d513ddb54b9a62c1d7970a0fbff3095b4b --- M debian/control 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/42/29142/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I068736d513ddb54b9a62c1d7970a0fbff3095b4b Gerrit-Change-Number: 29142 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: improve manual: PFCP and GTP interfaces

by neels

Attention is currently required from: neels, fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/29143 to look at the new patch set (#2). Change subject: improve manual: PFCP and GTP interfaces ...................................................................... improve manual: PFCP and GTP interfaces Related: SYS#5599 Change-Id: Iccb3f0f52bd5006bc94d0ca06ac5d3271ea89eb9 --- M doc/manuals/chapters/overview.adoc A doc/manuals/chapters/running.adoc 2 files changed, 208 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/43/29143/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iccb3f0f52bd5006bc94d0ca06ac5d3271ea89eb9 Gerrit-Change-Number: 29143 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: example cfg: tweak logging

by neels

Attention is currently required from: neels. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/29144 to look at the new patch set (#2). Change subject: example cfg: tweak logging ...................................................................... example cfg: tweak logging Related: SYS#5599 Change-Id: I6b767b2e9f023cdbe5d2ea014e2d41878e848d24 --- M doc/examples/osmo-upf/osmo-upf-create-dev.cfg M doc/examples/osmo-upf/osmo-upf-mockup.cfg M doc/examples/osmo-upf/osmo-upf.cfg 3 files changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/44/29144/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I6b767b2e9f023cdbe5d2ea014e2d41878e848d24 Gerrit-Change-Number: 29144 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: pkgconfig: add missing 'Requires:'

by fixeria

Attention is currently required from: osmith, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29201 ) Change subject: pkgconfig: add missing 'Requires:' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I018caa584cb1f5fa1b2a7e6e6f9ec26e5b54eea7 Gerrit-Change-Number: 29201 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Aug 2022 21:35:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-gprs[master]: libosmo-{csn1,gprs-rlcmac}.pc.in: add missing Requires

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29203 ) Change subject: libosmo-{csn1,gprs-rlcmac}.pc.in: add missing Requires ...................................................................... libosmo-{csn1,gprs-rlcmac}.pc.in: add missing Requires Change-Id: I673a51fbf8ee339b20baca4998ef79e96170f21e --- M libosmo-csn1.pc.in M libosmo-gprs-rlcmac.pc.in 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/03/29203/1 diff --git a/libosmo-csn1.pc.in b/libosmo-csn1.pc.in index c2e1ff8..b338bbe 100644 --- a/libosmo-csn1.pc.in +++ b/libosmo-csn1.pc.in @@ -6,5 +6,6 @@ Name: Osmocom CSN.1 Codec Library Description: C Utility Library Version: @VERSION@ +Requires: libosmocore Libs: -L${libdir} -losmo-csn1 Cflags: -I${includedir}/ diff --git a/libosmo-gprs-rlcmac.pc.in b/libosmo-gprs-rlcmac.pc.in index 4108c36..5424485 100644 --- a/libosmo-gprs-rlcmac.pc.in +++ b/libosmo-gprs-rlcmac.pc.in @@ -6,5 +6,6 @@ Name: Osmocom [E]GPRS RLC/MAC Library Description: C Utility Library Version: @VERSION@ +Requires: libosmocore, libosmo-csn1 Libs: -L${libdir} -losmo-gprs-rlcmac Cflags: -I${includedir}/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I673a51fbf8ee339b20baca4998ef79e96170f21e Gerrit-Change-Number: 29203 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: mobile: mobile_start(): fix grammar in logging messages

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29171 ) Change subject: mobile: mobile_start(): fix grammar in logging messages ...................................................................... mobile: mobile_start(): fix grammar in logging messages Change-Id: Ibe8afb6a79613096c4ace86cc44867d0e9f8de76 --- M src/host/layer23/src/mobile/app_mobile.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index 0cb00c4..57b472f 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -251,7 +251,7 @@ if (!strcmp(ms->settings.layer2_socket_path, tmp->settings.layer2_socket_path)) { LOGP(DMOB, LOGL_ERROR, "Cannot start MS '%s', because MS '%s' " - "use the same layer2-socket.\nPlease shutdown " + "is using the same layer2-socket.\nPlease shutdown " "MS '%s' first.\n", ms->name, tmp->name, tmp->name); *other_name = tmp->name; return -1; @@ -259,7 +259,7 @@ if (!strcmp(ms->settings.sap_socket_path, tmp->settings.sap_socket_path)) { LOGP(DMOB, LOGL_ERROR, "Cannot start MS '%s', because MS '%s' " - "use the same sap-socket.\nPlease shutdown " + "is using the same sap-socket.\nPlease shutdown " "MS '%s' first.\n", ms->name, tmp->name, tmp->name); *other_name = tmp->name; return -2; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibe8afb6a79613096c4ace86cc44867d0e9f8de76 Gerrit-Change-Number: 29171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 ) Change subject: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic ...................................................................... BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic In cases a), b), c), d), and e) we're sending one or more Measurement Reports via the A-bis/RSL, and then immediately triggering a traffic channel assignment by calling f_TC_chan_alloc_algo(), which sends an Assignment Request via the A interface. The above-mentioned messages are sent immediately all together, so it may happen that the BSC handles the Assignment Request earlier than the Measurement Report(s). In this case there will be no RxLev samples, so the BSC would fall-back to ascending allocation order. Recently we saw this race condition actually happening on Jenkins: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test-sccplite/… Let's introduce an artificial delay before sending the Assignment Request, so that the BSC has enough time to process received MRs. Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/02/29202/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 7f4ce46..09cd717 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11666,6 +11666,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 0, ts_RSL_IE_UplinkMeas(30, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); @@ -11677,6 +11678,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(48, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); @@ -11688,6 +11690,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(58, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX3); f_perform_clear_test_ct(dt); @@ -11703,6 +11706,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(58, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 Gerrit-Change-Number: 29202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: gsm0408_test: do not print errno in expected output

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29200 ) Change subject: gsm0408_test: do not print errno in expected output ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87d125fb4e04b2130f653db1ed76691528e43411 Gerrit-Change-Number: 29200 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Aug 2022 18:27:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: hnbgw_hnbap: Fix memory leaks in HNBAP handling

by fixeria

Attention is currently required from: daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29199 ) Change subject: hnbgw_hnbap: Fix memory leaks in HNBAP handling ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3ba02b0939413c67bc8088ea1a8f2252fc2bda31 Gerrit-Change-Number: 29199 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Aug 2022 18:24:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: Install show talloc-context VTY commands

by fixeria

Attention is currently required from: daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29196 ) Change subject: Install show talloc-context VTY commands ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia4b0023028405ce065f618f536c92ea2bcd0ce15 Gerrit-Change-Number: 29196 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Aug 2022 18:23:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022