Attention is currently required from: neels, laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817
to look at the new patch set (#6).
Change subject: add library/PFCP_*, deps/PFCP
......................................................................
add library/PFCP_*, deps/PFCP
Will soon be used by new subdir 'upf' (test osmo-upf),
and by 'hnbgw' (test GTP mapping via UPF).
Related: SYS#5599
Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
---
M deps/Makefile
M library/General_Types.ttcn
A library/PFCP_CodecPort.ttcn
A library/PFCP_CodecPort_CtrlFunct.ttcn
A library/PFCP_CodecPort_CtrlFunctDef.cc
A library/PFCP_Emulation.ttcn
A library/PFCP_Templates.ttcn
7 files changed, 926 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/28817/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
Gerrit-Change-Number: 28817
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29054 )
Change subject: fix warnings: 'uninitialized'
......................................................................
fix warnings: 'uninitialized'
Though these can never be used uninitialized, initialize to NULL to
avoid compiler warnings like:
pfcp_msg.c:188:66: warning: 'h_no_seid' may be used uninitialized
Change-Id: Icb338b200fe3186ccd7fd3f502c1723f60947190
---
M src/libosmo-gtlv/gtlv_dec_enc.c
M src/libosmo-pfcp/pfcp_msg.c
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/54/29054/1
diff --git a/src/libosmo-gtlv/gtlv_dec_enc.c b/src/libosmo-gtlv/gtlv_dec_enc.c
index 2e5509a..c3e45ea 100644
--- a/src/libosmo-gtlv/gtlv_dec_enc.c
+++ b/src/libosmo-gtlv/gtlv_dec_enc.c
@@ -71,7 +71,7 @@
{
void *obj = MEMB(decoded_struct, obj_ofs);
const struct osmo_gtlv_coding *iec;
- unsigned int *multi_count_p;
+ unsigned int *multi_count_p = NULL;
/* To check for presence of mandatory IEs, need to keep a flag stack of seen ie_coding entries. This array has
* to have at least the nr of entries that the ie_coding array has. Let's allow up to this many ie_coding
diff --git a/src/libosmo-pfcp/pfcp_msg.c b/src/libosmo-pfcp/pfcp_msg.c
index 5f55575..098ffa2 100644
--- a/src/libosmo-pfcp/pfcp_msg.c
+++ b/src/libosmo-pfcp/pfcp_msg.c
@@ -158,8 +158,8 @@
static int enc_pfcp_header(struct msgb *msg, const struct osmo_pfcp_msg *m)
{
const struct osmo_pfcp_header_parsed *parsed = &m->h;
- struct osmo_pfcp_header_seid *h_seid;
- struct osmo_pfcp_header_no_seid *h_no_seid;
+ struct osmo_pfcp_header_seid *h_seid = NULL;
+ struct osmo_pfcp_header_no_seid *h_no_seid = NULL;
struct osmo_pfcp_header_common *c;
int rc;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29054
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Icb338b200fe3186ccd7fd3f502c1723f60947190
Gerrit-Change-Number: 29054
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newchange
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29051 )
Change subject: debian/control: fix confusion in description
......................................................................
debian/control: fix confusion in description
Change-Id: I380b1dd626b3e6a35f17ae09a6758bef59f51c84
---
M debian/control
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/51/29051/1
diff --git a/debian/control b/debian/control
index d1f8b43..ca7eaa6 100644
--- a/debian/control
+++ b/debian/control
@@ -46,7 +46,7 @@
Section: libdevel
Depends: ${misc:Depends},
libosmo-gtlv0 (= ${binary:Version})
-Description: Development headers for libosmo-gtlv
+Description: Development files for libosmo-gtlv
libosmo-gtlv implements decoding, encoding and logging of protocols using a
Tag-Length-Value and/or Tag-Length-Instance-Value structure. This package in
particular contains the files for compiling a program using this library.
@@ -80,7 +80,7 @@
Section: libdevel
Depends: ${misc:Depends},
libosmo-pfcp0 (= ${binary:Version})
-Description: Development headers for libosmo-pfcp
+Description: Development files for libosmo-pfcp
libosmo-pfcp implements decoding, encoding and endpoint implementation of the
Packet Forwarding Control Protocol (3GPP TS 29.244). This package in particular
contains the files for compiling a program using this library.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29051
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I380b1dd626b3e6a35f17ae09a6758bef59f51c84
Gerrit-Change-Number: 29051
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newchange