Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28772 )
Change subject: client: Option to ignore any ATR sent by bankd
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28772
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I930293f7b637dba60d9dd6d2254f4524f831b491
Gerrit-Change-Number: 28772
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 24 Jul 2022 11:58:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28768 )
Change subject: filesystem: We can select not just immediate parent DF but all ancestors
......................................................................
Patch Set 1:
(1 comment)
File pySim/filesystem.py:
https://gerrit.osmocom.org/c/pysim/+/28768/comment/4dfad558_4d89e756
PS1, Line 197: alias: str = None
Unused argument. Also, should be Optional[str].
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28768
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic9037aa9a13af6fb0c2c22b673aa4afa78575b49
Gerrit-Change-Number: 28768
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 24 Jul 2022 11:42:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28773 )
Change subject: bankd: Don't log an "Error" if slotmap is removed
......................................................................
bankd: Don't log an "Error" if slotmap is removed
removing a slotmap and the related client disconnect are perfectly
normal operation. Don't print the word Error in the log in such cases,
it just confuses the user.
Closes: OS#5629
Change-Id: Ie39d35fd348fdf3dd53c860dc830aac794a3ead5
---
M src/bankd/bankd_main.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/73/28773/1
diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c
index c2d6e69..b3b8dff 100644
--- a/src/bankd/bankd_main.c
+++ b/src/bankd/bankd_main.c
@@ -986,7 +986,10 @@
break;
}
- LOGW(g_worker, "Error %d occurred: Cleaning up state\n", rc);
+ if (rc == -23)
+ LOGW(g_worker, "Client unmapped: Cleaning up state\n");
+ else
+ LOGW(g_worker, "Error %d occurred: Cleaning up state\n", rc);
/* clean-up: reset to sane state */
memset(&g_worker->card, 0, sizeof(g_worker->card));
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28773
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ie39d35fd348fdf3dd53c860dc830aac794a3ead5
Gerrit-Change-Number: 28773
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange