July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-msc[master]: missing whitespace in gsm_04_08_cc.c

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/28778 ) Change subject: missing whitespace in gsm_04_08_cc.c ...................................................................... missing whitespace in gsm_04_08_cc.c Change-Id: If9e2f543d1924421c1a1f1e1e100c7d9fb63c139 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/78/28778/1 diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 281a386..a06e997 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -727,9 +727,10 @@ /* Create a copy of the bearer capability * in the transaction struct, so we can use * this information later */ - memcpy(&trans->bearer_cap,&call_conf.bearer_cap, + memcpy(&trans->bearer_cap, &call_conf.bearer_cap, sizeof(trans->bearer_cap)); } + /* cause */ if (TLVP_PRESENT(&tp, GSM48_IE_CAUSE)) { call_conf.fields |= MNCC_F_CAUSE; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If9e2f543d1924421c1a1f1e1e100c7d9fb63c139 Gerrit-Change-Number: 28778 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-msc[master]: err log: fix reverse statement in msc_a call handling

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/28779 ) Change subject: err log: fix reverse statement in msc_a call handling ...................................................................... err log: fix reverse statement in msc_a call handling Change-Id: I937abe25ba87d0fcddc3351ac391cf6e7e776de6 --- M src/libmsc/msc_a.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/79/28779/1 diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 5761ed7..f00fb11 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1319,7 +1319,7 @@ return; } if (!cc_trans) { - LOG_MSC_A(msc_a, LOGL_ERROR, "Rx Assignment Complete, but CC transaction is active\n"); + LOG_MSC_A(msc_a, LOGL_ERROR, "Rx Assignment Complete, but no CC transaction is active\n"); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I937abe25ba87d0fcddc3351ac391cf6e7e776de6 Gerrit-Change-Number: 28779 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cosmetic: smscb_message_fsm.c: Fix typo in comment

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28776 ) Change subject: cosmetic: smscb_message_fsm.c: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2eb15c2401efa9b07a51dbe71997da01aab30bba Gerrit-Change-Number: 28776 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 11:35:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gsm_23_041.h: Define CBS ETWS Warning Type values

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28739 ) Change subject: gsm_23_041.h: Define CBS ETWS Warning Type values ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5bb9b2c77b8e4a984631d199fc073183691c31 Gerrit-Change-Number: 28739 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 10:52:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cosmetic: smscb_message_fsm.c: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28776 ) Change subject: cosmetic: smscb_message_fsm.c: Fix typo in comment ...................................................................... cosmetic: smscb_message_fsm.c: Fix typo in comment Change-Id: I2eb15c2401efa9b07a51dbe71997da01aab30bba --- M src/smscb_message_fsm.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/76/28776/1 diff --git a/src/smscb_message_fsm.c b/src/smscb_message_fsm.c index 025acb7..0796587 100644 --- a/src/smscb_message_fsm.c +++ b/src/smscb_message_fsm.c @@ -287,19 +287,19 @@ { switch (fi->T) { case T_WAIT_WRITE_ACK: - /* onexit will take care of notifying the user */ + /* onleave will take care of notifying the user */ osmo_fsm_inst_state_chg(fi, SMSCB_S_ACTIVE, 0, 0); break; case T_WAIT_REPLACE_ACK: - /* onexit will take care of notifying the user */ + /* onleave will take care of notifying the user */ osmo_fsm_inst_state_chg(fi, SMSCB_S_ACTIVE, 0, 0); break; case T_WAIT_STATUS_ACK: - /* onexit will take care of notifying the user */ + /* onleave will take care of notifying the user */ osmo_fsm_inst_state_chg(fi, SMSCB_S_ACTIVE, 0, 0); break; case T_WAIT_DELETE_ACK: - /* onexit will take care of notifying the user */ + /* onleave will take care of notifying the user */ osmo_fsm_inst_state_chg(fi, SMSCB_S_DELETED, 0, 0); break; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2eb15c2401efa9b07a51dbe71997da01aab30bba Gerrit-Change-Number: 28776 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: ttcn3-cbc: Set mode server in osmo-cbc.cfg

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28775 ) Change subject: ttcn3-cbc: Set mode server in osmo-cbc.cfg ...................................................................... ttcn3-cbc: Set mode server in osmo-cbc.cfg TCP/SCTP client support was added recently in osmo-cbc. Since then, the connection mode (client|server|disabled) needs to be specified in the config. Let's update osmo-cbc.git to provide the correct info in here. Requires: osmo-cbc.git Change-Id I3ec54b615b41b56f7a9c64298e3fcaac37f4b60e Change-Id: I2e3a806a8371011cdb4c3b1f194e132d3896374e --- M ttcn3-cbc-test/osmo-cbc.cfg 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/75/28775/1 diff --git a/ttcn3-cbc-test/osmo-cbc.cfg b/ttcn3-cbc-test/osmo-cbc.cfg index 0e131c0..c2c1b7b 100644 --- a/ttcn3-cbc-test/osmo-cbc.cfg +++ b/ttcn3-cbc-test/osmo-cbc.cfg @@ -32,8 +32,10 @@ local-ip 172.18.27.20 local-port 29168 peer cbsp ttcn3-bsc + mode server remote-port 9999 remote-ip 172.18.27.100 peer sbcap ttcn3-mme + mode server remote-port 9998 remote-ip 172.18.27.100 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2e3a806a8371011cdb4c3b1f194e132d3896374e Gerrit-Change-Number: 28775 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gsm_23_041.h: Define CBS ETWS Warning Type values

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28739 ) Change subject: gsm_23_041.h: Define CBS ETWS Warning Type values ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/28739/comment/76361afb_35082efa PS3, Line 7: Document > define? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5bb9b2c77b8e4a984631d199fc073183691c31 Gerrit-Change-Number: 28739 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 09:26:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmo-pfcp[master]: apply code review: refactor pfcp_endpoint API

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 ) Change subject: apply code review: refactor pfcp_endpoint API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: You are improving the state ofn things halfway, since you implemented some API getters/setter for some fields, but not for others. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: If80c35c6a942bf9593781b5a6bc28ba37323ce5e Gerrit-Change-Number: 28754 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 09:05:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmo-pfcp[master]: clarify osmo_pfcp_msg alloc API

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28750 ) Change subject: clarify osmo_pfcp_msg alloc API ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I0d71134e42932cc72992eba73a15e82bc7cd11bd Gerrit-Change-Number: 28750 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 09:02:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trx_toolkit: do not auto power on/off child MS Transceivers

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28761 ) Change subject: trx_toolkit: do not auto power on/off child MS Transceivers ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0cd6bac616273bed0e246ad48edc44fff484c589 Gerrit-Change-Number: 28761 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 09:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022