Attention is currently required from: laforge, pespin, lynxis lazus.
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28338 )
Change subject: Refactor smsq_take_next_sms()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm somewhat skeptical it makes sense to merge this to master. […]
ACK. Well we don't want to add extra days!
There are things in this patchset that fix some flawed logic and help to get all SMS delivered. They probably apply regardless of the storage backend. I'm happy to run this code locally until we are rid of SQL, then I can refactor and submit this
work on top of that.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28338
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I06c418d4919dd8d28c643b7e0a735bc74d66212c
Gerrit-Change-Number: 28338
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 20 Jun 2022 19:56:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340 )
Change subject: Avoid UPDATE immediately followed by DELETE
......................................................................
Patch Set 1:
(2 comments)
File src/libmsc/db.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/0344d2a3_1a05676f
PS1, Line 314: [DB_STMT_SMS_DEL_SENT_BY_ID] =
> what's the point in having the 2 of them?
WIP I guess. I'm not really sure what statements might up end being wanted.
All this /could/ be cleaned up further, we don't need most of the tables created in the db for example.
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/0520995c_b9a5dc4c
PS1, Line 871: /* msc_vlr tests will not pass any sms_queue, hence need to check smq != NULL */
> Rather better fix the tests to pass a valid smq pointer.
The db code contains similar "hacks" to have the tests pass.
I think the smq pointer is not relevant to what the test is checking in this case.
Anyway, all moot if I do what you suggest below...
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603
Gerrit-Change-Number: 28340
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Jun 2022 19:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28339 )
Change subject: Use unix timestamps in the SMS db
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> You are probably breaking backward compatibility with older existing databases here? This may need a […]
Yes. But compatibility with existing databases was already broken in
https://gerrit.osmocom.org/c/osmo-msc/+/28114 and that commit states:
"I decided to remove the database migration code as it would be......."
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I599a57666da22adf806b01ff095c8672d523a737
Gerrit-Change-Number: 28339
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Jun 2022 19:42:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment