Attention is currently required from: pespin. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340 ) Change subject: Avoid UPDATE immediately followed by DELETE ...................................................................... Patch Set 1: (2 comments) File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/0344d2a3_1a05676f PS1, Line 314: [DB_STMT_SMS_DEL_SENT_BY_ID] =

what's the point in having the 2 of them? WIP I guess. I'm not really sure what statements might up end being wanted.

All this /could/ be cleaned up further, we don't need most of the tables created in the db for example. File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/0520995c_b9a5dc4c PS1, Line 871: /* msc_vlr tests will not pass any sms_queue, hence need to check smq != NULL */

Rather better fix the tests to pass a valid smq pointer. The db code contains similar "hacks" to have the tests pass. I think the smq pointer is not relevant to what the test is checking in this case.

Anyway, all moot if I do what you suggest below... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 19:49:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment