Attention is currently required from: pespin.

View Change

2 comments:

• File src/libmsc/db.c:

  • Patch Set #1, Line 314: [DB_STMT_SMS_DEL_SENT_BY_ID] =

    what's the point in having the 2 of them?

    WIP I guess. I'm not really sure what statements might up end being wanted.

    All this /could/ be cleaned up further, we don't need most of the tables created in the db for example.

• File src/libmsc/gsm_04_11.c:

  • Patch Set #1, Line 871: /* msc_vlr tests will not pass any sms_queue, hence need to check smq != NULL */

    Rather better fix the tests to pass a valid smq pointer.

    The db code contains similar "hacks" to have the tests pass.
    I think the smq pointer is not relevant to what the test is checking in this case.

    Anyway, all moot if I do what you suggest below...

To view, visit change 28340. To unsubscribe, or for help writing mail filters, visit settings.