April 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: firmware/apps/rssi: remove redundant block in handle_pm()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27872 ) Change subject: firmware/apps/rssi: remove redundant block in handle_pm() ...................................................................... firmware/apps/rssi: remove redundant block in handle_pm() Below in the common path for both true and false branches we do have a conditional block setting ARFCN_UPLINK if uplink is true. Change-Id: If3adc5d1f11d3f43cb4c17bdb355b160ab61dc56 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/72/27872/1 diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 94ecc3b..29c5430 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -916,8 +916,6 @@ a = arfcn; if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) a |= ARFCN_PCS; - if (uplink) - a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; } else { /* mode == MODE_SPECTRUM */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If3adc5d1f11d3f43cb4c17bdb355b160ab61dc56 Gerrit-Change-Number: 27872 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/apps/hello_world: remove unused test[] buffer

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27874 ) Change subject: firmware/apps/hello_world: remove unused test[] buffer ...................................................................... firmware/apps/hello_world: remove unused test[] buffer Change-Id: I20d41111d6f611202dcefada8091ccda0cc51dad --- M src/target/firmware/apps/hello_world/main.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/74/27874/1 diff --git a/src/target/firmware/apps/hello_world/main.c b/src/target/firmware/apps/hello_world/main.c index aeb5739..ecacc18 100644 --- a/src/target/firmware/apps/hello_world/main.c +++ b/src/target/firmware/apps/hello_world/main.c @@ -165,8 +165,6 @@ void key_handler(enum key_codes code, enum key_states state) { - char test[16]; - if (state != PRESSED) return; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20d41111d6f611202dcefada8091ccda0cc51dad Gerrit-Change-Number: 27874 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/apps/layer1: remove unused 'atrLength' in main()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27873 ) Change subject: firmware/apps/layer1: remove unused 'atrLength' in main() ...................................................................... firmware/apps/layer1: remove unused 'atrLength' in main() Change-Id: I4bb1dae28c07218e8b801bc162b82d03fd083bad --- M src/target/firmware/apps/layer1/main.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/73/27873/1 diff --git a/src/target/firmware/apps/layer1/main.c b/src/target/firmware/apps/layer1/main.c index 701d95f..8135468 100644 --- a/src/target/firmware/apps/layer1/main.c +++ b/src/target/firmware/apps/layer1/main.c @@ -57,7 +57,6 @@ int main(void) { uint8_t atr[20]; - uint8_t atrLength = 0; board_init(1); @@ -101,7 +100,7 @@ puts("Power up simcard:\n"); memset(atr,0,sizeof(atr)); - atrLength = calypso_sim_powerup(atr); + calypso_sim_powerup(atr); read_factory_rf_calibration(); layer1_init(); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4bb1dae28c07218e8b801bc162b82d03fd083bad Gerrit-Change-Number: 27873 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/layer1: fix 'MFNONE' not handled in switch [-Wswitch]

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27869 ) Change subject: firmware/layer1: fix 'MFNONE' not handled in switch [-Wswitch] ...................................................................... firmware/layer1: fix 'MFNONE' not handled in switch [-Wswitch] Change-Id: I4c38599b29de73e26e9b603564f63b88e65e16b9 --- M src/target/firmware/layer1/l23_api.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/69/27869/1 diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index afcf9f5..2bd57d2 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -133,6 +133,9 @@ case MF26ODD: TASK_SET(MF_TASK_NEIGH_PM26O); break; + default: + /* no neighbor measurement */ + break; } break; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27869 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4c38599b29de73e26e9b603564f63b88e65e16b9 Gerrit-Change-Number: 27869 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/layer1: fix unused variable 'l1h' [-Wunused-variable]

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27870 ) Change subject: firmware/layer1: fix unused variable 'l1h' [-Wunused-variable] ...................................................................... firmware/layer1: fix unused variable 'l1h' [-Wunused-variable] Change-Id: If8c3da3908c1dab7a93e69daee13426f9bdbccad --- M src/target/firmware/layer1/l23_api.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/70/27870/1 diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index 2bd57d2..11d4195 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -344,10 +344,8 @@ } /* receive a L1CTL_DM_REL_REQ from L23 */ -static void l1ctl_rx_dm_rel_req(struct msgb *msg) +static void l1ctl_rx_dm_rel_req(void) { - struct l1ctl_hdr *l1h = (struct l1ctl_hdr *) msg->data; - printd("L1CTL_DM_REL_REQ\n"); l1a_mftask_set(0); l1s.dedicated.type = GSM_DCHAN_NONE; @@ -672,7 +670,7 @@ l1ctl_rx_dm_est_req(msg); break; case L1CTL_DM_REL_REQ: - l1ctl_rx_dm_rel_req(msg); + l1ctl_rx_dm_rel_req(); break; case L1CTL_PARAM_REQ: l1ctl_rx_param_req(msg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If8c3da3908c1dab7a93e69daee13426f9bdbccad Gerrit-Change-Number: 27870 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27871 ) Change subject: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() ...................................................................... firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() In this function we have the following condition: if (pm_mode == PM_IDLE && (mode == MODE_MAIN || mode == MODE_SPECTRUM)) so the 'mode' can be either MODE_MAIN or MODE_SPECTRUM. Still, GCC throws false-positive warnings that 'a' and 'e' may be used uninitialized in handle_pm(). Let's eliminate these warnings by using 'if-else' statement. Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/71/27871/1 diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 9a3f87c..94ecc3b 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -920,8 +920,7 @@ a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; - } - if (mode == MODE_SPECTRUM) { + } else { /* mode == MODE_SPECTRUM */ if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) { a = PCS_MIN | ARFCN_PCS; e = PCS_MAX | ARFCN_PCS; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 Gerrit-Change-Number: 27871 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/abb: fix missing 'break' in twl3025_unit_enable()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27867 ) Change subject: firmware/abb: fix missing 'break' in twl3025_unit_enable() ...................................................................... firmware/abb: fix missing 'break' in twl3025_unit_enable() Change-Id: I8224f8c2dba6891ef3fffcb6eed6572d35132d2e --- M src/target/firmware/abb/twl3025.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/67/27867/1 diff --git a/src/target/firmware/abb/twl3025.c b/src/target/firmware/abb/twl3025.c index 1c099dc..4f495bc 100644 --- a/src/target/firmware/abb/twl3025.c +++ b/src/target/firmware/abb/twl3025.c @@ -373,6 +373,7 @@ togbr1 = (1 << 5); else togbr1 = (1 << 4); + break; case TWL3025_UNIT_VDL: if (on) togbr1 = (1 << 3); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8224f8c2dba6891ef3fffcb6eed6572d35132d2e Gerrit-Change-Number: 27867 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/layer1: fix -Wtype-limits in chan_nr2mf_task_mask()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27868 ) Change subject: firmware/layer1: fix -Wtype-limits in chan_nr2mf_task_mask() ...................................................................... firmware/layer1: fix -Wtype-limits in chan_nr2mf_task_mask() arm-none-eabi-gcc versions 11.2.0 shows the following warning: layer1/l23_api.c: In function 'chan_nr2mf_task_mask': layer1/l23_api.c:123:25: warning: comparison is always true due to limited range of data type [-Wtype-limits] 123 | if (second_task >= 0) /* optional */ Let's get rid of {master,second}_task by using a macro. Change-Id: I00bd3e11a14f10b78fd91f0e6915ca4fc0817d6a --- M src/target/firmware/layer1/l23_api.c 1 file changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/68/27868/1 diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index 735d92a..afcf9f5 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -73,72 +73,72 @@ uint8_t cbits = chan_nr >> 3; uint8_t tn = chan_nr & 0x7; uint8_t lch_idx; - enum mframe_task master_task = MF_TASK_BCCH_NORM; - enum mframe_task second_task = -1; /* optional */ enum mf_type multiframe = 0; uint32_t task_mask = 0x00; +#define TASK_SET(task) \ + task_mask |= (1 << (task)) + if (cbits == 0x01) { lch_idx = 0; - master_task = (tn & 1) ? MF_TASK_TCH_F_ODD : MF_TASK_TCH_F_EVEN; + TASK_SET((tn & 1) ? MF_TASK_TCH_F_ODD : MF_TASK_TCH_F_EVEN); multiframe = (tn & 1) ? MF26ODD : MF26EVEN; } else if ((cbits & 0x1e) == 0x02) { lch_idx = cbits & 0x1; - master_task = MF_TASK_TCH_H_0 + lch_idx; + TASK_SET(MF_TASK_TCH_H_0 + lch_idx); multiframe = (lch_idx & 1) ? MF26ODD : MF26EVEN; } else if ((cbits & 0x1c) == 0x04) { lch_idx = cbits & 0x3; - master_task = MF_TASK_SDCCH4_0 + lch_idx; + TASK_SET(MF_TASK_SDCCH4_0 + lch_idx); multiframe = MF51; } else if ((cbits & 0x18) == 0x08) { lch_idx = cbits & 0x7; - master_task = MF_TASK_SDCCH8_0 + lch_idx; + TASK_SET(MF_TASK_SDCCH8_0 + lch_idx); multiframe = MF51; } else if ((cbits & 0x1f) == 0x18) { /* Osmocom specific extension for PDTCH and PTCCH */ - master_task = MF_TASK_GPRS_PDTCH; - second_task = MF_TASK_GPRS_PTCCH; + TASK_SET(MF_TASK_GPRS_PDTCH); + TASK_SET(MF_TASK_GPRS_PTCCH); /* FIXME: PDCH has different multiframe structure */ multiframe = MFNONE; } else if ((cbits & 0x1f) == 0x19) { /* Osmocom specific extension for CBCH on SDCCH/4 */ - master_task = MF_TASK_SDCCH4_CBCH; + TASK_SET(MF_TASK_SDCCH4_CBCH); multiframe = MF51; } else if ((cbits & 0x1f) == 0x1a) { /* Osmocom specific extension for CBCH on SDCCH/8 */ - master_task = MF_TASK_SDCCH8_CBCH; + TASK_SET(MF_TASK_SDCCH8_CBCH); multiframe = MF51; #if 0 } else if (cbits == 0x10) { /* FIXME: when to do extended BCCH? */ - master_task = MF_TASK_BCCH_NORM; + TASK_SET(MF_TASK_BCCH_NORM); } else if (cbits == 0x11 || cbits == 0x12) { /* FIXME: how to decide CCCH norm/extd? */ - master_task = MF_TASK_BCCH_CCCH; + TASK_SET(MF_TASK_BCCH_CCCH); #endif + } else { + TASK_SET(MF_TASK_BCCH_NORM); } - /* Primary and secondary tasks */ - task_mask |= (1 << master_task); - if (second_task >= 0) /* optional */ - task_mask |= (1 << second_task); - switch (neigh_mode) { case NEIGH_MODE_PM: switch (multiframe) { case MF51: - task_mask |= (1 << MF_TASK_NEIGH_PM51); + TASK_SET(MF_TASK_NEIGH_PM51); break; case MF26EVEN: - task_mask |= (1 << MF_TASK_NEIGH_PM26E); + TASK_SET(MF_TASK_NEIGH_PM26E); break; case MF26ODD: - task_mask |= (1 << MF_TASK_NEIGH_PM26O); + TASK_SET(MF_TASK_NEIGH_PM26O); break; } break; } +#undef TASK_SET + return task_mask; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27868 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I00bd3e11a14f10b78fd91f0e6915ca4fc0817d6a Gerrit-Change-Number: 27868 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: Move struct gsm_bts_paging_state to paging.h

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27866 ) Change subject: Move struct gsm_bts_paging_state to paging.h ...................................................................... Move struct gsm_bts_paging_state to paging.h Change-Id: I8c058d308fc816828b5e6a86e7c5a1f629a2d7c4 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M include/osmocom/bsc/paging.h M src/ipaccess/Makefile.am M src/utils/Makefile.am M tests/abis/Makefile.am M tests/acc/Makefile.am M tests/codec_pref/Makefile.am M tests/gsm0408/Makefile.am M tests/nanobts_omlattr/Makefile.am M tests/subscr/Makefile.am 11 files changed, 38 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/27866/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index cd0f8cb..95d9b05 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -17,6 +17,7 @@ #include "osmocom/bsc/bts_trx.h" #include "osmocom/bsc/bts_sm.h" #include "osmocom/bsc/abis_om2000.h" +#include "osmocom/bsc/paging.h" enum bts_counter_id { BTS_CTR_CHREQ_TOTAL, diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 4a58c2b..b478ba0 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -962,26 +962,6 @@ #define GSM_LCHAN_SI(lchan, i) (void *)((lchan)->si.buf[i][0]) -/* - * This keeps track of the paging status of one BTS. It - * includes a number of pending requests, a back pointer - * to the gsm_bts, a timer and some more state. - */ -struct gsm_bts_paging_state { - /* pending requests */ - struct llist_head pending_requests; - struct gsm_bts *bts; - - struct osmo_timer_list work_timer; - struct osmo_timer_list credit_timer; - - /* free chans needed */ - int free_chans_need; - - /* load */ - uint16_t available_slots; -}; - struct gsm_envabtse { struct gsm_abis_mo mo; }; diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h index dd3d316..c4381fa 100644 --- a/include/osmocom/bsc/paging.h +++ b/include/osmocom/bsc/paging.h @@ -89,6 +89,26 @@ enum bsc_paging_reason reason; }; +/* + * This keeps track of the paging status of one BTS. It + * includes a number of pending requests, a back pointer + * to the gsm_bts, a timer and some more state. + */ +struct gsm_bts_paging_state { + /* pending requests */ + struct llist_head pending_requests; + struct gsm_bts *bts; + + struct osmo_timer_list work_timer; + struct osmo_timer_list credit_timer; + + /* free chans needed */ + int free_chans_need; + + /* load */ + uint16_t available_slots; +}; + void paging_init(struct gsm_bts *bts); /* schedule paging request */ diff --git a/src/ipaccess/Makefile.am b/src/ipaccess/Makefile.am index 9a9fff6..9bd648d 100644 --- a/src/ipaccess/Makefile.am +++ b/src/ipaccess/Makefile.am @@ -9,6 +9,8 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(NULL) diff --git a/src/utils/Makefile.am b/src/utils/Makefile.am index 1d6c48e..18debe7 100644 --- a/src/utils/Makefile.am +++ b/src/utils/Makefile.am @@ -9,6 +9,8 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(SQLITE3_CFLAGS) \ $(NULL) diff --git a/tests/abis/Makefile.am b/tests/abis/Makefile.am index 2fa6b30..d17eff8 100644 --- a/tests/abis/Makefile.am +++ b/tests/abis/Makefile.am @@ -7,8 +7,10 @@ -Wall \ -ggdb3 \ $(LIBOSMOCORE_CFLAGS) \ - $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ + $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(NULL) diff --git a/tests/acc/Makefile.am b/tests/acc/Makefile.am index 2c41666..a169c5c 100644 --- a/tests/acc/Makefile.am +++ b/tests/acc/Makefile.am @@ -7,8 +7,10 @@ -Wall \ -ggdb3 \ $(LIBOSMOCORE_CFLAGS) \ - $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ + $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(NULL) diff --git a/tests/codec_pref/Makefile.am b/tests/codec_pref/Makefile.am index b16f282..ec25da5 100644 --- a/tests/codec_pref/Makefile.am +++ b/tests/codec_pref/Makefile.am @@ -8,6 +8,7 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(LIBOSMOSIGTRAN_CFLAGS) \ $(NULL) diff --git a/tests/gsm0408/Makefile.am b/tests/gsm0408/Makefile.am index e078610..4802025 100644 --- a/tests/gsm0408/Makefile.am +++ b/tests/gsm0408/Makefile.am @@ -9,6 +9,8 @@ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(NULL) check_PROGRAMS = \ diff --git a/tests/nanobts_omlattr/Makefile.am b/tests/nanobts_omlattr/Makefile.am index 9b16a3c..8c64356 100644 --- a/tests/nanobts_omlattr/Makefile.am +++ b/tests/nanobts_omlattr/Makefile.am @@ -8,6 +8,8 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(NULL) check_PROGRAMS = \ diff --git a/tests/subscr/Makefile.am b/tests/subscr/Makefile.am index 329b6c0..e18b96a 100644 --- a/tests/subscr/Makefile.am +++ b/tests/subscr/Makefile.am @@ -9,6 +9,8 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBSMPP34_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c058d308fc816828b5e6a86e7c5a1f629a2d7c4 Gerrit-Change-Number: 27866 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bts: Simplify bts->paging initialization

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27858 to look at the new patch set (#6). Change subject: bts: Simplify bts->paging initialization ...................................................................... bts: Simplify bts->paging initialization Related: SYS#5922 Change-Id: Id103d5f3d437065abcd32788caef339343b1e96 --- M include/osmocom/bsc/paging.h M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/paging.c 4 files changed, 8 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/27858/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id103d5f3d437065abcd32788caef339343b1e96a Gerrit-Change-Number: 27858 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022