April 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: firmware/abb: fix missing 'break' in twl3025_unit_enable()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27867 ) Change subject: firmware/abb: fix missing 'break' in twl3025_unit_enable() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8224f8c2dba6891ef3fffcb6eed6572d35132d2e Gerrit-Change-Number: 27867 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 14:03:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Use llist_first_entry() macro

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27883 ) Change subject: paging: Use llist_first_entry() macro ...................................................................... paging: Use llist_first_entry() macro Change-Id: I83e88de6f48cc8aad18ed80ab981b0b438e72b1a --- M src/osmo-bsc/paging.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/83/27883/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index ed435f4..7dfbb24 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -204,8 +204,8 @@ return; } - request = llist_entry(paging_bts->pending_requests.next, - struct gsm_paging_request, entry); + request = llist_first_entry(&paging_bts->pending_requests, + struct gsm_paging_request, entry); /* we need to determine the number of free channels */ if (paging_bts->free_chans_need != -1) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27883 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I83e88de6f48cc8aad18ed80ab981b0b438e72b1a Gerrit-Change-Number: 27883 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in pysim[master]: transport/pcsc: throw ReaderError with a message

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27882 ) Change subject: transport/pcsc: throw ReaderError with a message ...................................................................... transport/pcsc: throw ReaderError with a message Before this patch: $ ./pySim-shell.py -p 0 Card reader initialization failed with an exception of type: <class 'pySim.exceptions.ReaderError'> after: $ ./pySim-shell.py -p 0 Card reader initialization failed with exception: No reader found with number 0 Change-Id: Id08c4990857f7083a8d1cefc90ff85fc20ab6fef --- M pySim/transport/pcsc.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/82/27882/1 diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index ca1751a..0f87b18 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -34,7 +34,7 @@ super().__init__(**kwargs) r = readers() if reader_number >= len(r): - raise ReaderError + raise ReaderError('No reader found with number %d' % reader_number) self._reader = r[reader_number] self._con = self._reader.createConnection() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27882 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id08c4990857f7083a8d1cefc90ff85fc20ab6fef Gerrit-Change-Number: 27882 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in pysim[master]: SimCard.reset(): fix SyntaxWarning: 'is' with a literal

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27881 ) Change subject: SimCard.reset(): fix SyntaxWarning: 'is' with a literal ...................................................................... SimCard.reset(): fix SyntaxWarning: 'is' with a literal Change-Id: I5860179acd1cb330e91dbe5b57cd60cd520f2d9d --- M pySim/cards.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/81/27881/1 diff --git a/pySim/cards.py b/pySim/cards.py index 1ed1634..b186044 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -63,7 +63,7 @@ def reset(self): rc = self._scc.reset_card() - if rc is 1: + if rc == 1: return self._scc.get_atr() else: return None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27881 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5860179acd1cb330e91dbe5b57cd60cd520f2d9d Gerrit-Change-Number: 27881 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Avoid setting up credit_timer every time

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27880 ) Change subject: paging: Avoid setting up credit_timer every time ...................................................................... paging: Avoid setting up credit_timer every time Change-Id: Id4da0ab094ffe939cad9ff5708721e25b5a1a984 --- M src/osmo-bsc/paging.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/80/27880/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 73c1175..ed435f4 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -200,8 +200,6 @@ * to zero and we do not get any messages. */ if (paging_bts->available_slots == 0) { - osmo_timer_setup(&paging_bts->credit_timer, paging_give_credit, - paging_bts); osmo_timer_schedule(&paging_bts->credit_timer, 5, 0); return; } @@ -248,6 +246,7 @@ bts->paging.available_slots = 20; INIT_LLIST_HEAD(&bts->paging.pending_requests); osmo_timer_setup(&bts->paging.work_timer, paging_worker, &bts->paging); + osmo_timer_setup(&bts->paging.credit_timer, paging_give_credit, &bts->paging); } /*! do we have any pending paging requests for given subscriber? */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id4da0ab094ffe939cad9ff5708721e25b5a1a984 Gerrit-Change-Number: 27880 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: rsl_rx_ccch_load: add explicit cast -1 to unsigned

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 ) Change subject: rsl_rx_ccch_load: add explicit cast -1 to unsigned ...................................................................... rsl_rx_ccch_load: add explicit cast -1 to unsigned This is useful for the reader to understand those variables are actually ungisned, so they should never be compared later against isgned values. It helps understand -1 here means the maximum unsigned value. Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/79/27879/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 03e409d..0486afc 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2328,9 +2328,9 @@ struct ccch_signal_data sd; sd.bts = sign_link->trx->bts; - sd.rach_slot_count = -1; - sd.rach_busy_count = -1; - sd.rach_access_count = -1; + sd.rach_slot_count = (uint16_t)-1; + sd.rach_busy_count = (uint16_t)-1; + sd.rach_access_count = (uint16_t)-1; switch (rslh->data[0]) { case RSL_IE_PAGING_LOAD: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: tests/bsc/Makefile.am: remove duplicate CFLAGS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27877 ) Change subject: tests/bsc/Makefile.am: remove duplicate CFLAGS ...................................................................... tests/bsc/Makefile.am: remove duplicate CFLAGS Change-Id: I7af974a9920558af03495b6ca297b158caebc007 --- M tests/bsc/Makefile.am 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/27877/1 diff --git a/tests/bsc/Makefile.am b/tests/bsc/Makefile.am index 8fcda3a..5056c18 100644 --- a/tests/bsc/Makefile.am +++ b/tests/bsc/Makefile.am @@ -13,7 +13,6 @@ $(LIBOSMOLEGACYMGCP_CFLAGS) \ $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBOSMOMGCPCLIENT_CFLAGS) \ - $(LIBOSMOSIGTRAN_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7af974a9920558af03495b6ca297b158caebc007 Gerrit-Change-Number: 27877 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Use define available in libosmogsm

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27878 ) Change subject: paging: Use define available in libosmogsm ...................................................................... paging: Use define available in libosmogsm Change-Id: I6425a9cb1100391404d79ead66dfb1337bbcbcab --- M src/osmo-bsc/paging.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/27878/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 512f39c..73c1175 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -288,8 +288,7 @@ log_set_context(LOG_CTX_BSC_SUBSCR, NULL); } -#define GSM_FRAME_DURATION_us 4615 -#define GSM51_MFRAME_DURATION_us (51 * GSM_FRAME_DURATION_us) /* 235365 us */ +#define GSM51_MFRAME_DURATION_us (51 * GSM_TDMA_FN_DURATION_uS) /* 235365 us */ static unsigned int calculate_timer_3113(struct gsm_bts *bts) { unsigned int to_us, to; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6425a9cb1100391404d79ead66dfb1337bbcbcab Gerrit-Change-Number: 27878 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/tiffs/readfile: fix -Wbuiltin-declaration-mismatch

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27875 ) Change subject: firmware/tiffs/readfile: fix -Wbuiltin-declaration-mismatch ...................................................................... firmware/tiffs/readfile: fix -Wbuiltin-declaration-mismatch Change-Id: Id8ec64054f24fe43cfec66d2d331e18b780b3951 --- M src/target/firmware/tiffs/readfile.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/75/27875/1 diff --git a/src/target/firmware/tiffs/readfile.c b/src/target/firmware/tiffs/readfile.c index c93b106..3c330d0 100644 --- a/src/target/firmware/tiffs/readfile.c +++ b/src/target/firmware/tiffs/readfile.c @@ -26,7 +26,7 @@ #include <tiffs.h> #include "globals.h" -extern char *index(); +extern char *index(const char *, int); #define MAX_FN_COMPONENT 20 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8ec64054f24fe43cfec66d2d331e18b780b3951 Gerrit-Change-Number: 27875 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/battery: fix -Wunused-variable in battery_compal_e88_timer_cb()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27876 ) Change subject: firmware/battery: fix -Wunused-variable in battery_compal_e88_timer_cb() ...................................................................... firmware/battery: fix -Wunused-variable in battery_compal_e88_timer_cb() Change-Id: I3e9bbc21aec57dea84034d233a2ba1902602bdb2 --- M src/target/firmware/battery/compal_e88.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/76/27876/1 diff --git a/src/target/firmware/battery/compal_e88.c b/src/target/firmware/battery/compal_e88.c index 42f77f2..788d8ab 100644 --- a/src/target/firmware/battery/compal_e88.c +++ b/src/target/firmware/battery/compal_e88.c @@ -352,7 +352,6 @@ static void battery_compal_e88_timer_cb(void *p){ struct osmo_timer_list *tmr = (struct osmo_timer_list*)p; - int i; if(bat_compal_e88_adc_read()){ /* read back ADCs after a brief delay */ osmo_timer_schedule(tmr,ADC_TIMER_DELAY); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3e9bbc21aec57dea84034d233a2ba1902602bdb2 Gerrit-Change-Number: 27876 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022