April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: bts_model_osmobts_init: order feats alphabetically

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27886 ) Change subject: bts_model_osmobts_init: order feats alphabetically ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27886 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6f041648990db4ae479538cf3970c826bc6703ed Gerrit-Change-Number: 27886 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 15:44:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: model_init: set BTS_FEAT_PAGINATION_COORDINATION

by laforge

Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27888 ) Change subject: model_init: set BTS_FEAT_PAGINATION_COORDINATION ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib06829501f4221a7f7b0344ec7991ceba74e7641 Gerrit-Change-Number: 27888 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 15:44:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: system_information: Set BSS_PAGING_COORDINATION in SI13 for osmo-bts

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18936 ) Change subject: system_information: Set BSS_PAGING_COORDINATION in SI13 for osmo-bts ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: the point of having the BTS report its features during OML connection is to avoid the BSC having any kind of compiled-in notion about these topics :( -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0e80ca5afc06737273b6699bde6e325e454b57f6 Gerrit-Change-Number: 18936 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 21 Apr 2022 15:43:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: Move struct gsm_bts_paging_state to paging.h

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27866 ) Change subject: Move struct gsm_bts_paging_state to paging.h ...................................................................... Patch Set 2: (1 comment) File src/ipaccess/Makefile.am: https://gerrit.osmocom.org/c/osmo-bsc/+/27866/comment/2722ad4b_52f6cd8e PS2, Line 12: $(LIBOSMONETIF_CFLAGS) \ > What if instead of <paging. […] It's not a pointer, bts needs to know the whole struct. I think it's fine having all CFLAGS here. I think they should be actually added everywhere, have some sort of libbsc.la CFLAGS and LIBS variables we can add everywhere. But that's unrelated and can be done when we have more free time if we want. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c058d308fc816828b5e6a86e7c5a1f629a2d7c4 Gerrit-Change-Number: 27866 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 15:43:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Use define available in libosmogsm

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27878 ) Change subject: paging: Use define available in libosmogsm ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6425a9cb1100391404d79ead66dfb1337bbcbcab Gerrit-Change-Number: 27878 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 15:41:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: Move struct gsm_bts_paging_state to paging.h

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27866 ) Change subject: Move struct gsm_bts_paging_state to paging.h ...................................................................... Patch Set 2: (1 comment) File src/ipaccess/Makefile.am: https://gerrit.osmocom.org/c/osmo-bsc/+/27866/comment/af0a101b_baa41fe5 PS2, Line 12: $(LIBOSMONETIF_CFLAGS) \ What if instead of <paging.h> we simply add a forward declaration of 'struct gsm_bts_paging_state' to bts.h? Would this eliminate the need for additional CFLAGS? If not, please explain in the commit message why are these CFLAGS needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c058d308fc816828b5e6a86e7c5a1f629a2d7c4 Gerrit-Change-Number: 27866 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 15:41:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: model_init: order features alphabetically

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27887 ) Change subject: model_init: order features alphabetically ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I67887d89912d963fbbe90590c8467cbbd2566e09 Gerrit-Change-Number: 27887 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 15:41:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: model_init: order features alphabetically

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/27887 to look at the new patch set (#2). Change subject: model_init: order features alphabetically ...................................................................... model_init: order features alphabetically Make it easier to compare the lists of features. Related: SYS#5922, OS#5538 Change-Id: I67887d89912d963fbbe90590c8467cbbd2566e09 --- M src/osmo-bts-lc15/main.c M src/osmo-bts-oc2g/main.c M src/osmo-bts-sysmo/main.c M src/osmo-bts-trx/main.c M src/osmo-bts-virtual/main.c 5 files changed, 44 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/27887/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I67887d89912d963fbbe90590c8467cbbd2566e09 Gerrit-Change-Number: 27887 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: model_init: set BTS_FEAT_PAGINATION_COORDINATION

by osmith

Attention is currently required from: osmith, laforge, fixeria. Hello laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/27888 to look at the new patch set (#2). Change subject: model_init: set BTS_FEAT_PAGINATION_COORDINATION ...................................................................... model_init: set BTS_FEAT_PAGINATION_COORDINATION According to osmo-bsc I0e80ca5afc06737273b6699bde6e325e454b57f6, the PAGING_COORDINATION feature should be well supported in osmo-bts. Adjust the bts_model_init functions to report this to the BSC, so it properly sets this in SI13 and so we can avoid this notice in the log: Get Attributes Response: reported feature 'PAGING_COORDINATION' is not supported, while we thought it is. Related: SYS#5922, OS#5538 Change-Id: Ib06829501f4221a7f7b0344ec7991ceba74e7641 --- M src/osmo-bts-lc15/main.c M src/osmo-bts-oc2g/main.c M src/osmo-bts-sysmo/main.c M src/osmo-bts-trx/main.c M src/osmo-bts-virtual/main.c 5 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/27888/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib06829501f4221a7f7b0344ec7991ceba74e7641 Gerrit-Change-Number: 27888 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: model_init: order features alphabetically

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27887 ) Change subject: model_init: order features alphabetically ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I67887d89912d963fbbe90590c8467cbbd2566e09 Gerrit-Change-Number: 27887 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 15:36:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022