April 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: build: Disable libusb and libmnl for embedded builds

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27975 ) Change subject: build: Disable libusb and libmnl for embedded builds ...................................................................... build: Disable libusb and libmnl for embedded builds Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ie7900098ffda7cebfab81c08b25b0001e6fd98ec --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 990d0e7..bf85c07 100644 --- a/configure.ac +++ b/configure.ac @@ -381,7 +381,9 @@ AM_CONDITIONAL(ENABLE_UTILITIES, false) AM_CONDITIONAL(ENABLE_GB, false) AM_CONDITIONAL(ENABLE_GNUTLS, false) + AM_CONDITIONAL(ENABLE_LIBMNL, false) AM_CONDITIONAL(ENABLE_LIBSCTP, false) + AM_CONDITIONAL(ENABLE_LIBUSB, false) AM_CONDITIONAL(ENABLE_PCSC, false) AM_CONDITIONAL(ENABLE_PSEUDOTALLOC, true) AM_CONDITIONAL(ENABLE_SERCOM_STUB, true) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie7900098ffda7cebfab81c08b25b0001e6fd98ec Gerrit-Change-Number: 27975 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: build: Disable libusb and libmnl for embedded builds

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27975 ) Change subject: build: Disable libusb and libmnl for embedded builds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie7900098ffda7cebfab81c08b25b0001e6fd98ec Gerrit-Change-Number: 27975 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 29 Apr 2022 07:39:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: build: Disable libusb and libmnl for embedded builds

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27975 ) Change subject: build: Disable libusb and libmnl for embedded builds ...................................................................... build: Disable libusb and libmnl for embedded builds Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ie7900098ffda7cebfab81c08b25b0001e6fd98ec --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/27975/1 diff --git a/configure.ac b/configure.ac index 990d0e7..bf85c07 100644 --- a/configure.ac +++ b/configure.ac @@ -381,7 +381,9 @@ AM_CONDITIONAL(ENABLE_UTILITIES, false) AM_CONDITIONAL(ENABLE_GB, false) AM_CONDITIONAL(ENABLE_GNUTLS, false) + AM_CONDITIONAL(ENABLE_LIBMNL, false) AM_CONDITIONAL(ENABLE_LIBSCTP, false) + AM_CONDITIONAL(ENABLE_LIBUSB, false) AM_CONDITIONAL(ENABLE_PCSC, false) AM_CONDITIONAL(ENABLE_PSEUDOTALLOC, true) AM_CONDITIONAL(ENABLE_SERCOM_STUB, true) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie7900098ffda7cebfab81c08b25b0001e6fd98ec Gerrit-Change-Number: 27975 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: detect half burst filling, filter BER10k

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27559 ) Change subject: osmo-bts-trx: detect half burst filling, filter BER10k ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia46d68603292b5c5c65f5c6552494223f10ee813 Gerrit-Change-Number: 27559 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: f_TC_paging_500req: Improve logging and checks

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27958 ) Change subject: bsc: f_TC_paging_500req: Improve logging and checks ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08f93ad3170c218bf5e1847613f36e7690dc0908 Gerrit-Change-Number: 27958 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Apr 2022 15:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmocom-bb[master]: trx_toolkit/trx_sniff.py: enrich decoding error messages

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24022 ) Change subject: trx_toolkit/trx_sniff.py: enrich decoding error messages ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > ping This patchset is related to the VAMOS feature (https://osmocom.org/issues/4941), for which we exceeded the time budget and which was unfortunately put on hold by the customer. I will be happy to resume working on TRXDv2 support in trx_toolkit once the ticket is active again. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I625f5ae0ed9373cbece5f2201759ed0b51f0db68 Gerrit-Change-Number: 24022 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 15:03:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmocom-bb[master]: trx_toolkit/data_if.py: enrich encoding/decoding error messages

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24021 ) Change subject: trx_toolkit/data_if.py: enrich encoding/decoding error messages ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > ping This patchset is related to the VAMOS feature (https://osmocom.org/issues/4941), for which we exceeded the time budget and which was unfortunately put on hold by the customer. I will be happy to resume working on TRXDv2 support in trx_toolkit once the ticket is active again. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iec80890e52f7aa24c145356b5f2e1f66a47fbd4c Gerrit-Change-Number: 24021 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 28 Apr 2022 15:02:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: paging: Recalculate work timer if waiting for retrans

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27974 ) Change subject: paging: Recalculate work timer if waiting for retrans ...................................................................... paging: Recalculate work timer if waiting for retrans If the queue is only holding requests in retransmition state, when we add a new one, we have to re-calculate the work timer to a lower value instead of letting it wait for the first retransmit to be ready. Change-Id: Ibd4f8921c92f7481f0b9943041c141640ab812c8 --- M src/osmo-bsc/paging.c 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/27974/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index fcb038b..1430c22 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -432,7 +432,28 @@ t3113_timeout_s = calculate_timer_3113(req, reqs_before_same_pgroup); osmo_timer_schedule(&req->T3113, t3113_timeout_s, 0); - paging_schedule_if_needed(bts_entry); + + /* Trigger scheduler if needed: */ + if (!osmo_timer_pending(&bts_entry->work_timer)) { + paging_handle_pending_requests(bts_entry); + } else if (last_initial_req == NULL) { + /* Worker timer is armed -> there was already one req before + * last_initial_req is NULL -> There were no initial requests in + * the list, aka the timer is waiting for retransmition, + * which is a longer period. + * Let's recaculate the time to adapt it to initial_period: */ + struct timespec now, elapsed, tdiff; + osmo_clock_gettime(CLOCK_MONOTONIC, &now); + /* This is what used to be the first req (retrans state) in the queue: */ + req = llist_entry(req->entry.next, struct gsm_paging_request, entry); + timespecsub(&now, &req->last_attempt_ts, &elapsed); + if (timespeccmp(&elapsed, &initial_period, <)) { + timespecsub(&initial_period, &elapsed, &tdiff); + } else { + tdiff = (struct timespec){.tv_sec = 0, .tv_nsec = 0 }; + } + osmo_timer_schedule(&bts_entry->work_timer, tdiff.tv_sec, tdiff.tv_nsec / 1000); + } /* else: worker is already ongoing submitting initial requests, nothing do be done */ return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd4f8921c92f7481f0b9943041c141640ab812c8 Gerrit-Change-Number: 27974 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: paging: Early stop work_timer when paging queue becomes empty

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27973 ) Change subject: paging: Early stop work_timer when paging queue becomes empty ...................................................................... paging: Early stop work_timer when paging queue becomes empty There's no need to keep the timer running, since anyway upon next trigger it will simply early exit in paging_handle_pending_requests() becuase there's no more work to do. Change-Id: I096ab7231f52c741c5fded37acd5b309e1de06e3 --- M src/osmo-bsc/paging.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/27973/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index f2bcf96..fcb038b 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -84,6 +84,8 @@ llist_del(&to_be_deleted->entry); bsc_subscr_put(to_be_deleted->bsub, BSUB_USE_PAGING_REQUEST); talloc_free(to_be_deleted); + if (llist_empty(&paging_bts->pending_requests)) + osmo_timer_del(&paging_bts->work_timer); } static void page_ms(struct gsm_paging_request *request) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I096ab7231f52c741c5fded37acd5b309e1de06e3 Gerrit-Change-Number: 27973 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: cosmetic: logging.h: fix indentation

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27955 ) Change subject: cosmetic: logging.h: fix indentation ...................................................................... cosmetic: logging.h: fix indentation Change-Id: Ia7f43e061275da1a8233f90df173d1ae18691964 --- M include/osmocom/core/logging.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 21b98f6..0078425 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -294,7 +294,7 @@ /*! structure representing a logging target */ struct log_target { - struct llist_head entry; /*!< linked list */ + struct llist_head entry; /*!< linked list */ /*! Internal data for filtering */ int filter_map; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7f43e061275da1a8233f90df173d1ae18691964 Gerrit-Change-Number: 27955 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022