April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Check VTY config against features reported by BTS

by osmith

Attention is currently required from: neels, laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Patch Set 5: (1 comment) File src/osmo-bsc/bts_osmobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/2b85da96_516e7f39 PS1, Line 213: osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_ABIS_OSMO_PCU); > *freq hopping marking as resolved, now there's no list of features hardcoded for osmo-bts anymore. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Apr 2022 13:21:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS

by osmith

Attention is currently required from: neels, laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Patch Set 4: (11 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/6b4b834c_da50f11a PS4, Line 9: * Drop hardcoded features for osmo-bts and nanobts > Be careful here, nanobts may support some features it doesn't report, since there may be feature enu […] Done File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/6d0833b0_772d5790 PS4, Line 302: /* BTS reports features on start up. When false, BTS model features get > "on start up" -> "during OML bring up". Done https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/8d44a12a_40c45b06 PS4, Line 303: * copied to BTS features. */ > "features during object initialization". […] I've shortened it to "BTS reports features on start up", the details about copying features is described in doc/bts-features.txt which is referenced above. https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/8325d15d_859e99b9 PS4, Line 347: bool features_set; > I'd rather call it "features_present" or "feature_available" or "features_known", features_set may d […] Done File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/66b467b2_16b1424c PS4, Line 507: if (bts->features_set) { > Let's move bts global checks before the trx/ts specific checks in the llist_for_each_entry above. Done https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/5383cb4b_82a89a6a PS4, Line 630: memset(bts->_features_data, 0, sizeof(bts->_features_data)); > You still may want to copy them in case of nanobts. Not copying them here, because: * once features are reported, they overwrite bts->_features_data * it makes sense to overwrite them, in case the BTS software was downgraded / osmo-bts uses another backend and suddenly has less features I've added a patch that extends the reported features with the bts->model features instead: https://gerrit.osmocom.org/c/osmo-bsc/+/27972 File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/bb47f212_7b1f95ba PS4, Line 498: bts_model_nanobts.features_get_reported = true; > I'm pretty sure this can be set when defining bts_model_nanobts directly in global scope, not here. Done File src/osmo-bsc/bts_osmobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/88f6ab86_8e6b9575 PS4, Line 204: model_osmobts.features_get_reported = true; > same, can be set in bts_model_nanobts directly. Done File src/osmo-bsc/bts_trx.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/0f1c4b25_bcc336c2 PS4, Line 343: struct bitvec *ft > const Done File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/55f63da1_55396fec PS4, Line 319: struct gsm_bts *bts > const Done https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/b68f1c4f_4a3174cd PS4, Line 342: struct gsm_bts *bts > const Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Apr 2022 13:20:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: abis_nm: add bts model features to reported ones

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27972 ) Change subject: abis_nm: add bts model features to reported ones ...................................................................... abis_nm: add bts model features to reported ones As pointed out in code review, for nanobts we need to be able to combine the reported features with a list of features we assume that the bts model supports. This is because the enum of features is based on what nanobts is able to report, but was extended for osmo-bts. Related: SYS#5922, OS#5538 Change-Id: I7bdbf28c148877275048e070dce7f503ca5e6226 --- M contrib/jenkins.sh M src/osmo-bsc/abis_nm.c 2 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/27972/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 53b30bf..4380f16 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -28,7 +28,9 @@ verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]") # Check for wrong use of osmo_bts_has_feature (OS#5538) -bts_features_wrong_use="$(grep -r -n 'osmo_bts_has_feature.*->model->features' | grep -v 'jenkins.sh')" || true +bts_features_wrong_use="$(grep -r -n 'osmo_bts_has_feature.*->model->features' \ + | grep -v 'jenkins.sh' \ + | grep -v 'intentional check against bts model')" || true if [ -n "$bts_features_wrong_use" ]; then set +x echo diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 62f62b6..8c8b19d 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -613,6 +613,19 @@ LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: feature '%s' is" " supported\n", osmo_bts_features_name(i)); } + + /* Add features from the BTS model: nanobts may support more + * features than it reports, since we extend the enum of + * features for osmo-bts. */ + for (i = 0; i < _NUM_BTS_FEAT; i++) { + if (!osmo_bts_has_feature(&bts->model->features, i) || /* intentional check against bts model */ + osmo_bts_has_feature(&bts->features, i)) + continue; + + LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: feature '%s' is assumed to be" + " supported\n", osmo_bts_features_name(i)); + osmo_bts_set_feature(&bts->features, i); + } } /* Parse Attribute Response Info content for 3GPP TS 52.021 §9.4.28 Manufacturer Dependent State */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7bdbf28c148877275048e070dce7f503ca5e6226 Gerrit-Change-Number: 27972 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS

by osmith

Attention is currently required from: osmith, neels, laforge. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 to look at the new patch set (#5). Change subject: Check VTY config against features reported by BTS ...................................................................... Check VTY config against features reported by BTS * Don't copy features for osmo-bts and nanobts initially, wait until BTS reported its features * Checks for BTS features in VTY cmds: pass if features are not known (not yet reported by the BTS), fail if the feature is missing * Once BTS reports its features, check relevant VTY config parts again Related: SYS#5922, OS#5538 Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa --- A doc/bts-features.txt M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/bts_osmobts.c M src/osmo-bsc/bts_trx.c M src/osmo-bsc/bts_trx_vty.c M src/osmo-bsc/bts_vty.c M tests/Makefile.am A tests/bts_features.vty 12 files changed, 136 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/23/27923/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 ) Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... coding: fix comments for detect_afs_sid_{first,update,onset} Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Related: SYS#5853 --- M src/coding/gsm0503_amr_dtx.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/coding/gsm0503_amr_dtx.c b/src/coding/gsm0503_amr_dtx.c index 7069b96..b149330 100644 --- a/src/coding/gsm0503_amr_dtx.c +++ b/src/coding/gsm0503_amr_dtx.c @@ -163,19 +163,19 @@ return *n_errors < *n_bits_total / 8; } -/* Detect a an FR AMR SID_FIRST frame by its identifcation marker */ +/* Detect an FR AMR SID_FIRST frame by its identifcation marker */ static bool detect_afs_sid_first(int *n_errors, int *n_bits_total, const ubit_t * ubits) { return detect_afs_id_marker(n_errors, n_bits_total, ubits, 32, 53, id_marker_0, 9); } -/* Detect an FR AMR SID_FIRST frame by its identification marker */ +/* Detect an FR AMR SID_UPDATE frame by its identification marker */ static bool detect_afs_sid_update(int *n_errors, int *n_bits_total, const ubit_t * ubits) { return detect_afs_id_marker(n_errors, n_bits_total, ubits, 36, 53, id_marker_0, 9); } -/* Detect an FR AMR SID_FIRST frame by its repeating coded inband data */ +/* Detect an FR AMR ONSET frame by its repeating coded inband data */ static bool detect_afs_onset(int *n_errors, int *n_bits_total, const ubit_t * ubits) { bool rc; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 ) Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Apr 2022 13:02:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: octsim: initial commit

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341 ) Change subject: octsim: initial commit ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/c7fbc2f7_c9e9… PS1, Line 7: octsim: initial commit > there could be some more commitlog explaining what this is about. […] ping? It has been 2 months... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692 Gerrit-Change-Number: 27341 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Apr 2022 13:00:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: bts_model_*_start: move set_feature calls to _init

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27952 ) Change subject: bts_model_*_start: move set_feature calls to _init ...................................................................... bts_model_*_start: move set_feature calls to _init With previous patch Idf2d933aa8b03b1f708e56a08707fe6c620a97aa, the features get copied from the BTS model to the BTS. For rbs2000, bs11 and nokia_site, an empty feature set was copied because the features weren't set at this point. Fix this by moving the set_feature calls to _init(). Notably the set_feature calls had been moved for osmo-bts and nanobts from _start to _init already in 2013 in the patch e84dd98d ("sysmobts: Avoid a crash when trying to look-up a BTS"). Fixes: 2d818b9f ("Always use reported features if available") Related: SYS#5922, OS#5538 Change-Id: I43389ae48d5e0f01381602751f6bad902011b158 --- M src/osmo-bsc/bts_ericsson_rbs2000.c M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_siemens_bs11.c 3 files changed, 22 insertions(+), 23 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ericsson_rbs2000.c b/src/osmo-bsc/bts_ericsson_rbs2000.c index b3d79b4..36b3783 100644 --- a/src/osmo-bsc/bts_ericsson_rbs2000.c +++ b/src/osmo-bsc/bts_ericsson_rbs2000.c @@ -213,6 +213,14 @@ static int bts_model_rbs2k_start(struct gsm_network *net) { + osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); + osmo_signal_register_handler(SS_L_GLOBAL, gbl_sig_cb, NULL); + + return 0; +} + +int bts_model_rbs2k_init(void) +{ model_rbs2k.features.data = &model_rbs2k._features_data[0]; model_rbs2k.features.data_len = sizeof(model_rbs2k._features_data); @@ -222,13 +230,5 @@ osmo_bts_set_feature(&model_rbs2k.features, BTS_FEAT_HSCSD); osmo_bts_set_feature(&model_rbs2k.features, BTS_FEAT_MULTI_TSC); - osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); - osmo_signal_register_handler(SS_L_GLOBAL, gbl_sig_cb, NULL); - - return 0; -} - -int bts_model_rbs2k_init(void) -{ return gsm_bts_model_register(&model_rbs2k); } diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 75ffa95..e20519a 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1759,14 +1759,6 @@ static int bts_model_nokia_site_start(struct gsm_network *net) { - model_nokia_site.features.data = &model_nokia_site._features_data[0]; - model_nokia_site.features.data_len = - sizeof(model_nokia_site._features_data); - - osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_HOPPING); - osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_HSCSD); - osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_MULTI_TSC); - osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); osmo_signal_register_handler(SS_L_GLOBAL, gbl_sig_cb, NULL); osmo_signal_register_handler(SS_NM, nm_sig_cb, NULL); @@ -1778,5 +1770,12 @@ int bts_model_nokia_site_init(void) { + model_nokia_site.features.data = &model_nokia_site._features_data[0]; + model_nokia_site.features.data_len = sizeof(model_nokia_site._features_data); + + osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_HOPPING); + osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_HSCSD); + osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_MULTI_TSC); + return gsm_bts_model_register(&model_nokia_site); } diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c index 818d84a..ed2c4c3 100644 --- a/src/osmo-bsc/bts_siemens_bs11.c +++ b/src/osmo-bsc/bts_siemens_bs11.c @@ -604,13 +604,6 @@ static int bts_model_bs11_start(struct gsm_network *net) { - model_bs11.features.data = &model_bs11._features_data[0]; - model_bs11.features.data_len = sizeof(model_bs11._features_data); - - osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_HOPPING); - osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_HSCSD); - osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_MULTI_TSC); - osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); osmo_signal_register_handler(SS_L_GLOBAL, gbl_sig_cb, NULL); @@ -619,5 +612,12 @@ int bts_model_bs11_init(void) { + model_bs11.features.data = &model_bs11._features_data[0]; + model_bs11.features.data_len = sizeof(model_bs11._features_data); + + osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_HOPPING); + osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_HSCSD); + osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_MULTI_TSC); + return gsm_bts_model_register(&model_bs11); } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I43389ae48d5e0f01381602751f6bad902011b158 Gerrit-Change-Number: 27952 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: abis_nm_ipaccess_rsl_connect: initialize ia

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27951 ) Change subject: abis_nm_ipaccess_rsl_connect: initialize ia ...................................................................... abis_nm_ipaccess_rsl_connect: initialize ia Fix access to uninitialized value from inet_ntoa(ia) inside the log message, found with valgrind. Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc --- M src/osmo-bsc/abis_nm.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index a4976c0..62f62b6 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -3051,6 +3051,8 @@ if (ip != 0) { ia.s_addr = htonl(ip); msgb_tv_fixed_put(attr, NM_ATT_IPACC_DST_IP, 4, (void*)&ia.s_addr); + } else { + ia = (struct in_addr){}; } LOG_TRX(trx, DNM, LOGL_INFO, "IPA RSL CONNECT IP=%s PORT=%u STREAM=0x%02x\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc Gerrit-Change-Number: 27951 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: paging: Estimate available_slots based on BTS config when no CCCH Loa...

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27935 ) Change subject: paging: Estimate available_slots based on BTS config when no CCCH Load Ind received ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27935/comment/6ecc51e3_5aa06c76 PS3, Line 2344: sd.bts->ccch_load_ind_period > In paging.c you multiply it by 2, but here you don't. Is it intentional? […] Because in this path we know it's an ipaccess BTS which will keep sending CCCH Load Indication all the time despite being under Load Threshold (value UINT16_MAX), so we know we'll receive another CCCH Load Ind after sd.bts->ccch_load_ind_period seconds. Hence, there's no sense in calculating double the time. sd.bts->ccch_load_ind_period * 2 is used to provide enough time for CCCH Load Ind to arrive if they are delayed. If that bts->ccch_load_ind_period * 2 timeframe is reached, in general we consider the BTS is not sending load indications because it's under threshold. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2df68e10eb549d62765ad3b25429f7fe2d5bb0b9 Gerrit-Change-Number: 27935 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Apr 2022 11:51:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022