April 2022 - gerrit-log - lists.osmocom.org

Change in ...osmo_dia2gsup[master]: docs: add a simple example to use configuration file

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 ) Change subject: docs: add a simple example to use configuration file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I013f03779508bc3ee5bb378c357a5c94b40b74a0 Gerrit-Change-Number: 27647 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:19:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in libosmocore[master]: jenkins: Validate gsm 08.58 IEs are added to tlv_definition

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27646 ) Change subject: jenkins: Validate gsm 08.58 IEs are added to tlv_definition ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id8a679ca43eb0fcc4882780e9a95ec21c7f51972 Gerrit-Change-Number: 27646 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:19:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in libosmocore[master]: rsl: Fix tlv_parse of IPAC_DLCX_IND message

by laforge

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27644 ) Change subject: rsl: Fix tlv_parse of IPAC_DLCX_IND message ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: In general I agree we should avoid introducing SYS# ticket numbers into the codebase, as it is something that other people don't have access to. On the other hand, I don't think we should waste time by copying parts of a bug report to osmocom.org, creating a non-customer-incumbered pcap file, attaching it there and re-writing this patch now. But in the future, let's avoid this please. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib637197ef3508ec94aec05d08d4e6aa15ddea055 Gerrit-Change-Number: 27644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-gbproxy[master]: docs: usermanual: add new chapter gb-ns2-maintenance

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27306 ) Change subject: docs: usermanual: add new chapter gb-ns2-maintenance ...................................................................... docs: usermanual: add new chapter gb-ns2-maintenance Depends-On: I5571001a127c933397a4bc26e85410288d50fc2f (osmo-gsm-manuals.git) Change-Id: I951cc10d86de4f16d2226b34eda55202373c2524 --- M doc/manuals/osmogbproxy-usermanual.adoc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/doc/manuals/osmogbproxy-usermanual.adoc b/doc/manuals/osmogbproxy-usermanual.adoc index c371cf7..2a1b873 100644 --- a/doc/manuals/osmogbproxy-usermanual.adoc +++ b/doc/manuals/osmogbproxy-usermanual.adoc @@ -29,6 +29,7 @@ include::./common/chapters/gb-ns2-configuration-timer.adoc[] +include::./common/chapters/gb-ns2-maintenance.adoc[] include::./common/chapters/control_if.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I951cc10d86de4f16d2226b34eda55202373c2524 Gerrit-Change-Number: 27306 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in pysim[master]: utils: Fix bugs in DataObject encoders

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27648 ) Change subject: utils: Fix bugs in DataObject encoders ...................................................................... utils: Fix bugs in DataObject encoders The DataObject is some weird / rarely used different code than the normal TLV encoder/decoder. It has apparently so far only been used for decoding, without testing the encoding side, resulting in related bugs. Let's fix those that I encountered today, and add a test case. Change-Id: I31370066f43c22fc3ce9e2b9ee75986a652f6fc4 --- M pySim/utils.py M tests/test_utils.py 2 files changed, 19 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/utils.py b/pySim/utils.py index 555aa82..8a7fcdb 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -1333,7 +1333,7 @@ bytes encoded in TLV format. """ val = self.to_bytes() - return bytes(self._compute_tag()) + bytes(len(val)) + val + return bertlv_encode_tag(self._compute_tag()) + bertlv_encode_len(len(val)) + val # 'codec' interface def decode(self, binary: bytes) -> Tuple[dict, bytes]: @@ -1481,7 +1481,8 @@ # 'codec' interface def encode(self, decoded) -> bytes: - obj = self.members_by_name(decoded[0]) + obj = self.members_by_name[list(decoded)[0]] + obj.decoded = list(decoded.values())[0] return obj.to_tlv() diff --git a/tests/test_utils.py b/tests/test_utils.py index ae23461..b7f790d 100755 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -4,6 +4,22 @@ from pySim import utils from pySim.ts_31_102 import EF_SUCI_Calc_Info +# we don't really want to thest TS 102 221, but the underlying DataObject codebase +from pySim.ts_102_221 import AM_DO_EF, AM_DO_DF, SC_DO + +class DoTestCase(unittest.TestCase): + + def testSeqOfChoices(self): + """A sequence of two choices with each a variety of DO/TLVs""" + arr_seq = utils.DataObjectSequence('arr', sequence=[AM_DO_EF, SC_DO]) + # input data + dec_in = [{'access_mode': ['update_erase', 'read_search_compare']}, {'control_reference_template':'PIN1'}] + # encode it once + encoded = arr_seq.encode(dec_in) + # decode again + re_decoded = arr_seq.decode(encoded) + self.assertEqual(dec_in, re_decoded[0]) + class DecTestCase(unittest.TestCase): # TS33.501 Annex C.4 test keys hnet_pubkey_profile_b = "0272DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD1" # ID 27 in test file -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I31370066f43c22fc3ce9e2b9ee75986a652f6fc4 Gerrit-Change-Number: 27648 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in pysim[master]: utils: Add DataObjectSequence.encode_multi()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27649 ) Change subject: utils: Add DataObjectSequence.encode_multi() ...................................................................... utils: Add DataObjectSequence.encode_multi() This is the analogous to the decode_multi() method. Change-Id: Ifdd1b1bd4d67f447638858c3e92742ca6f884bfa --- M pySim/utils.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/utils.py b/pySim/utils.py index 8a7fcdb..ef770f9 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -1561,6 +1561,18 @@ i += 1 return encoded + def encode_multi(self, decoded) -> bytes: + """Encode multiple occurrences of the sequence from the decoded input data. + Args: + decoded : list of json-serializable input data; one sequence per list item + Returns: + binary encoded output data + """ + encoded = bytearray() + for d in decoded: + encoded += self.encode(d) + return encoded + class CardCommand: """A single card command / instruction.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifdd1b1bd4d67f447638858c3e92742ca6f884bfa Gerrit-Change-Number: 27649 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in pysim[master]: ts_102_221: Add encode/write support of EF.ARR records

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27650 ) Change subject: ts_102_221: Add encode/write support of EF.ARR records ...................................................................... ts_102_221: Add encode/write support of EF.ARR records With this change, we can also encode/write EF.ARR records, not just decode/read. Change-Id: Id0da2b474d05aba12136b9cae402ad8326700182 --- M pySim/ts_102_221.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 713d169..bf63f55 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -672,6 +672,11 @@ # 'un-flattening' decoder, and hence would be unable to encode :( return dec[0] + def _encode_record_bin(self, in_json): + # we can only guess if we should decode for EF or DF here :( + arr_seq = DataObjectSequence('arr', sequence=[AM_DO_EF, SC_DO]) + return arr_seq.encode_multi(in_json) + @with_default_category('File-Specific Commands') class AddlShellCommands(CommandSet): def __init__(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id0da2b474d05aba12136b9cae402ad8326700182 Gerrit-Change-Number: 27650 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in pysim[master]: utils: Fix bugs in DataObject encoders

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27648 ) Change subject: utils: Fix bugs in DataObject encoders ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I31370066f43c22fc3ce9e2b9ee75986a652f6fc4 Gerrit-Change-Number: 27648 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:00:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in pysim[master]: utils: Add DataObjectSequence.encode_multi()

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27649 ) Change subject: utils: Add DataObjectSequence.encode_multi() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifdd1b1bd4d67f447638858c3e92742ca6f884bfa Gerrit-Change-Number: 27649 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:00:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in pysim[master]: ts_102_221: Add encode/write support of EF.ARR records

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27650 ) Change subject: ts_102_221: Add encode/write support of EF.ARR records ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id0da2b474d05aba12136b9cae402ad8326700182 Gerrit-Change-Number: 27650 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 05 Apr 2022 13:00:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022