April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: doc/examples: add a multi-trx config config example

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27629 ) Change subject: doc/examples: add a multi-trx config config example ...................................................................... doc/examples: add a multi-trx config config example So far we had no multi-trx config examples at all. Let's add one. Use unique 'RSL TEI' for each TRX, as this simplifies analyzing the Abis protocol traces. Also use the new 'TCH/F_TCH/H_SDCCH8_PDCH'. Change-Id: I20f86fa74dc4bd71538627ec59c5d2cd3678a089 Fixes: OS#4748 --- A doc/examples/osmo-bsc/osmo-bsc-4trx.cfg 1 file changed, 161 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg b/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg new file mode 100644 index 0000000..68d6a38 --- /dev/null +++ b/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg @@ -0,0 +1,161 @@ +! osmo-bsc configuration example with 4 TRX +e1_input + e1_line 0 driver ipa +network + network country code 1 + mobile network code 1 + encryption a5 0 + neci 1 + paging any use tch 0 + bts 0 + type osmo-bts + band DCS1800 + cell_identity 6969 + location_area_code 1 + base_station_id_code 63 + ms max power 15 + cell reselection hysteresis 4 + rxlev access min 0 + radio-link-timeout 32 + channel allocator ascending + rach tx integer 9 + rach max transmission 7 + channel-description attach 1 + channel-description bs-pa-mfrms 5 + channel-description bs-ag-blks-res 1 + early-classmark-sending forbidden + ipa unit-id 6969 0 + oml ipa stream-id 255 line 0 + codec-support fr hr amr + gprs mode none + trx 0 + rf_locked 0 + arfcn 871 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 0 + timeslot 0 + phys_chan_config CCCH + hopping enabled 0 + timeslot 1 + phys_chan_config SDCCH8+CBCH + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + trx 1 + rf_locked 0 + arfcn 873 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 1 + timeslot 0 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 1 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + trx 2 + rf_locked 0 + arfcn 875 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 2 + timeslot 0 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 1 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + trx 3 + rf_locked 0 + arfcn 877 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 3 + timeslot 0 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 1 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 +msc 0 + allow-emergency allow + mgw remote-ip 127.0.0.1 + mgw remote-port 2427 + mgw local-port 2727 +bsc + mid-call-timeout 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I20f86fa74dc4bd71538627ec59c5d2cd3678a089 Gerrit-Change-Number: 27629 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: doc/examples: add a confmerge file with example hopping parameters

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27630 ) Change subject: doc/examples: add a confmerge file with example hopping parameters ...................................................................... doc/examples: add a confmerge file with example hopping parameters This file was taken from docker-playground.git, and this is basically what we use when running the ttcn3-bts-test with hopping enabled. Change-Id: I205eb53901e06ee52dc64e050cfe2374cb9c771e --- M doc/examples/Makefile.am A doc/examples/osmo-bsc/osmo-bsc-4trx-fh.confmerge 2 files changed, 217 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am index 9d8cd75..c25ebc5 100644 --- a/doc/examples/Makefile.am +++ b/doc/examples/Makefile.am @@ -6,7 +6,7 @@ EXTRA_DIST = $(OSMOCONF_FILES) -CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,' +CFG_FILES = find $(srcdir) -name '*.cfg*' -o -name '*.confmerge*' | sed -e 's,^$(srcdir),,' dist-hook: for f in $$($(CFG_FILES)); do \ diff --git a/doc/examples/osmo-bsc/osmo-bsc-4trx-fh.confmerge b/doc/examples/osmo-bsc/osmo-bsc-4trx-fh.confmerge new file mode 100644 index 0000000..0a14631 --- /dev/null +++ b/doc/examples/osmo-bsc/osmo-bsc-4trx-fh.confmerge @@ -0,0 +1,216 @@ +! This is a confmerge file with example frequency hopping parameters. +! Use the osmo-config-merge tool to apply it to osmo-bsc-4trx.cfg. +network + bts 0 + trx 0 + timeslot 0 + ! Shall not be hopping + timeslot 1 + ! Intentionally non-hopping + timeslot 2 + ! (c) HSN=2, MAIO=0,1 + hopping enabled 1 + hopping sequence-number 2 + hopping maio 0 + hopping arfcn add 871 + hopping arfcn add 873 + timeslot 3 + ! (e) HSN=3, MAIO=3,2,1,0 + hopping enabled 1 + hopping sequence-number 3 + hopping maio 3 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 4 + ! Intentionally non-hopping + timeslot 5 + ! (f) HSN=5, MAIO=0,1,2,3 + hopping enabled 1 + hopping sequence-number 5 + hopping maio 0 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 6 + ! (g) HSN=6, MAIO=1,0 + hopping enabled 1 + hopping sequence-number 6 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 877 + timeslot 7 + ! (i) HSN=0, MAIO=1,3 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 875 + trx 1 + timeslot 0 + ! (a) HSN=0, MAIO=0,1,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 0 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 1 + ! Intentionally non-hopping + timeslot 2 + ! (c) HSN=2, MAIO=0,1 + hopping enabled 1 + hopping sequence-number 2 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 873 + timeslot 3 + ! (e) HSN=3, MAIO=3,2,1,0 + hopping enabled 1 + hopping sequence-number 3 + hopping maio 2 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 4 + ! Intentionally non-hopping + timeslot 5 + ! (f) HSN=5, MAIO=0,1,2,3 + hopping enabled 1 + hopping sequence-number 5 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 6 + ! (h) HSN=6, MAIO=1,0 + hopping enabled 1 + hopping sequence-number 6 + hopping maio 1 + hopping arfcn add 873 + hopping arfcn add 875 + timeslot 7 + ! (j) HSN=0, MAIO=0,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 0 + hopping arfcn add 873 + hopping arfcn add 877 + trx 2 + timeslot 0 + ! (a) HSN=0, MAIO=0,1,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 1 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 1 + ! (b) HSN=1, MAIO=3,5 + hopping enabled 1 + hopping sequence-number 1 + hopping maio 3 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 2 + ! (d) HSN=2, MAIO=2,3 + hopping enabled 1 + hopping sequence-number 2 + hopping maio 2 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 3 + ! (e) HSN=3, MAIO=3,2,1,0 + hopping enabled 1 + hopping sequence-number 3 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 4 + ! Intentionally non-hopping + timeslot 5 + ! (f) HSN=5, MAIO=0,1,2,3 + hopping enabled 1 + hopping sequence-number 5 + hopping maio 2 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 6 + ! (h) HSN=6, MAIO=1,0 + hopping enabled 1 + hopping sequence-number 6 + hopping maio 0 + hopping arfcn add 873 + hopping arfcn add 875 + timeslot 7 + ! (i) HSN=0, MAIO=1,3 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 3 + hopping arfcn add 871 + hopping arfcn add 875 + trx 3 + timeslot 0 + ! (a) HSN=0, MAIO=0,1,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 2 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 1 + ! (b) HSN=1, MAIO=3,5 + hopping enabled 1 + hopping sequence-number 1 + hopping maio 5 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 2 + ! (d) HSN=2, MAIO=2,3 + hopping enabled 1 + hopping sequence-number 2 + hopping maio 3 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 3 + ! (e) HSN=3, MAIO=3,2,1,0 + hopping enabled 1 + hopping sequence-number 3 + hopping maio 0 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 4 + ! Intentionally non-hopping + timeslot 5 + ! (f) HSN=5, MAIO=0,1,2,3 + hopping enabled 1 + hopping sequence-number 5 + hopping maio 3 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 6 + ! (g) HSN=6, MAIO=1,0 + hopping enabled 1 + hopping sequence-number 6 + hopping maio 0 + hopping arfcn add 871 + hopping arfcn add 877 + timeslot 7 + ! (j) HSN=0, MAIO=0,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 2 + hopping arfcn add 873 + hopping arfcn add 877 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I205eb53901e06ee52dc64e050cfe2374cb9c771e Gerrit-Change-Number: 27630 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: doc/examples: avoid using deprecated configuration commands

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27628 ) Change subject: doc/examples: avoid using deprecated configuration commands ...................................................................... doc/examples: avoid using deprecated configuration commands Change-Id: Id29fae10ec17eb3d0ac8534d8aebd7251a17577d --- M doc/examples/osmo-bsc/osmo-bsc.cfg M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg b/doc/examples/osmo-bsc/osmo-bsc.cfg index 807bd19..c86a491 100644 --- a/doc/examples/osmo-bsc/osmo-bsc.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc.cfg @@ -17,7 +17,8 @@ handover1 power budget interval 6 handover1 power budget hysteresis 3 handover1 maximum distance 9999 - periodic location update 30 + ! T3212 is in units of 6min, so below we set 5 * 6 = 30min + timer net T3212 5 bts 0 type osmo-bts band DCS1800 @@ -71,7 +72,6 @@ phys_chan_config TCH/F hopping enabled 0 msc 0 - type normal allow-emergency allow amr-config 12_2k forbidden amr-config 10_2k forbidden @@ -84,6 +84,5 @@ mgw remote-ip 127.0.0.1 mgw remote-port 2427 mgw local-port 2727 - mgw endpoint-range 1 31 bsc mid-call-timeout 0 diff --git a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg index 335e23d..e60f39a 100644 --- a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg @@ -16,7 +16,8 @@ handover1 power budget interval 6 handover1 power budget hysteresis 3 handover1 maximum distance 9999 - periodic location update 30 + ! T3212 is in units of 6min, so below we set 5 * 6 = 30min + timer net T3212 5 bts 0 type osmo-bts band DCS1800 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id29fae10ec17eb3d0ac8534d8aebd7251a17577d Gerrit-Change-Number: 27628 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: doc/examples: add a confmerge file with example hopping parameters

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27630 ) Change subject: doc/examples: add a confmerge file with example hopping parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I205eb53901e06ee52dc64e050cfe2374cb9c771e Gerrit-Change-Number: 27630 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:33:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: doc/examples: add a multi-trx config config example

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27629 ) Change subject: doc/examples: add a multi-trx config config example ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I20f86fa74dc4bd71538627ec59c5d2cd3678a089 Gerrit-Change-Number: 27629 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:33:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: doc/examples: avoid using deprecated configuration commands

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27628 ) Change subject: doc/examples: avoid using deprecated configuration commands ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id29fae10ec17eb3d0ac8534d8aebd7251a17577d Gerrit-Change-Number: 27628 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:33:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchf,tchh}_fn(): ensure complete set of bursts

by laforge

Attention is currently required from: fixeria, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27555 ) Change subject: osmo-bts-trx: rx_{tchf,tchh}_fn(): ensure complete set of bursts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I56bebe1374eb803e3c1e9f08dda4da50a074ab0b Gerrit-Change-Number: 27555 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:32:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: new bsc-nat: msc tests

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27625 ) Change subject: new bsc-nat: msc tests ...................................................................... Patch Set 1: (1 comment) File osmo-bsc-nat-latest/osmo-bsc-nat.cfg: https://gerrit.osmocom.org/c/docker-playground/+/27625/comment/5a9cab21_ab7… PS1, Line 2: # can you include a pointer as to where the template + parametes are which generate the files? I could not immediately find it while browsing this patch. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifdb9956a8bdde8aa3f9f62bfcfc035baab01c934 Gerrit-Change-Number: 27625 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:32:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc tests: fix test so they don't depend on previous test runs

by laforge

Attention is currently required from: Hoernchen, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 ) Change subject: msc tests: fix test so they don't depend on previous test runs ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Can you describe better the issue you are fixing here? new version of patch was fixed, but code review from pespin not addressd. I'm also agreeing with pau and waiting for it to be addressed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebaecd28a426b15baf4729f40b46dd33da79cbae Gerrit-Change-Number: 27603 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:30:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement PFCP header and msg handling

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27631 ) Change subject: libosmo-pfcp: implement PFCP header and msg handling ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File include/osmocom/pfcp/pfcp_msg.h: https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/1d5c28ce_fe655651 PS3, Line 69: static inline uint32_t osmo_pfcp_next_seq(uint32_t *seq_state) > This function will return 1 on first call most probably. […] I would expect no constraint whatsoevre on the starting / initial value of the sequence number. Basically every command must have a unique serial number so we can match responses to requests, and the receiver can distinguish re-transmission of a command (same seq) from a new command (different seq) https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/ca80ed75_e149434f PS3, Line 72: (*seq_state) &= 0xffffff; the interesting question is why we use a uint32_t variable if we only use 16 bits of it? https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/f78a1104_ebf16f72 PS3, Line 110: struct osmo_fsm_inst *peer_fi; > Looks like these 2 groups can be in a union? peers and sessins are orthogonal concepts, why do you think a message is only either part of a session or related to a peer? shouldn't it be both at the same time? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3f85ea052a6b7c064244a8093777e53a47c8c61e Gerrit-Change-Number: 27631 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 13:24:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022