April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27684 ) Change subject: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode ...................................................................... Patch Set 3: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27684/comment/d5b88e96_edd6a16e PS1, Line 265: * intentionally invalidate RSSI, so that this report gets dropped in > "intentionally invalidate RSSI for speech blocks" Actually not for speech blocks, but for FACCH in speech mode. Done. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If98aa1f0f7255f20344460bdd07e2c896dd6e56f Gerrit-Change-Number: 27684 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode

by fixeria

Attention is currently required from: fixeria. Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/27684 to look at the new patch set (#3). Change subject: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode ...................................................................... osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode In change [1] I broke measurement reporting for TCH/H in signalling mode. The problem is that in rx_tchh_fn() we started to invalidate the Uplink RSSI for FACCH regardless of the channel mode: speech or signalling. In speech mode, the averaged measurements are carried over by the two BFIs. In signalling mode we send no BFIs, so: * let's use the proper averaging mode S6N6 (not S6N4), and * send the averaged measurements together with the FACCH. This change fixes BTS_Tests.TC_meas_res_sign_tchh[_toa256]. Change-Id: If98aa1f0f7255f20344460bdd07e2c896dd6e56f Fixes: [1] I7902b4709bc3f418174e8373f52e87bb31cdc826 Related: SYS#5853 --- M src/osmo-bts-trx/sched_lchan_tchh.c 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/27684/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If98aa1f0f7255f20344460bdd07e2c896dd6e56f Gerrit-Change-Number: 27684 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchh,tchf}_fn(): use tch_mode directly

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27683 ) Change subject: osmo-bts-trx: rx_{tchh,tchf}_fn(): use tch_mode directly ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9e5e2c891c80c32fc522b53c9371b71ea32dd54d Gerrit-Change-Number: 27683 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:30:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27684 ) Change subject: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27684/comment/b8cbf07d_95ff5980 PS1, Line 265: * intentionally invalidate RSSI, so that this report gets dropped in "intentionally invalidate RSSI for speech blocks" -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If98aa1f0f7255f20344460bdd07e2c896dd6e56f Gerrit-Change-Number: 27684 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:29:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchh,tchf}_fn(): use tch_mode directly

by fixeria

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/27683 ) Change subject: osmo-bts-trx: rx_{tchh,tchf}_fn(): use tch_mode directly ...................................................................... osmo-bts-trx: rx_{tchh,tchf}_fn(): use tch_mode directly There is no reason not to use 'chan_state->tch_mode' directly in the 'switch' statement. If a logical channel is in signalling mode, then both 'chan_state->{rsl,tch}_cmode' are set to RSL_CMOD_SPD_SIGN and GSM48_CMODE_SIGN, respectively. Change-Id: I9e5e2c891c80c32fc522b53c9371b71ea32dd54d Related: SYS#5853 --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/83/27683/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9e5e2c891c80c32fc522b53c9371b71ea32dd54d Gerrit-Change-Number: 27683 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode

by fixeria

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/27684 ) Change subject: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode ...................................................................... osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode In change [1] I broke measurement reporting for TCH/H in signalling mode. The problem is that in rx_tchh_fn() we started to invalidate the Uplink RSSI for FACCH regardless of the channel mode: speech or signalling. In speech mode, the averaged measurements are carried over by the two BFIs. In signalling mode we send no BFIs, so: * let's use the proper averaging mode S6N6 (not S6N4), and * send the averaged measurements together with the FACCH. This change fixes BTS_Tests.TC_meas_res_sign_tchh[_toa256]. Change-Id: If98aa1f0f7255f20344460bdd07e2c896dd6e56f Fixes: [1] I7902b4709bc3f418174e8373f52e87bb31cdc826 Related: SYS#5853 --- M src/osmo-bts-trx/sched_lchan_tchh.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/27684/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If98aa1f0f7255f20344460bdd07e2c896dd6e56f Gerrit-Change-Number: 27684 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Fix typo in expected-results.xml name

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27685 ) Change subject: pgw: Fix typo in expected-results.xml name ...................................................................... pgw: Fix typo in expected-results.xml name Change-Id: I49342db43e81d3e95fa5d13de4cd77b6a67a7af7 --- R pgw/expected-results.xml 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/pgw/expected_results.xml b/pgw/expected-results.xml similarity index 100% rename from pgw/expected_results.xml rename to pgw/expected-results.xml -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49342db43e81d3e95fa5d13de4cd77b6a67a7af7 Gerrit-Change-Number: 27685 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Fix typo in expected-results.xml name

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27685 ) Change subject: pgw: Fix typo in expected-results.xml name ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49342db43e81d3e95fa5d13de4cd77b6a67a7af7 Gerrit-Change-Number: 27685 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Apr 2022 17:27:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Fix typo in expected-results.xml name

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27685 ) Change subject: pgw: Fix typo in expected-results.xml name ...................................................................... pgw: Fix typo in expected-results.xml name Change-Id: I49342db43e81d3e95fa5d13de4cd77b6a67a7af7 --- R pgw/expected-results.xml 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/27685/1 diff --git a/pgw/expected_results.xml b/pgw/expected-results.xml similarity index 100% rename from pgw/expected_results.xml rename to pgw/expected-results.xml -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49342db43e81d3e95fa5d13de4cd77b6a67a7af7 Gerrit-Change-Number: 27685 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Add T_guard

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27661 ) Change subject: pgw: Add T_guard ...................................................................... pgw: Add T_guard Change-Id: I9dce4aee4a0b1181bb7dc1a53fb254e6d17cf22e --- M pgw/PGW_Tests.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index d9f4979..a65ca43 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -40,6 +40,16 @@ var DIAMETER_Emulation_CT vc_DIAMETER; port DIAMETER_PT DIAMETER_UNIT; port DIAMETEREM_PROC_PT DIAMETER_PROC; + /* global test case guard timer (actual timeout value is set in f_init()) */ + timer T_guard; +} + +/* global altstep for global guard timer; */ +altstep as_Tguard() runs on PGW_Test_CT { + [] T_guard.timeout { + setverdict(fail, "Timeout of T_guard"); + mtc.stop; + } } /* per-session component; we typically have 1..N per testcase */ @@ -138,7 +148,10 @@ f_diameter_wait_capability(DIAMETER_UNIT); } -private function f_init() runs on PGW_Test_CT { +private function f_init(float guard_timeout := 60.0) runs on PGW_Test_CT { + T_guard.start(guard_timeout); + activate(as_Tguard()); + var Gtp2EmulationCfg cfg := { gtpc_bind_ip := mp_local_hostname_c, gtpc_bind_port := GTP2C_PORT, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9dce4aee4a0b1181bb7dc1a53fb254e6d17cf22e Gerrit-Change-Number: 27661 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022