April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: pgw: Add expected_results.xml

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27682 ) Change subject: pgw: Add expected_results.xml ...................................................................... pgw: Add expected_results.xml Change-Id: I451b10a7b79854e630e7f2d487423dc39ade5bbd --- A pgw/expected_results.xml 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/pgw/expected_results.xml b/pgw/expected_results.xml new file mode 100644 index 0000000..65daf0e --- /dev/null +++ b/pgw/expected_results.xml @@ -0,0 +1,9 @@ +<?xml version="1.0"?> +<testsuite name='PGW_Tests' tests='6' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='PGW_Tests' name='TC_tx_echo' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_createSession' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_createSession_ping4' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_createSession_ping4_256' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_createSession_deleteSession' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_deleteSession_unknown' time='MASKED'/> +</testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I451b10a7b79854e630e7f2d487423dc39ade5bbd Gerrit-Change-Number: 27682 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Add expected_results.xml

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27682 ) Change subject: pgw: Add expected_results.xml ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I451b10a7b79854e630e7f2d487423dc39ade5bbd Gerrit-Change-Number: 27682 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:23:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ci[master]: jobs: Add ttcn3-pgw-test jenkins job

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27660 ) Change subject: jobs: Add ttcn3-pgw-test jenkins job ...................................................................... jobs: Add ttcn3-pgw-test jenkins job Change-Id: I363a7a8eb524abfeb45c81603c29cea96f86a787 --- M jobs/ttcn3-testsuites.yml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 5fb994d..89915a2 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -154,6 +154,11 @@ blocking: "^(ttcn3|TTCN3-.*)-fr-test.*" timer: 40 10 * * * node: hdlc + - ttcn3-pgw-test: + blocking: "^(ttcn3|TTCN3-.*)-pgw-test.*" + timer: 00 14 * * * + description: | + Test open5gs-smfd + open5gs-upfd PGW main. # debian-stretch latest stable - nplab-m3ua-test-latest: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I363a7a8eb524abfeb45c81603c29cea96f86a787 Gerrit-Change-Number: 27660 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchh,tchf}_fn(): use tch_mode directly

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27683 ) Change subject: osmo-bts-trx: rx_{tchh,tchf}_fn(): use tch_mode directly ...................................................................... osmo-bts-trx: rx_{tchh,tchf}_fn(): use tch_mode directly There is no reason not to use 'chan_state->tch_mode' directly in the 'switch' statement. If a logical channel is in signalling mode, then both 'chan_state->{rsl,tch}_cmode' are set to RSL_CMOD_SPD_SIGN and GSM48_CMODE_SIGN, respectively. Change-Id: I9e5e2c891c80c32fc522b53c9371b71ea32dd54d --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/83/27683/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 6a9a0f0..4f5d6d3 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -116,8 +116,8 @@ /* decode * also shift buffer by 4 bursts for interleaving */ - switch ((rsl_cmode != RSL_CMOD_SPD_SPEECH) ? GSM48_CMODE_SPEECH_V1 - : tch_mode) { + switch (tch_mode) { + case GSM48_CMODE_SIGN: case GSM48_CMODE_SPEECH_V1: /* FR */ rc = gsm0503_tch_fr_decode(tch_data, *bursts_p, 1, 0, &n_errors, &n_bits_total); if (rc == GSM_FR_BYTES) /* only for valid *speech* frames */ diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 369e35b..a8bdd08 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -133,8 +133,8 @@ /* decode * also shift buffer by 4 bursts for interleaving */ - switch ((rsl_cmode != RSL_CMOD_SPD_SPEECH) ? GSM48_CMODE_SPEECH_V1 - : tch_mode) { + switch (tch_mode) { + case GSM48_CMODE_SIGN: case GSM48_CMODE_SPEECH_V1: /* HR or signalling */ /* Note on FN-10: If we are at FN 10, we decoded an even aligned * TCH/FACCH frame, because our burst buffer carries 6 bursts. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9e5e2c891c80c32fc522b53c9371b71ea32dd54d Gerrit-Change-Number: 27683 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27684 ) Change subject: osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode ...................................................................... osmo-bts-trx: rx_tchh_fn(): fix meas reporting in signalling mode In change [1] I broke measurement reporting for TCH/H in signalling mode. The problem is that in rx_tchh_fn() we started to invalidate the Uplink RSSI for FACCH regardless of the channel mode: speech or signalling. In speech mode, the averaged measurements are carried over by the two BFIs. In signalling mode we send no BFIs, so: * let's use the proper averaging mode S6N6 (not S6N4), and * send the averaged measurements together with the FACCH. This change fixes BTS_Tests.TC_meas_res_sign_tchh[_toa256]. Change-Id: If98aa1f0f7255f20344460bdd07e2c896dd6e56f Fixes: [1] I7902b4709bc3f418174e8373f52e87bb31cdc826 --- M src/osmo-bts-trx/sched_lchan_tchh.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/27684/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index a8bdd08..fa3434e 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -135,6 +135,8 @@ * also shift buffer by 4 bursts for interleaving */ switch (tch_mode) { case GSM48_CMODE_SIGN: + meas_avg_mode = SCHED_MEAS_AVG_M_S6N6; + /* fall-through */ case GSM48_CMODE_SPEECH_V1: /* HR or signalling */ /* Note on FN-10: If we are at FN 10, we decoded an even aligned * TCH/FACCH frame, because our burst buffer carries 6 bursts. @@ -265,7 +267,7 @@ * with the first BFI (see below). */ _sched_compose_ph_data_ind(l1ts, fn_begin, bi->chan, tch_data + amr, GSM_MACBLOCK_LEN, - 0, /* intentionally invalidate RSSI */ + tch_mode == GSM48_CMODE_SIGN ? meas_avg.rssi : 0, meas_avg.toa256, meas_avg.ci_cb, ber10k, PRES_INFO_UNKNOWN); ber10k = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If98aa1f0f7255f20344460bdd07e2c896dd6e56f Gerrit-Change-Number: 27684 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Add T_guard

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27661 ) Change subject: pgw: Add T_guard ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9dce4aee4a0b1181bb7dc1a53fb254e6d17cf22e Gerrit-Change-Number: 27661 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ci[master]: jobs: Add ttcn3-pgw-test jenkins job

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27660 ) Change subject: jobs: Add ttcn3-pgw-test jenkins job ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I363a7a8eb524abfeb45c81603c29cea96f86a787 Gerrit-Change-Number: 27660 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:22:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Add expected_results.xml

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27682 ) Change subject: pgw: Add expected_results.xml ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I451b10a7b79854e630e7f2d487423dc39ade5bbd Gerrit-Change-Number: 27682 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:21:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Add T_guard

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27661 ) Change subject: pgw: Add T_guard ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9dce4aee4a0b1181bb7dc1a53fb254e6d17cf22e Gerrit-Change-Number: 27661 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:20:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Add expected_results.xml

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27682 ) Change subject: pgw: Add expected_results.xml ...................................................................... pgw: Add expected_results.xml Change-Id: I451b10a7b79854e630e7f2d487423dc39ade5bbd --- A pgw/expected_results.xml 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/27682/1 diff --git a/pgw/expected_results.xml b/pgw/expected_results.xml new file mode 100644 index 0000000..65daf0e --- /dev/null +++ b/pgw/expected_results.xml @@ -0,0 +1,9 @@ +<?xml version="1.0"?> +<testsuite name='PGW_Tests' tests='6' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='PGW_Tests' name='TC_tx_echo' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_createSession' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_createSession_ping4' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_createSession_ping4_256' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_createSession_deleteSession' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_deleteSession_unknown' time='MASKED'/> +</testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I451b10a7b79854e630e7f2d487423dc39ade5bbd Gerrit-Change-Number: 27682 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022