April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: assignment_fsm: always update RTP info

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27657 ) Change subject: assignment_fsm: always update RTP info ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0788d1f013b8f820f559b6ed58a5f9bb8a02e0b4 Gerrit-Change-Number: 27657 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 11:07:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: assignment_fsm: always mark MGCP ci as completed

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27656 ) Change subject: assignment_fsm: always mark MGCP ci as completed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5ab10ee7fd9c5d7608e8a06893881d990943feed Gerrit-Change-Number: 27656 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 11:05:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Diameter_Templates.ttcn: Avoid sending AuthAppId Relay in CEA

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27654 ) Change subject: Diameter_Templates.ttcn: Avoid sending AuthAppId Relay in CEA ...................................................................... Patch Set 1: Code-Review+2 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27654/comment/14ab4bfa_5162… PS1, Line 7: Relay This is the key word here. Patchset: PS1: The comments below helped me to understand the patch better while doing review. File library/DIAMETER_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27654/comment/23b0b8a2_3443… PS1, Line 883: ts_AVP_AuthAppId Here I see that the ts_AVP_AuthAppId was listed twice, so we're including only one now with the given auth_app_id value. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a9daf094f4c27c0b4de5581ddd56feced8e5732 Gerrit-Change-Number: 27654 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 08:33:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add TC_emerg_call_and_lcs_loc_req

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27659 ) Change subject: bsc: add TC_emerg_call_and_lcs_loc_req ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95037374c45943cb14401bc48f16a39c2fcbe1f5 Gerrit-Change-Number: 27659 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 08:27:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: as_Media_mgw: fail on DLCX

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27658 ) Change subject: bsc: as_Media_mgw: fail on DLCX ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0633f60f09d58802f6be0238ef41a632d93a4327 Gerrit-Change-Number: 27658 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 08:16:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: assignment_fsm: always update RTP info

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27657 ) Change subject: assignment_fsm: always update RTP info ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0788d1f013b8f820f559b6ed58a5f9bb8a02e0b4 Gerrit-Change-Number: 27657 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 08:13:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: assignment_fsm: always mark MGCP ci as completed

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27656 ) Change subject: assignment_fsm: always mark MGCP ci as completed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5ab10ee7fd9c5d7608e8a06893881d990943feed Gerrit-Change-Number: 27656 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Apr 2022 08:12:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: as_Media_mgw: fail on DLCX

by neels

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27658 to look at the new patch set (#2). Change subject: bsc: as_Media_mgw: fail on DLCX ...................................................................... bsc: as_Media_mgw: fail on DLCX as_Media_mgw() is used to establish a voice stream. If a DLCX happens as part of that, that should be flagged as a problem. In fact the Mode Modify test with current osmo-bsc does exhibit a DLCX right upon the Assignment Complete message, which is a bug fixed in I5ab10ee7fd9c5d7608e8a06893881d990943feed. This patch now correctly flags this as a failure. In the two tests TC_ho_in_fail_no_detect, TC_ho_in_fail_no_detect2 the expected failure causes expected DLCX, so exempt those. Related: SYS#5916 Change-Id: I0633f60f09d58802f6be0238ef41a632d93a4327 --- M bsc/BSC_Tests.ttcn M bsc/MSC_ConnectionHandler.ttcn 2 files changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/27658/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0633f60f09d58802f6be0238ef41a632d93a4327 Gerrit-Change-Number: 27658 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement PFCP header and msg handling

by neels

Attention is currently required from: laforge, fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27631 ) Change subject: libosmo-pfcp: implement PFCP header and msg handling ...................................................................... Patch Set 3: (9 comments) File include/osmocom/pfcp/pfcp_msg.h: https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/cbc1654c_1e49a1e5 PS3, Line 44: #define OSMO_LOG_PFCP_MSG_SRC(M, LEVEL, file, line, FMT, ARGS...) do { \ > Agree, let's avoid over bloated macros please. you are aware of the "ARGS..." argument, are you sure you want this to be a function with a va_list? It would be the first time we'd not use a macro for LOGP() style functionality, afaik. https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/7f927825_898265ce PS3, Line 69: static inline uint32_t osmo_pfcp_next_seq(uint32_t *seq_state) > I would expect no constraint whatsoevre on the starting / initial value of the sequence number. […] The seq nr can be chosen freely. I want it to start with 1 because 0 happens when a struct is zero initialized. I guess I also want it to not wrap to 0 then? https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/13f4be4f_0b1d9503 PS3, Line 72: (*seq_state) &= 0xffffff; > the interesting question is why we use a uint32_t variable if we only use 16 bits of it? that's 24 bits. osmo_pfcp_header_parsed stores a uint32_t, on the wire it is 24 bits wide. https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/9e7ce90a_ff801eb0 PS3, Line 110: struct osmo_fsm_inst *peer_fi; > peers and sessins are orthogonal concepts, why do you think a message is only either part of a sessi […] if it is only related to a peer (Association Setup / Update, etc), session == NULL. If it is related to a session, it is also related to a peer that the session is set up with. Both pointers are used to reduce lookup iterations. endpoint +- peer +- session (If related to a session, this more precisely shows where the message belongs, so the logging macro prefers the session fi to log on. Still the peer fi will point to the correct peer as well.) BTW, these are optionally used by the calling code, they may also remain NULL entirely. https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/5e1a2400_2038e37d PS3, Line 123: #define OSMO_PFCP_MSG_FOR_IES(IES_P) ((struct osmo_pfcp_msg *)((char *)IES_P - offsetof(struct osmo_pfcp_msg, ies))) > what's the meaning of FOR here? there is the osmo_pfcp_msg->ies member. Given the pointer to ies, get the containing osmo_pfcp_msg. So get the msg "for" an ies union. the FOR literally means 'for', could also be FROM? Adding a comment. https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/d8cb27b5_1c737206 PS3, Line 149: #define OSMO_PFCP_MSG_MEMB(M, OFS) ((OFS) <= 0 ? NULL : (void *)((uint8_t *)(M) + OFS)) > write it as a static inline, where you can set type of OFS to unsigned, you can then drop the first […] for example, some messages don't have a Cause IE. So if osmo_pfcp_msg->ofs_cause is 0 or < 0, I want to get NULL returned. File src/libosmo-pfcp/pfcp_msg.c: https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/0bb42391_a3f66150 PS3, Line 65: struct osmo_pfcp_header_common { > Don't you need to add conditional blocks for little/big endian here? oh yes, forgot to run that script... https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/4b6ace2a_8c137c7b PS3, Line 72: uint16_t message_length; > You may want to use here: […] i think i made separate structs to get a nice sizeof() of the common part. hmm, zero length arrays would work for that. but then i can't store anything in those. I'll see if it makes the code simpler... https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/a88d7cf3_67f2d372 PS3, Line 338: /* Append the encoded PFCP message to the message buffer. > I see a lot of stuff to put several messages into one buffer. […] It is a feature described in the PFCP specs. Only after implementing did I notice that we could simply indicate feature BUNDL==0 and thus tell the other side that we need each message in its own packet. So now by accident we have the ability to parse bundled PFCP and let's say we are ready to implement encoding of bundled PFCP. Might turn out to be a good thing when interworking with high throughput components? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3f85ea052a6b7c064244a8093777e53a47c8c61e Gerrit-Change-Number: 27631 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Apr 2022 23:13:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: as_Media_mgw: fail on DLCX

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27658 ) Change subject: bsc: as_Media_mgw: fail on DLCX ...................................................................... bsc: as_Media_mgw: fail on DLCX as_Media_mgw() is used to establish a voice stream. If a DLCX happens as part of that, that should be flagged as a problem. In fact the Mode Modify test with current osmo-bsc does exhibit a DLCX right upon the Assignment Complete message, which is a bug fixed in I5ab10ee7fd9c5d7608e8a06893881d990943feed. This patch now correctly flags this as a failure. Related: SYS#5916 Change-Id: I0633f60f09d58802f6be0238ef41a632d93a4327 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/27658/1 diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index a50b6f4..68a034b 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -383,6 +383,9 @@ var template MgcpMessage msg_mdcx := { command := tr_MDCX } + var template MgcpMessage msg_dlcx := { + command := tr_DLCX + } var template MgcpMessage msg_resp; [g_pars.aoip] MGCP.receive(tr_CRCX) -> value mgcp_cmd { @@ -422,6 +425,14 @@ repeat; } } + + [g_pars.aoip] MGCP.receive(tr_DLCX) { + setverdict(fail, "Unexpected DLCX received"); + } + + [not g_pars.aoip] MGCP_MULTI.receive(tr_MGCP_RecvFrom_any(msg_dlcx)) { + setverdict(fail, "Unexpected DLCX received"); + } } /* Altsteps for handling of media related commands. Can be activated by a given -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0633f60f09d58802f6be0238ef41a632d93a4327 Gerrit-Change-Number: 27658 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022