March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: contrib: add PFCP cause and IEI string maps

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27220 ) Change subject: contrib: add PFCP cause and IEI string maps ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7f37efd3cfc4c7b0ae49740ac15e461c52fae6e8 Gerrit-Change-Number: 27220 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 11:01:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: libosmo-tlv: add versatile TLV de- and encoder

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27217 ) Change subject: libosmo-tlv: add versatile TLV de- and encoder ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: as a general rule we don't introduce symbols or types with an osmo_ prefix into applications. This will likely clash with stuff from libraries. So we can either move this library to libosmocore (or a separate library git repo), and keep the osmo_ prefix, or we can keep it locally in-tree and then remove/rename the osmo_ prefix. If we move to libosmocore or a separate repo, we shuld also revisit the name. osmo_tlv and osmo_vtlv are already used with a different meaning in libosmocore. Maybe osmo_ntlv (new tlv)? ideas? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0fd00d9f288ffe13b7e67701f3e47073587404a Gerrit-Change-Number: 27217 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 10:59:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: tweak license headers

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27530 ) Change subject: tweak license headers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I1f542534903fce9d68fce11f16822e9fbead89ec Gerrit-Change-Number: 27530 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 10:56:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: tweak license headers

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27530 ) Change subject: tweak license headers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I1f542534903fce9d68fce11f16822e9fbead89ec Gerrit-Change-Number: 27530 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 08:57:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27222 ) Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: here i cannot satisfy the linter in these 15 instances like src/libosmo-pfcp/pfcp_ies_custom.c:85: ERROR:SPACING: spaces required around that '==' (ctx:BxW) because of this construct: #define ENSURE_LENGTH_IS(CONDITION) \ do { \ if (!(tlv->len CONDITION)) \ RETURN_ERROR(-EINVAL, "IE has length = %zu, expected length " #CONDITION, tlv->len); \ } while (0) ... ENSURE_LENGTH_IS(>= 2); When I add a space between '(' and '>=', I get: space prohibited after that open parenthesis '(' I'd rather keep the macro, to not dup the error message... At the same time the linter is technically correct in refusing. Any opinions? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Mar 2022 20:07:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

by neels

Attention is currently required from: neels, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 to look at the new patch set (#9). Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... libosmo-pfcp: implement/generate TLV and IE value coding Related: SYS#5599 Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 --- M include/osmocom/pfcp/Makefile.am A include/osmocom/pfcp/pfcp_ies_custom.h M src/libosmo-pfcp/Makefile.am A src/libosmo-pfcp/gen__pfcp_ies_auto.c A src/libosmo-pfcp/pfcp_ies_custom.c 5 files changed, 1,556 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/22/27222/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

by neels

Attention is currently required from: neels, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 to look at the new patch set (#8). Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... libosmo-pfcp: implement/generate TLV and IE value coding Related: SYS#5599 Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 --- M include/osmocom/pfcp/Makefile.am A include/osmocom/pfcp/pfcp_ies_custom.h M src/libosmo-pfcp/Makefile.am A src/libosmo-pfcp/gen__pfcp_ies_auto.c A src/libosmo-pfcp/pfcp_ies_custom.c 5 files changed, 1,556 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/22/27222/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

by neels

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 to look at the new patch set (#7). Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... libosmo-pfcp: implement/generate TLV and IE value coding Related: SYS#5599 Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 --- M include/osmocom/pfcp/Makefile.am A include/osmocom/pfcp/pfcp_ies_custom.h M src/libosmo-pfcp/Makefile.am A src/libosmo-pfcp/gen__pfcp_ies_auto.c A src/libosmo-pfcp/pfcp_ies_custom.c 5 files changed, 1,556 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/22/27222/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27222 ) Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... Patch Set 6: (1 comment) File include/osmocom/pfcp/Makefile.am: https://gerrit.osmocom.org/c/osmo-upf/+/27222/comment/8cef1ad8_28f54a3a PS3, Line 17: pfcp_ies_auto.h: $(top_srcdir)/src/libosmo-pfcp/gen__pfcp_ies_auto.c \ > I'm not a Makefile guru so no idea, I just noticed that you use it in "$(MAKE) -C $(top_builddir)/sr […] the build dir is created during configure -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Mar 2022 19:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 to look at the new patch set (#6). Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... libosmo-pfcp: implement/generate TLV and IE value coding Related: SYS#5599 Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 --- M include/osmocom/pfcp/Makefile.am A include/osmocom/pfcp/pfcp_ies_custom.h M src/libosmo-pfcp/Makefile.am A src/libosmo-pfcp/gen__pfcp_ies_auto.c A src/libosmo-pfcp/pfcp_ies_custom.c 5 files changed, 1,548 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/22/27222/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022