laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27570 )
Change subject: debian/control: libosmocore-dev must depend on libsctp-dev
......................................................................
debian/control: libosmocore-dev must depend on libsctp-dev
As our pkg-config files now 'Require' libsctp, we are seeing build
failures as libsctp-dev is not installed when building
libosmocore-dependant packages. Let's add the missing dependency.
Change-Id: I5d61149cd5b571586d426d1d6bf929e73a322fff
Fixes: I2ab1fe8e4bbfc120b471d6c9f2312a89dbc7d42b
---
M debian/control
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/27570/1
diff --git a/debian/control b/debian/control
index 771fff2..0357cc2 100644
--- a/debian/control
+++ b/debian/control
@@ -320,6 +320,7 @@
Section: libdevel
Depends: libosmocore,
libtalloc-dev (>= 2.1.0),
+ libsctp-dev,
${misc:Depends}
Description: Development headers for Open Source MObile COMmunications CORE library
The header files provided by this package may be used to develop
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27570
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5d61149cd5b571586d426d1d6bf929e73a322fff
Gerrit-Change-Number: 27570
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )
Change subject: Add vty `imsi unknown cause` to set the reject cause
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
Patchset:
PS6:
CR-1 for incomplete command description. Try running osmo-hlr with this patch, enter the VTY interface and check help ('?') for all components of the new command. You should see something like this:
OsmoHLR(config-hlr)# imsi?
Define the GSUP cause to be send in case the IMSI could not found in the database.
OsmoHLR(config-hlr)# imsi unknown?
Default is imsi-unknown.
OsmoHLR(config-hlr)# imsi unknown cause?
NULL
OsmoHLR(config-hlr)# imsi unknown cause ?
NULL
I am surprised why Jenkins does not catch this. Usually it does.
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/95854688_b8539486
PS6, Line 381: imsi unknown cause
Here I would recommend concatenating all three words using '-', i.e. 'imsi-unknown-cause'. Otherwise the VTY engine requires you to provide help strings for each separate word in the command. Ah, actually I already suggested using 'subscriber-reject-cause' in one of my previous comments.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 25 Mar 2022 08:41:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )
Change subject: Add vty `imsi unknown cause` to set the reject cause
......................................................................
Patch Set 6:
(3 comments)
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/c5ddcde6_8c15b5c0
PS4, Line 88: imsi_cause_code
> ok. […]
It seems to be a common practice in Osmocom to not print parameters with default values. But this is not critical, you may ignore this comment.
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/458ea28f_759e83c5
PS4, Line 356: imsi unknown cause
> Ack
Given that you're adding a value-string array now, it would be better to generate the command and help strings dynamically from gsm48_gmm_cause_vty_names[]. For example, grep for 'cfg_bts_type_cmd' in osmo-bsc.git. This would resolve the problem of missing description for each entry which is still present in your new patchset.
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/5c3708e4_bb104ccf
PS4, Line 357: GSUP cause
> Yes and not. […]
Saying GSUP/GMM is an option ;) But I don't want to block you here, so you can keep this as is.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 25 Mar 2022 08:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment