Attention is currently required from: laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27583 )
Change subject: intf_line.c: Make e1d_find_intf_by_usb_serial safe for empty string
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Not an "empty string", more like NULL string, but I see the idea 😊
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27583
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ia69912cb714441415d8decd68890d1b97b77132d
Gerrit-Change-Number: 27583
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27582 )
Change subject: cosmetic: Remove extra empty newlines from end of intf_line.c
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27582
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ie1e193c3d851871c9c96394eb19f5b99c09913f9
Gerrit-Change-Number: 27582
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:32:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27580 )
Change subject: libosmovty: Link libosmovty against libpthread
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27580
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7febbf88cbe61eacd05f46a9316e773b5c148e77
Gerrit-Change-Number: 27580
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:32:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: manawyrm, laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27579 )
Change subject: usb: Deal with truncated ISO IN transfers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Mmm ... doing that there is a bit weird because conceptually _e1uf_xxx is just usb flow but it's also used for the feedback end point and doesn't really imply the "4 byte header + 32 * n" stucture.
Can't this be handled in the callback for the IN endpoints rather ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27579
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ic453325b93b0e12727625a1495a948d96df4b542
Gerrit-Change-Number: 27579
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:31:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, tnt.
manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27578 )
Change subject: usb: Pass not just the actual transfer length but also the buffer size
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27578
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I5088a5213d2945fdfaf3b242a63e35d0ed511914
Gerrit-Change-Number: 27578
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:31:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment