Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-e1d/+/27588
to look at the new patch set (#2).
Change subject: OCTOI: initial support for E1oIP forwarding
......................................................................
OCTOI: initial support for E1oIP forwarding
This introduces initial support for operation as OCTOI (Osmocom
Community TDMoIP) server and client operation.
Various features are still absent (user authentication, support for
re-ordered packets), but this version is already able to provide
services to clients with dynamic IP addresses as well as servers.
The bulk of the OCTOI / E1oIP code is implemented as a shared library,
to facilitate the development of other servers and clients in the
future, and also to minimize the impact on the existing osmo-e1d code
base.
More information is available at https://osmocom.org/projects/octoi/wiki
Change-Id: I05f5ff697ca8f7dccdcf89660f12089babfcc92e
---
M configure.ac
M include/Makefile.am
M include/osmocom/e1d/proto.h
A include/osmocom/octoi/e1oip_proto.h
A include/osmocom/octoi/octoi.h
M src/Makefile.am
M src/ctl.c
M src/e1d.h
A src/e1oip.c
M src/intf_line.c
M src/mux_demux.c
A src/octoi/Makefile.am
A src/octoi/e1oip.c
A src/octoi/e1oip.h
A src/octoi/frame_fifo.c
A src/octoi/frame_fifo.h
A src/octoi/libosmo-octoi.map
A src/octoi/octoi.c
A src/octoi/octoi.h
A src/octoi/octoi_clnt_fsm.c
A src/octoi/octoi_clnt_vty.c
A src/octoi/octoi_fsm.c
A src/octoi/octoi_fsm.h
A src/octoi/octoi_sock.c
A src/octoi/octoi_sock.h
A src/octoi/octoi_srv_fsm.c
A src/octoi/octoi_srv_vty.c
A src/octoi/octoi_vty.h
M src/osmo-e1d.c
M src/usb.c
M src/vty.c
31 files changed, 3,387 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/88/27588/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27588
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I05f5ff697ca8f7dccdcf89660f12089babfcc92e
Gerrit-Change-Number: 27588
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27583 )
Change subject: intf_line.c: Make e1d_find_intf_by_usb_serial safe for empty string
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Not an "empty string", more like NULL string, but I see the idea 😊
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27583
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ia69912cb714441415d8decd68890d1b97b77132d
Gerrit-Change-Number: 27583
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27582 )
Change subject: cosmetic: Remove extra empty newlines from end of intf_line.c
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27582
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ie1e193c3d851871c9c96394eb19f5b99c09913f9
Gerrit-Change-Number: 27582
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:32:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27580 )
Change subject: libosmovty: Link libosmovty against libpthread
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27580
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7febbf88cbe61eacd05f46a9316e773b5c148e77
Gerrit-Change-Number: 27580
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:32:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: manawyrm, laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27579 )
Change subject: usb: Deal with truncated ISO IN transfers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Mmm ... doing that there is a bit weird because conceptually _e1uf_xxx is just usb flow but it's also used for the feedback end point and doesn't really imply the "4 byte header + 32 * n" stucture.
Can't this be handled in the callback for the IN endpoints rather ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27579
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ic453325b93b0e12727625a1495a948d96df4b542
Gerrit-Change-Number: 27579
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:31:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment