Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30766 )
Change subject: jenkins-common: tweak echo messages
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> maybe we should define a shell function for doing the set -x / echo / set +x?
that would have the same problem:
+ echo_without_set_x Creating network ttcn3-bts-test
Creating network ttcn3-bts-test
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30766
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I213cb80bd1d9401281ae1fb7394b2319453550dd
Gerrit-Change-Number: 30766
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 22 Dec 2022 14:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: osmith, daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30768 )
Change subject: scripts/regen_doc: use SUBNET variable
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30768
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I3bda4bd7280469ad5ee02104295134a2e0b768e3
Gerrit-Change-Number: 30768
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Dec 2022 14:03:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30766 )
Change subject: jenkins-common: tweak echo messages
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
maybe we should define a shell function for doing the set -x / echo / set +x?
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30766
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I213cb80bd1d9401281ae1fb7394b2319453550dd
Gerrit-Change-Number: 30766
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Dec 2022 14:02:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30767 )
Change subject: ttcn3-ggsn-test: cp initrd-ggsn.sh to VOL_BASE_DIR
......................................................................
ttcn3-ggsn-test: cp initrd-ggsn.sh to VOL_BASE_DIR
Prepare for a future patch where a free subnet will be figured out
automatically instead of having a hardcoded one, by moving
initrd-ggsn.sh to $VOL_BASE_DIR as the subnet will be replaced in files
in this directory.
Related: OS#5802
Change-Id: Ie4f35b77a2bff20f2a0479890a429754768cafd2
---
M ttcn3-ggsn-test/jenkins.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/67/30767/1
diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh
index c8968ad..0797f76 100755
--- a/ttcn3-ggsn-test/jenkins.sh
+++ b/ttcn3-ggsn-test/jenkins.sh
@@ -31,11 +31,12 @@
GGSN_DOCKER_ARGS=""
if [ "$KERNEL_TEST" = "1" ]; then
cp osmo-ggsn-kernel-gtp.cfg $VOL_BASE_DIR/ggsn/osmo-ggsn.cfg
+ cp initrd-ggsn.sh $VOL_BASE_DIR/ggsn/
kernel_test_prepare \
"defconfig" \
"fragment.config" \
- "initrd-ggsn.sh" \
+ "$VOL_BASE_DIR/ggsn/initrd-ggsn.sh" \
"$REPO_USER/osmo-ggsn-$IMAGE_SUFFIX" \
-v $VOL_BASE_DIR/ggsn:/data
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30767
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ie4f35b77a2bff20f2a0479890a429754768cafd2
Gerrit-Change-Number: 30767
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange