December 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: gsm0808: add gsm0808_enc_speech_codec[_list]2()

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30574 ) Change subject: gsm0808: add gsm0808_enc_speech_codec[_list]2() ...................................................................... Patch Set 2: (2 comments) File include/osmocom/gsm/gsm0808_utils.h: https://gerrit.osmocom.org/c/libosmocore/+/30574/comment/8d641b5b_b7ebdb34 PS1, Line 115: OSMO_DEPRECATED("use gsm0808_enc_speech_codec2() instead") > It's the first time I see such a suggestion/requirement. […] i usually read .h files, and spotting the difference between two function versions goes a lot quicker when something explains it. IMO adding a few words can only improve it, but you do also explain in the API doc. so up to you. File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/c/libosmocore/+/30574/comment/b89ce137_b2ea32c4 PS1, Line 299: \a > This is not directly related to this patch, but could you explain why? see the post linked at https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_AP… good that i read this again, '\a' is actually not wrong, it just puts the next word in italics. it's just my personal opinion that we should not use \a, for KISS. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I199ffa0ba4a64813238519178155dfc767aa3975 Gerrit-Change-Number: 30574 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Dec 2022 21:58:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: sched: Pass pdch to *_create_rlcmac_msg() functions

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30565 ) Change subject: sched: Pass pdch to *_create_rlcmac_msg() functions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic31a7360a29e61f70bb1338ddab6f5f31aa8b26e Gerrit-Change-Number: 30565 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Dec 2022 21:57:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: Move control_ts explicit checks out of the scheduler implementation

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30564 ) Change subject: Move control_ts explicit checks out of the scheduler implementation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/30564/comment/0dd9d180_0a816ba9 PS2, Line 9: Let each subsystem handle that internally. I understand what this patch is doing, but would like see the motivation explained here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifaf7dde651d56942779d84aa9135fc8c974b6f26 Gerrit-Change-Number: 30564 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Dec 2022 21:54:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-msc[master]: libmsc: check return value of gsm0808_create_ass2()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/30582 ) Change subject: libmsc: check return value of gsm0808_create_ass2() ...................................................................... libmsc: check return value of gsm0808_create_ass2() Change-Id: I6fd1669f2919034599d99336cf56f25a97afdf7c --- M src/libmsc/ran_msg_a.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/82/30582/1 diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index be026e5..24740a7 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -1002,6 +1002,12 @@ msg = gsm0808_create_ass2(ac->channel_type, NULL, use_rtp_addr, use_scl, call_id, NULL, ac->lcls); + if (msg == NULL) { + LOG_RAN_A_ENC(log_fi, LOGL_ERROR, + "Failed to encode BSSMAP Assignment Request message\n"); + return NULL; + } + if (ac->osmux_present) _gsm0808_assignment_extend_osmux(msg, ac->osmux_cid); return msg; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6fd1669f2919034599d99336cf56f25a97afdf7c Gerrit-Change-Number: 30582 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: gsm0808: add logging for some IE encoding errors

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/30581 ) Change subject: gsm0808: add logging for some IE encoding errors ...................................................................... gsm0808: add logging for some IE encoding errors Change-Id: Idd9c490e7a2d37817004590629092c4bb6f2d758 Related: SYS#6229 --- M src/gsm/gsm0808.c 1 file changed, 50 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/30581/1 diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index ec4c39b..3757c4e 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -21,6 +21,8 @@ #include <osmocom/core/byteswap.h> #include <osmocom/core/endian.h> +#include <osmocom/core/logging.h> + #include <osmocom/gsm/gsm0808.h> #include <osmocom/gsm/gsm0808_lcs.h> #include <osmocom/gsm/gsm0808_utils.h> @@ -101,8 +103,11 @@ /* AoIP: add Codec List (BSS Supported) 3.2.2.103 */ if (scl) { - if (gsm0808_enc_speech_codec_list2(msg, scl) < 0) + if (gsm0808_enc_speech_codec_list2(msg, scl) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Codec List (BSS Supported) IE\n"); goto exit_free; + } } /* push the bssmap header */ @@ -537,8 +542,11 @@ /* AoIP: Codec List (MSC Preferred) 3.2.2.103 */ if (scl) { - if (gsm0808_enc_speech_codec_list2(msg, scl) < 0) + if (gsm0808_enc_speech_codec_list2(msg, scl) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Codec List (MSC Preferred) IE\n"); goto exit_free; + } } /* AoIP: Call Identifier 3.2.2.105 */ @@ -629,14 +637,20 @@ /* AoIP: Speech Codec (Chosen) 3.2.2.104 */ if (sc) { - if (gsm0808_enc_speech_codec2(msg, sc) < 0) + if (gsm0808_enc_speech_codec2(msg, sc) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Speech Codec (Chosen) IE\n"); goto exit_free; + } } /* AoIP: add Codec List (BSS Supported) 3.2.2.103 */ if (scl) { - if (gsm0808_enc_speech_codec_list2(msg, scl) < 0) + if (gsm0808_enc_speech_codec_list2(msg, scl) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Codec List (BSS Supported) IE\n"); goto exit_free; + } } /* FIXME: write LSA identifier 3.2.2.15 - see 3GPP TS 43.073 */ @@ -714,8 +728,11 @@ /* AoIP: add Codec List (BSS Supported) 3.2.2.103 */ if (scl) { - if (gsm0808_enc_speech_codec_list2(msg, scl) < 0) + if (gsm0808_enc_speech_codec_list2(msg, scl) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Codec List (BSS Supported) IE\n"); goto exit_free; + } } /* update the size */ @@ -1019,8 +1036,11 @@ gsm0808_enc_aoip_trasp_addr(msg, params->aoip_transport_layer); if (params->codec_list_msc_preferred) { - if (gsm0808_enc_speech_codec_list2(msg, params->codec_list_msc_preferred) < 0) + if (gsm0808_enc_speech_codec_list2(msg, params->codec_list_msc_preferred) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Codec List (MSC Preferred) IE\n"); goto exit_free; + } } if (params->call_id_present) { @@ -1081,14 +1101,20 @@ * (codec_list_bss_supported was added to struct gsm0808_handover_request_ack later than speech_codec_chosen * below, but it needs to come before it in the message coding). */ if (params->more_items && params->codec_list_bss_supported.len) { - if (gsm0808_enc_speech_codec_list2(msg, &params->codec_list_bss_supported) < 0) + if (gsm0808_enc_speech_codec_list2(msg, &params->codec_list_bss_supported) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Codec List (BSS Supported) IE\n"); goto exit_free; + } } /* AoIP: Speech Codec (Chosen) 3.2.2.104 */ if (params->speech_codec_chosen_present) { - if (gsm0808_enc_speech_codec2(msg, &params->speech_codec_chosen) < 0) + if (gsm0808_enc_speech_codec2(msg, &params->speech_codec_chosen) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Speech Codec (Chosen) IE\n"); goto exit_free; + } } /* prepend header with final length */ @@ -1205,14 +1231,20 @@ /* AoIP: Speech Codec (Chosen) 3.2.2.104 */ if (params->speech_codec_chosen_present) { - if (gsm0808_enc_speech_codec2(msg, &params->speech_codec_chosen) < 0) + if (gsm0808_enc_speech_codec2(msg, &params->speech_codec_chosen) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Speech Codec (Chosen) IE\n"); goto exit_free; + } } /* AoIP: add Codec List (BSS Supported) 3.2.2.103 */ if (params->codec_list_bss_supported.len) { - if (gsm0808_enc_speech_codec_list2(msg, &params->codec_list_bss_supported) < 0) + if (gsm0808_enc_speech_codec_list2(msg, &params->codec_list_bss_supported) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Codec List (BSS Supported) IE\n"); goto exit_free; + } } /* Chosen Encryption Algorithm 3.2.2.44 */ @@ -1255,8 +1287,11 @@ /* AoIP: add Codec List (BSS Supported) 3.2.2.103 */ if (params->codec_list_bss_supported.len) { - if (gsm0808_enc_speech_codec_list2(msg, &params->codec_list_bss_supported) < 0) + if (gsm0808_enc_speech_codec_list2(msg, &params->codec_list_bss_supported) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Codec List (BSS Supported) IE\n"); goto exit_free; + } } /* prepend header with final length */ @@ -1303,8 +1338,11 @@ /* AoIP: Speech Codec (chosen) 3.2.2.104 */ if (params->speech_codec_chosen_present) { - if (gsm0808_enc_speech_codec2(msg, &params->speech_codec_chosen) < 0) + if (gsm0808_enc_speech_codec2(msg, &params->speech_codec_chosen) < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, + "Failed to encode Speech Codec (Chosen) IE\n"); goto exit_free; + } } /* LCLS-BSS-Status 3.2.2.119 */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idd9c490e7a2d37817004590629092c4bb6f2d758 Gerrit-Change-Number: 30581 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: gsm0808: cosmetic: switch is not a function

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30576 ) Change subject: gsm0808: cosmetic: switch is not a function ...................................................................... gsm0808: cosmetic: switch is not a function Change-Id: I2f58711675c5c9511c4f4fe4bf0d6e6f7dd093b1 --- M src/gsm/gsm0808_utils.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c index f1569c9..80d469e 100644 --- a/src/gsm/gsm0808_utils.c +++ b/src/gsm/gsm0808_utils.c @@ -227,7 +227,7 @@ * of 4 bit to fully specify the selected codec. In the following, * we check if we work with an extended type or not. We also check * if the codec type is valid at all. */ - switch(sc->type) { + switch (sc->type) { case GSM0808_SCT_FR1: case GSM0808_SCT_FR2: case GSM0808_SCT_FR3: -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f58711675c5c9511c4f4fe4bf0d6e6f7dd093b1 Gerrit-Change-Number: 30576 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: gsm0808: remove unneeded assignment in enc_speech_codec()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30577 ) Change subject: gsm0808: remove unneeded assignment in enc_speech_codec() ...................................................................... gsm0808: remove unneeded assignment in enc_speech_codec() Change-Id: Ifc6d109e27cdada0d08d2a8fc1c354f3de04f15c --- M src/gsm/gsm0808_utils.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c index 80d469e..026a923 100644 --- a/src/gsm/gsm0808_utils.c +++ b/src/gsm/gsm0808_utils.c @@ -221,7 +221,7 @@ /* See also 3GPP TS 48.008 3.2.2.103 Speech Codec List */ uint8_t header = 0; uint8_t *old_tail; - bool type_extended = false; + bool type_extended; /* Note: Extended codec types are codec types that require 8 instead * of 4 bit to fully specify the selected codec. In the following, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifc6d109e27cdada0d08d2a8fc1c354f3de04f15c Gerrit-Change-Number: 30577 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: gsm0808: remove redundant assert() in enc_speech_codec()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30578 ) Change subject: gsm0808: remove redundant assert() in enc_speech_codec() ...................................................................... gsm0808: remove redundant assert() in enc_speech_codec() This assert can be dropped because the switch statement above does not leave any sc->type >= 0x0f for type_extended == false. Change-Id: Iafb45ed66378f2c9c2480f81371e92c6d1da71a7 --- M src/gsm/gsm0808_utils.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c index 026a923..5b7fff2 100644 --- a/src/gsm/gsm0808_utils.c +++ b/src/gsm/gsm0808_utils.c @@ -264,7 +264,6 @@ msgb_put_u8(msg, header); msgb_put_u8(msg, sc->type); } else { - OSMO_ASSERT(sc->type < 0x0f); header |= sc->type; msgb_put_u8(msg, header); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iafb45ed66378f2c9c2480f81371e92c6d1da71a7 Gerrit-Change-Number: 30578 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: gsm0808: use new gsm0808_enc_speech_codec[_list]2() API

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30580 ) Change subject: gsm0808: use new gsm0808_enc_speech_codec[_list]2() API ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I28219b61b9347f0652f9fd0c717f6cdf3c63e8f9 Gerrit-Change-Number: 30580 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Dec 2022 20:57:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: gsm0808: add gsm0808_enc_speech_codec[_list]2()

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30574 ) Change subject: gsm0808: add gsm0808_enc_speech_codec[_list]2() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I199ffa0ba4a64813238519178155dfc767aa3975 Gerrit-Change-Number: 30574 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Dec 2022 20:57:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022