November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: osmux: Support recreating lost RTP packets at start of the batch

by laforge

Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30197 ) Change subject: osmux: Support recreating lost RTP packets at start of the batch ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS3: > typo in commit message: th M Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3 Gerrit-Change-Number: 30197 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 09:05:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts

by laforge

Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30196 ) Change subject: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30196/comment/0e45a0f4_b039fd30 PS3, Line 156: ((state->circuit->last_transmitted_rtp_seq + 1) & 0xffff) != rtp_seqnum; > sequence numbers are uint16_t in RTP. […] I guess max was indirectly saying "use UINT16_MAX" (probably just because it ends in his name). More seriously, I don't think we need to worry about 0xffff being considered a magic number. To me it's more obvious than UINT16_MAX. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I05b1eae400cb60d1f4e927f853619d5ff470163f Gerrit-Change-Number: 30196 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 09:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Obey current batch_size restrictions when creating forged RTP ...

by laforge

Attention is currently required from: pespin, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30174 ) Change subject: osmux: Obey current batch_size restrictions when creating forged RTP packets to fill holes ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4ea435bfb2490a375ad3e5068ee926e48b53cf5c Gerrit-Change-Number: 30174 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 09:03:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: cosmetic: rename upf_gtp_dev_tunnel_* to upf_gtp_dev_tunend_*

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30237 ) Change subject: cosmetic: rename upf_gtp_dev_tunnel_* to upf_gtp_dev_tunend_* ...................................................................... cosmetic: rename upf_gtp_dev_tunnel_* to upf_gtp_dev_tunend_* Change-Id: I73e7b3c4841520909185aaba3ec41c6cf1e3ff51 --- M include/osmocom/upf/upf_gtp.h M src/osmo-upf/up_gtp_action.c M src/osmo-upf/upf_gtp.c 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/upf/upf_gtp.h b/include/osmocom/upf/upf_gtp.h index c553730..77ea623 100644 --- a/include/osmocom/upf/upf_gtp.h +++ b/include/osmocom/upf/upf_gtp.h @@ -77,8 +77,8 @@ struct upf_gtp_dev *upf_gtp_dev_find_by_name(const char *name); struct upf_gtp_dev *upf_gtp_dev_first(); -int upf_gtp_dev_tunnel_add(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); -int upf_gtp_dev_tunnel_del(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); +int upf_gtp_dev_tunend_add(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); +int upf_gtp_dev_tunend_del(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); int upf_gtp_dev_to_str_buf(char *buf, size_t buflen, const struct upf_gtp_dev *dev); char *upf_gtp_dev_to_str_c(void *ctx, const struct upf_gtp_dev *dev); diff --git a/src/osmo-upf/up_gtp_action.c b/src/osmo-upf/up_gtp_action.c index 2471a61..81b74b3 100644 --- a/src/osmo-upf/up_gtp_action.c +++ b/src/osmo-upf/up_gtp_action.c @@ -99,9 +99,9 @@ } if (enable) - rc = upf_gtp_dev_tunnel_add(gtp_dev, &a->tunend); + rc = upf_gtp_dev_tunend_add(gtp_dev, &a->tunend); else - rc = upf_gtp_dev_tunnel_del(gtp_dev, &a->tunend); + rc = upf_gtp_dev_tunend_del(gtp_dev, &a->tunend); if (rc) { LOG_UP_GTP_ACTION(a, LOGL_ERROR, "Failed to %s GTP tunnel: %d %s\n", enable ? "enable" : "disable", rc, strerror(-rc)); diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 6794a25..ae1eaf0 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -381,7 +381,7 @@ return rc; } -static struct upf_gtp_tunend *upf_gtp_dev_tunnel_find(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) +static struct upf_gtp_tunend *upf_gtp_dev_tunend_find(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) { struct upf_gtp_tunend *tun; llist_for_each_entry(tun, &dev->tunnels, entry) { @@ -392,10 +392,10 @@ return NULL; } -int upf_gtp_dev_tunnel_add(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) +int upf_gtp_dev_tunend_add(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) { struct upf_gtp_tunend *tun; - tun = upf_gtp_dev_tunnel_find(dev, tun_desc); + tun = upf_gtp_dev_tunend_find(dev, tun_desc); if (!tun) tun = upf_gtp_tunend_alloc(dev, tun_desc); if (tun->active) @@ -403,11 +403,11 @@ return upf_gtp_tunend_activate(tun); } -int upf_gtp_dev_tunnel_del(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) +int upf_gtp_dev_tunend_del(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) { struct upf_gtp_tunend *tun; int rc; - tun = upf_gtp_dev_tunnel_find(dev, tun_desc); + tun = upf_gtp_dev_tunend_find(dev, tun_desc); if (!tun) return 0; if (tun->active) { -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I73e7b3c4841520909185aaba3ec41c6cf1e3ff51 Gerrit-Change-Number: 30237 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: cosmetic: rename upf_gtp_tun to upf_gtp_tunend

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30235 ) Change subject: cosmetic: rename upf_gtp_tun to upf_gtp_tunend ...................................................................... cosmetic: rename upf_gtp_tun to upf_gtp_tunend Change-Id: I0815012679237838a031e28c0afb98b7e0d184bd --- M include/osmocom/upf/up_gtp_action.h M include/osmocom/upf/upf_gtp.h M src/osmo-upf/upf_gtp.c 3 files changed, 37 insertions(+), 37 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/upf/up_gtp_action.h b/include/osmocom/upf/up_gtp_action.h index 5b4d5ee..8e291b7 100644 --- a/include/osmocom/upf/up_gtp_action.h +++ b/include/osmocom/upf/up_gtp_action.h @@ -54,7 +54,7 @@ enum up_gtp_action_kind kind; union { /* En-/De-capsulate GTP: add/remove a GTP header and forward the GTP payload from/to plain IP. */ - struct upf_gtp_tun_desc tunend; + struct upf_gtp_tunend_desc tunend; /* Tunnel-map GTP: translate from one TEID to another and forward */ struct upf_nft_tunmap_desc tunmap; diff --git a/include/osmocom/upf/upf_gtp.h b/include/osmocom/upf/upf_gtp.h index 1e0df5e..ec0046d 100644 --- a/include/osmocom/upf/upf_gtp.h +++ b/include/osmocom/upf/upf_gtp.h @@ -60,14 +60,14 @@ struct llist_head tunnels; }; -struct upf_gtp_tun_desc { +struct upf_gtp_tunend_desc { uint32_t local_teid; uint32_t remote_teid; struct osmo_sockaddr ue_addr; struct osmo_sockaddr gtp_remote_addr; }; -int upf_gtp_tun_desc_cmp(const struct upf_gtp_tun_desc *a, const struct upf_gtp_tun_desc *b); +int upf_gtp_tunend_desc_cmp(const struct upf_gtp_tunend_desc *a, const struct upf_gtp_tunend_desc *b); int upf_gtp_genl_ensure_open(); void upf_gtp_genl_close(); @@ -77,9 +77,9 @@ struct upf_gtp_dev *upf_gtp_dev_find_by_name(const char *name); struct upf_gtp_dev *upf_gtp_dev_first(); -int upf_gtp_dev_tunnel_add(struct upf_gtp_dev *dev, const struct upf_gtp_tun_desc *t); -bool upf_gtp_dev_is_tunnel_active(struct upf_gtp_dev *dev, const struct upf_gtp_tun_desc *t); -int upf_gtp_dev_tunnel_del(struct upf_gtp_dev *dev, const struct upf_gtp_tun_desc *t); +int upf_gtp_dev_tunnel_add(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); +bool upf_gtp_dev_is_tunnel_active(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); +int upf_gtp_dev_tunnel_del(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); int upf_gtp_dev_to_str_buf(char *buf, size_t buflen, const struct upf_gtp_dev *dev); char *upf_gtp_dev_to_str_c(void *ctx, const struct upf_gtp_dev *dev); diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 880e587..6794a25 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -39,7 +39,7 @@ #include <osmocom/upf/upf_gtpu_echo.h> #define LOG_GTP_TUN(TUN, LEVEL, FMT, ARGS...) \ - LOGP(DGTP, LEVEL, "%s: " FMT, upf_gtp_tun_to_str_c(OTC_SELECT, (TUN)), ##ARGS) + LOGP(DGTP, LEVEL, "%s: " FMT, upf_gtp_tunend_to_str_c(OTC_SELECT, (TUN)), ##ARGS) int upf_gtp_dev_to_str_buf(char *buf, size_t buflen, const struct upf_gtp_dev *dev) { @@ -287,15 +287,15 @@ return 0; } -struct upf_gtp_tun { +struct upf_gtp_tunend { struct llist_head entry; struct upf_gtp_dev *dev; - struct upf_gtp_tun_desc desc; + struct upf_gtp_tunend_desc desc; bool active; }; -static int upf_gtp_tun_to_str_buf(char *buf, size_t buflen, const struct upf_gtp_tun *tun) +static int upf_gtp_tunend_to_str_buf(char *buf, size_t buflen, const struct upf_gtp_tunend *tun) { struct osmo_strbuf sb = { .buf = buf, .len = buflen }; OSMO_STRBUF_PRINTF(sb, "%s:tun{TEID=l:0x%x,r:0x%x UE=", tun->dev->name, tun->desc.local_teid, @@ -307,35 +307,35 @@ return sb.chars_needed; } -static char *upf_gtp_tun_to_str_c(void *ctx, const struct upf_gtp_tun *tun) +static char *upf_gtp_tunend_to_str_c(void *ctx, const struct upf_gtp_tunend *tun) { - OSMO_NAME_C_IMPL(ctx, 64, "ERROR", upf_gtp_tun_to_str_buf, tun) + OSMO_NAME_C_IMPL(ctx, 64, "ERROR", upf_gtp_tunend_to_str_buf, tun) } -static int upf_gtp_tun_deactivate(struct upf_gtp_tun *tun); +static int upf_gtp_tunend_deactivate(struct upf_gtp_tunend *tun); -static int upf_gtp_tun_destruct(struct upf_gtp_tun *tun) +static int upf_gtp_tunend_destruct(struct upf_gtp_tunend *tun) { if (tun->active) - upf_gtp_tun_deactivate(tun); + upf_gtp_tunend_deactivate(tun); llist_del(&tun->entry); return 0; } -static struct upf_gtp_tun *upf_gtp_tun_alloc(struct upf_gtp_dev *dev, const struct upf_gtp_tun_desc *desc) +static struct upf_gtp_tunend *upf_gtp_tunend_alloc(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *desc) { - struct upf_gtp_tun *tun = talloc(dev, struct upf_gtp_tun); + struct upf_gtp_tunend *tun = talloc(dev, struct upf_gtp_tunend); OSMO_ASSERT(tun); - *tun = (struct upf_gtp_tun){ + *tun = (struct upf_gtp_tunend){ .dev = dev, .desc = *desc, }; llist_add(&tun->entry, &dev->tunnels); - talloc_set_destructor(tun, upf_gtp_tun_destruct); + talloc_set_destructor(tun, upf_gtp_tunend_destruct); return tun; } -static struct gtp_tunnel *upf_gtp_tun_to_gtp_tunnel(struct upf_gtp_tun *tun) +static struct gtp_tunnel *upf_gtp_tunend_to_gtp_tunnel(struct upf_gtp_tunend *tun) { struct gtp_tunnel *t; @@ -355,7 +355,7 @@ return t; } -int upf_gtp_tun_activate(struct upf_gtp_tun *tun) +int upf_gtp_tunend_activate(struct upf_gtp_tunend *tun) { int rc; struct gtp_tunnel *t; @@ -363,7 +363,7 @@ if (tun->active) return -EALREADY; - t = upf_gtp_tun_to_gtp_tunnel(tun); + t = upf_gtp_tunend_to_gtp_tunnel(tun); if (!t) return -ENOTSUP; @@ -381,37 +381,37 @@ return rc; } -static struct upf_gtp_tun *upf_gtp_dev_tunnel_find(struct upf_gtp_dev *dev, const struct upf_gtp_tun_desc *tun_desc) +static struct upf_gtp_tunend *upf_gtp_dev_tunnel_find(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) { - struct upf_gtp_tun *tun; + struct upf_gtp_tunend *tun; llist_for_each_entry(tun, &dev->tunnels, entry) { - if (upf_gtp_tun_desc_cmp(tun_desc, &tun->desc)) + if (upf_gtp_tunend_desc_cmp(tun_desc, &tun->desc)) continue; return tun; } return NULL; } -int upf_gtp_dev_tunnel_add(struct upf_gtp_dev *dev, const struct upf_gtp_tun_desc *tun_desc) +int upf_gtp_dev_tunnel_add(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) { - struct upf_gtp_tun *tun; + struct upf_gtp_tunend *tun; tun = upf_gtp_dev_tunnel_find(dev, tun_desc); if (!tun) - tun = upf_gtp_tun_alloc(dev, tun_desc); + tun = upf_gtp_tunend_alloc(dev, tun_desc); if (tun->active) return 0; - return upf_gtp_tun_activate(tun); + return upf_gtp_tunend_activate(tun); } -int upf_gtp_dev_tunnel_del(struct upf_gtp_dev *dev, const struct upf_gtp_tun_desc *tun_desc) +int upf_gtp_dev_tunnel_del(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *tun_desc) { - struct upf_gtp_tun *tun; + struct upf_gtp_tunend *tun; int rc; tun = upf_gtp_dev_tunnel_find(dev, tun_desc); if (!tun) return 0; if (tun->active) { - rc = upf_gtp_tun_deactivate(tun); + rc = upf_gtp_tunend_deactivate(tun); if (rc) return rc; } @@ -419,7 +419,7 @@ return 0; } -static int upf_gtp_tun_deactivate(struct upf_gtp_tun *tun) +static int upf_gtp_tunend_deactivate(struct upf_gtp_tunend *tun) { int rc; struct gtp_tunnel *t; @@ -429,7 +429,7 @@ return -EINVAL; } - t = upf_gtp_tun_to_gtp_tunnel(tun); + t = upf_gtp_tunend_to_gtp_tunnel(tun); if (!t) return -EINVAL; @@ -445,9 +445,9 @@ static int upf_gtp_dev_destruct(struct upf_gtp_dev *dev) { - struct upf_gtp_tun *t; + struct upf_gtp_tunend *t; /* Destruct and clean up all active tunnels before deleting the device */ - while ((t = llist_first_entry_or_null(&dev->tunnels, struct upf_gtp_tun, entry))) + while ((t = llist_first_entry_or_null(&dev->tunnels, struct upf_gtp_tunend, entry))) talloc_free(t); llist_del(&dev->entry); /* osmo_fd_close() is a noop if ofd.fd == -1 */ @@ -458,7 +458,7 @@ return 0; } -int upf_gtp_tun_desc_cmp(const struct upf_gtp_tun_desc *a, const struct upf_gtp_tun_desc *b) +int upf_gtp_tunend_desc_cmp(const struct upf_gtp_tunend_desc *a, const struct upf_gtp_tunend_desc *b) { int r; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I0815012679237838a031e28c0afb98b7e0d184bd Gerrit-Change-Number: 30235 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: drop unused upf_gtp_dev_is_tunnel_active()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30236 ) Change subject: drop unused upf_gtp_dev_is_tunnel_active() ...................................................................... drop unused upf_gtp_dev_is_tunnel_active() Change-Id: Ia8517f702118af55ce47a4f63fb08ac5ee284217 --- M include/osmocom/upf/upf_gtp.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/upf/upf_gtp.h b/include/osmocom/upf/upf_gtp.h index ec0046d..c553730 100644 --- a/include/osmocom/upf/upf_gtp.h +++ b/include/osmocom/upf/upf_gtp.h @@ -78,7 +78,6 @@ struct upf_gtp_dev *upf_gtp_dev_first(); int upf_gtp_dev_tunnel_add(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); -bool upf_gtp_dev_is_tunnel_active(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); int upf_gtp_dev_tunnel_del(struct upf_gtp_dev *dev, const struct upf_gtp_tunend_desc *t); int upf_gtp_dev_to_str_buf(char *buf, size_t buflen, const struct upf_gtp_dev *dev); -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia8517f702118af55ce47a4f63fb08ac5ee284217 Gerrit-Change-Number: 30236 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: cosmetic: rename upf_gtp_dev_tunnel_* to upf_gtp_dev_tunend_*

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30237 ) Change subject: cosmetic: rename upf_gtp_dev_tunnel_* to upf_gtp_dev_tunend_* ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I73e7b3c4841520909185aaba3ec41c6cf1e3ff51 Gerrit-Change-Number: 30237 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 09:03:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: drop unused upf_gtp_dev_is_tunnel_active()

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30236 ) Change subject: drop unused upf_gtp_dev_is_tunnel_active() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia8517f702118af55ce47a4f63fb08ac5ee284217 Gerrit-Change-Number: 30236 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 09:02:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: cosmetic: rename upf_gtp_tun to upf_gtp_tunend

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30235 ) Change subject: cosmetic: rename upf_gtp_tun to upf_gtp_tunend ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I0815012679237838a031e28c0afb98b7e0d184bd Gerrit-Change-Number: 30235 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 09:02:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: firmware/sniffer: introduce #define for interrupt enable flags

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30199 ) Change subject: firmware/sniffer: introduce #define for interrupt enable flags ...................................................................... firmware/sniffer: introduce #define for interrupt enable flags Change-Id: Id4bc720a1db31b4433ff7b10d7a57d0ddb7d7180 --- M firmware/libcommon/source/sniffer.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c index 75c140c..35de58f 100644 --- a/firmware/libcommon/source/sniffer.c +++ b/firmware/libcommon/source/sniffer.c @@ -918,6 +918,8 @@ * Initialization routine *-----------------------------------------------------------------------------*/ +#define SNIFFER_IER (US_IER_RXRDY | US_IER_TIMEOUT) + /* Called during USB enumeration after device is enumerated by host */ void Sniffer_configure(void) { @@ -929,7 +931,7 @@ { TRACE_INFO("Sniffer exit\n\r"); /* Disable USART */ - USART_DisableIt(sniff_usart.base, US_IER_RXRDY | US_IER_TIMEOUT); + USART_DisableIt(sniff_usart.base, SNIFFER_IER); /* NOTE: don't forget to set the IRQ according to the USART peripheral used */ NVIC_DisableIRQ(IRQ_USART_SIM); USART_SetReceiverEnabled(sniff_usart.base, 0); @@ -965,7 +967,7 @@ /* Enable Receiver time-out to detect waiting time (WT) time-out (e.g. unresponsive cards) */ sniff_usart.base->US_RTOR = g_wt; /* Enable interrupt to indicate when data has been received or timeout occurred */ - USART_EnableIt(sniff_usart.base, US_IER_RXRDY | US_IER_TIMEOUT); + USART_EnableIt(sniff_usart.base, SNIFFER_IER); /* Set USB priority lower than USART to not miss sniffing data (both at 0 per default) */ if (NVIC_GetPriority(IRQ_USART_SIM) >= NVIC_GetPriority(UDP_IRQn)) { NVIC_SetPriority(UDP_IRQn, NVIC_GetPriority(IRQ_USART_SIM) + 2); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id4bc720a1db31b4433ff7b10d7a57d0ddb7d7180 Gerrit-Change-Number: 30199 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tsaitgaist <kredon(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022