Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30224 )
Change subject: osmux: Check received osmuxh->amr_ft is correct before using it
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Iab525c5b7eb1e455a8229fb39e96897aac53298c
Gerrit-Change-Number: 30224
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 19 Nov 2022 09:07:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30223 )
Change subject: amr: Guard against incorrect AMR FT passed to osmo_amr_{bits,bytes}()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30223
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ib11d4b64c6df19a85c4374fde89e1b56f410e438
Gerrit-Change-Number: 30223
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 19 Nov 2022 09:07:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30195 )
Change subject: osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set
......................................................................
osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set
Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b
---
M src/osmux_input.c
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
msuraev: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/src/osmux_input.c b/src/osmux_input.c
index 6e6b00d..3e6f4b7 100644
--- a/src/osmux_input.c
+++ b/src/osmux_input.c
@@ -435,6 +435,10 @@
int i, rc;
struct osmux_in_req clone_req;
+ /* If M bit is set, this is a sync point, so any sort of seq jump is expected and has no real meaning. */
+ if (req->rtph->marker)
+ return 0;
+
/* Have we seen any RTP packet in this batch before? */
if (llist_empty(&req->circuit->msg_list))
return 0;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b
Gerrit-Change-Number: 30195
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged