November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails
by pespin 24 Nov '22

24 Nov '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30289 ) Change subject: trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I78658a706e5bfda446e3929e33abcdee3f08845b Gerrit-Change-Number: 30289 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 11:07:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): properly parse timeslot number
by pespin 24 Nov '22

24 Nov '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30288 ) Change subject: trxcon: trx_data_rx_cb(): properly parse timeslot number ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30288/comment/970f0158_2c6d2d36 PS1, Line 651: .tn = buf[0] & 0x07, shouldn't you check the buf[0] is < 8 here? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1010cf39f61b8845acce632c19c74df892fc5acb Gerrit-Change-Number: 30288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 11:06:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): properly parse timeslot number
by pespin 24 Nov '22

24 Nov '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30288 ) Change subject: trxcon: trx_data_rx_cb(): properly parse timeslot number ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1010cf39f61b8845acce632c19c74df892fc5acb Gerrit-Change-Number: 30288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 11:05:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: fixup: trxcon: make burst pointer in trxcon_phyif_burst_ind const
by pespin 24 Nov '22

24 Nov '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30287 ) Change subject: fixup: trxcon: make burst pointer in trxcon_phyif_burst_ind const ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I'd simply set/use the 148 beforehand, but anyway, not going to discuss this further. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I93a627233beef9157d47b35cafc42c53203619a7 Gerrit-Change-Number: 30287 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 11:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: hnbgw: Avoid allocating SCCP conn id >0x00fffffe
by pespin 24 Nov '22

24 Nov '22

Attention is currently required from: pespin. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/30283 to look at the new patch set (#2). Change subject: hnbgw: Avoid allocating SCCP conn id >0x00fffffe ...................................................................... hnbgw: Avoid allocating SCCP conn id >0x00fffffe This fixes bug in use of M3UA/SCCP after 2**24 connection IDs have been allocated. Related: SYS#6211 Change-Id: I03bad960f65fbff6e467def5bba60fefb328f962 --- M src/osmo-hnbgw/context_map.c 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/83/30283/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/30283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I03bad960f65fbff6e467def5bba60fefb328f962 Gerrit-Change-Number: 30283 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-abis[master]: ipaccess: update_fd_settings: use LOGL_ERROR
by osmith 24 Nov '22

24 Nov '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30282 ) Change subject: ipaccess: update_fd_settings: use LOGL_ERROR ...................................................................... ipaccess: update_fd_settings: use LOGL_ERROR Use LOGL_ERROR if setsockopt fails, so errors are less likely to go unnoticed. Related: OS#5786 Change-Id: I519a88dce30c01d2ea02cf900b1892497b494e09 --- M src/input/ipaccess.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 3a20967..bde2c12 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -605,7 +605,7 @@ val = 1; ret = setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, &val, sizeof(val)); if (ret < 0) - LOGP(DLINP, LOGL_NOTICE, "Failed to set keepalive: %s\n", + LOGP(DLINP, LOGL_ERROR, "Failed to set keepalive: %s\n", strerror(errno)); else LOGP(DLINP, LOGL_NOTICE, "Keepalive is set: %i\n", ret); @@ -617,7 +617,7 @@ ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPIDLE, &val, sizeof(val)); if (ret < 0) - LOGP(DLINP, LOGL_NOTICE, + LOGP(DLINP, LOGL_ERROR, "Failed to set keepalive idle time: %s\n", strerror(errno)); val = line->keepalive_probe_interval > -1 ? @@ -626,7 +626,7 @@ ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPINTVL, &val, sizeof(val)); if (ret < 0) - LOGP(DLINP, LOGL_NOTICE, + LOGP(DLINP, LOGL_ERROR, "Failed to set keepalive interval: %s\n", strerror(errno)); val = line->keepalive_num_probes > 0 ? @@ -635,7 +635,7 @@ ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPCNT, &val, sizeof(val)); if (ret < 0) - LOGP(DLINP, LOGL_NOTICE, + LOGP(DLINP, LOGL_ERROR, "Failed to set keepalive count: %s\n", strerror(errno)); val = 1000 * line->keepalive_num_probes * @@ -644,7 +644,7 @@ ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, &val, sizeof(val)); if (ret < 0) - LOGP(DLINP, LOGL_NOTICE, + LOGP(DLINP, LOGL_ERROR, "Failed to set user timoeut: %s\n", strerror(errno)); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I519a88dce30c01d2ea02cf900b1892497b494e09 Gerrit-Change-Number: 30282 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-abis[master]: e1_input: enable tcp keepalive by default
by osmith 24 Nov '22

24 Nov '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30280 ) Change subject: e1_input: enable tcp keepalive by default ...................................................................... e1_input: enable tcp keepalive by default Set the keepalive parameters to E1INP_USE_DEFAULT initially instead of 0. Do this independent of the driver (the only driver making use of this is ipaccess). Closes: OS#5785 Change-Id: Ia7659c209aea0d26eb37d31e771adc91b17ae668 --- M src/e1_input.c M src/e1_input_vty.c 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/e1_input.c b/src/e1_input.c index 6507835..ee529cc 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -506,6 +506,10 @@ line->num = e1_nr; line->pcap_fd = -1; + line->keepalive_idle_timeout = E1INP_USE_DEFAULT; + line->keepalive_num_probes = E1INP_USE_DEFAULT; + line->keepalive_probe_interval = E1INP_USE_DEFAULT; + line->rate_ctr = rate_ctr_group_alloc(line, &e1inp_ctr_g_d, line->num); if (!line->rate_ctr) { LOGPIL(line, DLINP, LOGL_ERROR, "Cannot allocate counter group\n"); diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c index af30ed9..f6781d1 100644 --- a/src/e1_input_vty.c +++ b/src/e1_input_vty.c @@ -379,12 +379,9 @@ if (!line->keepalive_num_probes) vty_out(vty, " no e1_line %u keepalive%s", line->num, VTY_NEWLINE); - else if (line->keepalive_idle_timeout == E1INP_USE_DEFAULT && - line->keepalive_num_probes == E1INP_USE_DEFAULT && - line->keepalive_probe_interval == E1INP_USE_DEFAULT) - vty_out(vty, " e1_line %u keepalive%s", line->num, - VTY_NEWLINE); - else + else if (line->keepalive_idle_timeout != E1INP_USE_DEFAULT || + line->keepalive_num_probes != E1INP_USE_DEFAULT || + line->keepalive_probe_interval != E1INP_USE_DEFAULT) vty_out(vty, " e1_line %u keepalive %d %d %d%s", line->num, line->keepalive_idle_timeout, -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia7659c209aea0d26eb37d31e771adc91b17ae668 Gerrit-Change-Number: 30280 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-abis[master]: ipaccess: require tcp keepalive related defines
by osmith 24 Nov '22

24 Nov '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30281 ) Change subject: ipaccess: require tcp keepalive related defines ...................................................................... ipaccess: require tcp keepalive related defines Fail the compilation if TCP_KEEPIDLE, TCP_KEEPINTVL, TCP_KEEPCNT or TCP_USER_TIMEOUT are not defined. Harald wrote: > What we want to prevent is the user configuring timeouts, assuming > they would be installed into the kernel TCP stack, which then simply > end up no-ops becaus somehow the libc didn't define them or the right > #include file was not present at compile time. > > [...] Apparently TCP_KEEP{IDLE,INTVL,CNT} were introduced with kernel > 2.4 and TCP_USER_TIMEOUT with 2.6.37. I think it's fair to say that > using a modern/master libosmo-* on such old systems might fail for > various other reasons (eventfd, ...) and cannot be considered a valid > configuration anyway. Closes: OS#5786 Change-Id: Idc0ff1ff02ce4b994692d8213c14c0b2caad756e --- M src/input/ipaccess.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 42dd942..3a20967 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -610,7 +610,6 @@ else LOGP(DLINP, LOGL_NOTICE, "Keepalive is set: %i\n", ret); -#if defined(TCP_KEEPIDLE) && defined(TCP_KEEPINTVL) && defined(TCP_KEEPCNT) /* The following options are not portable! */ val = line->keepalive_idle_timeout > 0 ? line->keepalive_idle_timeout : @@ -639,7 +638,6 @@ LOGP(DLINP, LOGL_NOTICE, "Failed to set keepalive count: %s\n", strerror(errno)); -#if defined(TCP_USER_TIMEOUT) val = 1000 * line->keepalive_num_probes * line->keepalive_probe_interval + line->keepalive_idle_timeout; @@ -649,8 +647,6 @@ LOGP(DLINP, LOGL_NOTICE, "Failed to set user timoeut: %s\n", strerror(errno)); -#endif -#endif } val = 1; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idc0ff1ff02ce4b994692d8213c14c0b2caad756e Gerrit-Change-Number: 30281 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): support parsing 8-PSK modulated bursts
by fixeria 24 Nov '22

24 Nov '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30291 ) Change subject: trxcon: trx_data_rx_cb(): support parsing 8-PSK modulated bursts ...................................................................... trxcon: trx_data_rx_cb(): support parsing 8-PSK modulated bursts Change-Id: I78b1a79c329299ab65eb339e9447a47382983cd9 --- M src/host/trxcon/src/trx_if.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/91/30291/1 diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index c938fc0..078f71b 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -43,6 +43,9 @@ #include <osmocom/bb/trxcon/trx_if.h> #include <osmocom/bb/trxcon/logging.h> +#define TRXDv0_HDR_LEN 8 +#define GMSK_BURST_LEN 148 + #define S(x) (1 << (x)) static void trx_fsm_cleanup_cb(struct osmo_fsm_inst *fi, @@ -642,7 +645,7 @@ return read_len; } - if (read_len < (8 + 148)) { /* TRXDv0 header + GMSK burst */ + if (read_len < (TRXDv0_HDR_LEN + GMSK_BURST_LEN)) { LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, "Got data message with invalid length '%zd'\n", read_len); return -EINVAL; @@ -661,8 +664,8 @@ .fn = osmo_load32be(buf + 1), .rssi = -(int8_t) buf[5], .toa256 = (int16_t) (buf[6] << 8) | buf[7], - .burst = burst, - .burst_len = 148, + .burst = burst, /* at least GMSK_BURST_LEN */ + .burst_len = read_len - TRXDv0_HDR_LEN, }; /* Convert ubits {254..0} to sbits {-127..127} in-place */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I78b1a79c329299ab65eb339e9447a47382983cd9 Gerrit-Change-Number: 30291 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails
by fixeria 24 Nov '22

24 Nov '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30289 ) Change subject: trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails ...................................................................... trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails Change-Id: I78658a706e5bfda446e3929e33abcdee3f08845b --- M src/host/trxcon/src/trx_if.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/89/30289/1 diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index 06f0a07..c8e7a93 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -635,7 +635,10 @@ read_len = read(ofd->fd, buf, sizeof(buf)); if (read_len <= 0) { - LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, "read() failed with rc=%zd\n", read_len); + strerror_r(errno, (char *)buf, sizeof(buf)); + LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, + "read() failed on TRXD with rc=%zd (%s)\n", + read_len, (const char *)buf); return read_len; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I78658a706e5bfda446e3929e33abcdee3f08845b Gerrit-Change-Number: 30289 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2025

2024

2023

2022

gerrit-log November 2022