November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: paging: Fix regression stopping active requests on unanswered BTS

by pespin

Attention is currently required from: fixeria. pespin has removed Jenkins Builder from this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30298 ) Change subject: paging: Fix regression stopping active requests on unanswered BTS ...................................................................... Removed reviewer Jenkins Builder with the following votes: * Verified+1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c6828f86b7ccbb2c4a09ca1aec859a2c597b679 Gerrit-Change-Number: 30298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteReviewer

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: paging: constify bts param in some functions

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30295 ) Change subject: paging: constify bts param in some functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icb85fecba142151b05f289adae8894cd50396224 Gerrit-Change-Number: 30295 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 17:50:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: paging: Fix regression stopping active requests on unanswered BTS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30298 ) Change subject: paging: Fix regression stopping active requests on unanswered BTS ...................................................................... paging: Fix regression stopping active requests on unanswered BTS When rewriting the loop, the pointer passed all the time to paging_remove_request() was the one of the BTS which answered the request, not the one actually handling the related unanwared still active paging request. Fixes: 70a1d60a836431eb64367a0d08b95d43a42ea37c Related: SYS#6200 Change-Id: I8c6828f86b7ccbb2c4a09ca1aec859a2c597b679 --- M src/osmo-bsc/paging.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/98/30298/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 27162d6..b9f2e54 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -567,7 +567,7 @@ struct gsm_paging_request *req; req = llist_first_entry(&bsub->active_paging_requests, struct gsm_paging_request, bsub_entry); - LOG_PAGING_BTS(req, bts, DPAG, LOGL_DEBUG, "Stop paging\n"); + LOG_PAGING_BTS(req, req->bts, DPAG, LOGL_DEBUG, "Stop paging\n"); reasons |= req->reason; if (!paged_from_msc) { /* If this happened, it would be a bit weird: it means there was no Paging Request @@ -575,7 +575,7 @@ * pending on a different BTS. But why not return an MSC when we found one. */ paged_from_msc = req->msc; } - paging_remove_request(&bts->paging, req); + paging_remove_request(&req->bts->paging, req); remaining--; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c6828f86b7ccbb2c4a09ca1aec859a2c597b679 Gerrit-Change-Number: 30298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: paging: paging: Drop unneeded extra param in paging_remove_request()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30299 ) Change subject: paging: paging: Drop unneeded extra param in paging_remove_request() ...................................................................... paging: paging: Drop unneeded extra param in paging_remove_request() The BTS can be obtained easily from the backpointer in req->bts. Having the extra param can only lead to confusion and introduction of bugs, as happened in bug fixed by Change-Id I8c6828f86b7ccbb2c4a09ca1aec859a2c597b679. Related: SYS#6200 Change-Id: I545fd853fdffce7f23f0d99203c66c3b39144e4b --- M src/osmo-bsc/paging.c 1 file changed, 18 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/30299/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index b9f2e54..0395c14 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -83,17 +83,20 @@ /* * Kill one paging request update the internal list... */ -static void paging_remove_request(struct gsm_bts_paging_state *paging_bts, - struct gsm_paging_request *to_be_deleted) +static void paging_remove_request(struct gsm_paging_request *req) { - osmo_timer_del(&to_be_deleted->T3113); - llist_del(&to_be_deleted->entry); - paging_bts->pending_requests_len--; - osmo_stat_item_dec(osmo_stat_item_group_get_item(to_be_deleted->bts->bts_statg, BTS_STAT_PAGING_REQ_QUEUE_LENGTH), 1); - bsc_subscr_remove_active_paging_request(to_be_deleted->bsub, to_be_deleted); - talloc_free(to_be_deleted); - if (llist_empty(&paging_bts->pending_requests)) - osmo_timer_del(&paging_bts->work_timer); + struct gsm_bts *bts = req->bts; + struct gsm_bts_paging_state *bts_pag_st = &bts->paging; + + osmo_timer_del(&req->T3113); + llist_del(&req->entry); + bts_pag_st->pending_requests_len--; + osmo_stat_item_dec(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_PAGING_REQ_QUEUE_LENGTH), 1); + bsc_subscr_remove_active_paging_request(req->bsub, req); + talloc_free(req); + + if (llist_empty(&bts_pag_st->pending_requests)) + osmo_timer_del(&bts_pag_st->work_timer); } static void page_ms(struct gsm_paging_request *request) @@ -342,7 +345,7 @@ rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->bsc_ctrs, BSC_CTR_PAGING_EXPIRED)); /* destroy it now. Do not access req afterwards */ - paging_remove_request(&req->bts->paging, req); + paging_remove_request(req); log_set_context(LOG_CTX_BSC_SUBSCR, NULL); } @@ -559,7 +562,7 @@ LOG_PAGING_BTS(req, bts, DPAG, LOGL_DEBUG, "Stop paging\n"); rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_PAGING_RESPONDED)); rate_ctr_inc(rate_ctr_group_get_ctr(bts->network->bsc_ctrs, BSC_CTR_PAGING_RESPONDED)); - paging_remove_request(&bts->paging, req); + paging_remove_request(req); remaining--; } @@ -575,7 +578,7 @@ * pending on a different BTS. But why not return an MSC when we found one. */ paged_from_msc = req->msc; } - paging_remove_request(&req->bts->paging, req); + paging_remove_request(req); remaining--; } @@ -604,7 +607,7 @@ continue; } /* No reason to keep the paging, remove it: */ - paging_remove_request(&req->bts->paging, req); + paging_remove_request(req); remaining--; if (remaining == 0) break; @@ -642,7 +645,7 @@ continue; /* now give up the data structure */ LOG_PAGING_BTS(req, bts, DPAG, LOGL_DEBUG, "Stop paging (flush)\n"); - paging_remove_request(&bts->paging, req); + paging_remove_request(req); num_cancelled++; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I545fd853fdffce7f23f0d99203c66c3b39144e4b Gerrit-Change-Number: 30299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: subscriber: Add comment documenting struct type hold in list

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30297 ) Change subject: subscriber: Add comment documenting struct type hold in list ...................................................................... subscriber: Add comment documenting struct type hold in list Change-Id: I7246c787fe8fd8b7a36748f0059c0d5789af3ca0 --- M include/osmocom/bsc/bsc_subscriber.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/30297/1 diff --git a/include/osmocom/bsc/bsc_subscriber.h b/include/osmocom/bsc/bsc_subscriber.h index 47a3554..30b33dc 100644 --- a/include/osmocom/bsc/bsc_subscriber.h +++ b/include/osmocom/bsc/bsc_subscriber.h @@ -19,6 +19,7 @@ char imsi[GSM23003_IMSI_MAX_DIGITS+1]; uint32_t tmsi; + /* List head of (struct gsm_paging_request).bsub_entry */ uint32_t active_paging_requests_len; struct llist_head active_paging_requests; }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7246c787fe8fd8b7a36748f0059c0d5789af3ca0 Gerrit-Change-Number: 30297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: subscriber: constify bsub func param

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30296 ) Change subject: subscriber: constify bsub func param ...................................................................... subscriber: constify bsub func param Change-Id: I8603162abf9df71f94aa1549ea449f29ecd73b6d --- M include/osmocom/bsc/bsc_subscriber.h M src/osmo-bsc/bsc_subscriber.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/30296/1 diff --git a/include/osmocom/bsc/bsc_subscriber.h b/include/osmocom/bsc/bsc_subscriber.h index 32f589e..47a3554 100644 --- a/include/osmocom/bsc/bsc_subscriber.h +++ b/include/osmocom/bsc/bsc_subscriber.h @@ -58,4 +58,4 @@ void bsc_subscr_add_active_paging_request(struct bsc_subscr *bsub, struct gsm_paging_request *req); void bsc_subscr_remove_active_paging_request(struct bsc_subscr *bsub, struct gsm_paging_request *req); void bsc_subscr_remove_active_paging_request_all(struct bsc_subscr *bsub); -struct gsm_paging_request *bsc_subscr_find_req_by_bts(struct bsc_subscr *bsub, const struct gsm_bts *bts); +struct gsm_paging_request *bsc_subscr_find_req_by_bts(const struct bsc_subscr *bsub, const struct gsm_bts *bts); diff --git a/src/osmo-bsc/bsc_subscriber.c b/src/osmo-bsc/bsc_subscriber.c index 6589142..15dc14f 100644 --- a/src/osmo-bsc/bsc_subscriber.c +++ b/src/osmo-bsc/bsc_subscriber.c @@ -278,7 +278,7 @@ } } -struct gsm_paging_request *bsc_subscr_find_req_by_bts(struct bsc_subscr *bsub, const struct gsm_bts *bts) +struct gsm_paging_request *bsc_subscr_find_req_by_bts(const struct bsc_subscr *bsub, const struct gsm_bts *bts) { struct gsm_paging_request *req; llist_for_each_entry(req, &bsub->active_paging_requests, bsub_entry) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8603162abf9df71f94aa1549ea449f29ecd73b6d Gerrit-Change-Number: 30296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: paging: constify bts param in some functions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30295 ) Change subject: paging: constify bts param in some functions ...................................................................... paging: constify bts param in some functions Related: libosmocore.git Change-Id Ib11bfe57f546a5618f70152b9b75115808e54bf6 Change-Id: Icb85fecba142151b05f289adae8894cd50396224 --- M include/osmocom/bsc/paging.h M src/osmo-bsc/paging.c 2 files changed, 15 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/30295/1 diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h index ccee2d4..720ee1c 100644 --- a/include/osmocom/bsc/paging.h +++ b/include/osmocom/bsc/paging.h @@ -135,12 +135,12 @@ void paging_update_buffer_space(struct gsm_bts *bts, uint16_t); /* pending paging requests */ -unsigned int paging_pending_requests_nr(struct gsm_bts *bts); +unsigned int paging_pending_requests_nr(const struct gsm_bts *bts); void paging_flush_bts(struct gsm_bts *bts, struct bsc_msc_data *msc); void paging_flush_network(struct gsm_network *net, struct bsc_msc_data *msc); -uint16_t paging_estimate_available_slots(struct gsm_bts *bts, unsigned int time_span_s); +uint16_t paging_estimate_available_slots(const struct gsm_bts *bts, unsigned int time_span_s); int bsc_paging_start(struct bsc_paging_params *params); #endif diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index c7a93d0..27162d6 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -626,7 +626,7 @@ } /*! Count the number of pending paging requests on given BTS */ -unsigned int paging_pending_requests_nr(struct gsm_bts *bts) +unsigned int paging_pending_requests_nr(const struct gsm_bts *bts) { return bts->paging.pending_requests_len; } @@ -658,10 +658,18 @@ paging_flush_bts(bts, msc); } -/*! Estimate available_slots credit over a time period, used when below CCCH Load Indication Threshold */ -uint16_t paging_estimate_available_slots(struct gsm_bts *bts, unsigned int time_span_s) +/* Shim to avoid problems when compiling against libosmocore <= 1.7.0, since + * gsm0502_get_n_pag_blocks() was not declared const despite being readonly. Once + * osmo-bsc depends on libosmocore > 1.7.0, this shim can be dropped. */ +static inline unsigned int _gsm0502_get_n_pag_blocks(const struct gsm48_control_channel_descr *chan_desc) { - unsigned int n_pag_blocks = gsm0502_get_n_pag_blocks(&bts->si_common.chan_desc); + return gsm0502_get_n_pag_blocks((struct gsm48_control_channel_descr *)chan_desc); +} + +/*! Estimate available_slots credit over a time period, used when below CCCH Load Indication Threshold */ +uint16_t paging_estimate_available_slots(const struct gsm_bts *bts, unsigned int time_span_s) +{ + unsigned int n_pag_blocks = _gsm0502_get_n_pag_blocks(&bts->si_common.chan_desc); uint16_t available_slots = n_pag_blocks * time_span_s * 1000000 / GSM51_MFRAME_DURATION_us; LOG_BTS(bts, DPAG, LOGL_DEBUG, "Estimated %u paging available_slots over %u seconds\n", available_slots, time_span_s); @@ -676,7 +684,7 @@ { unsigned int n_pag_blocks, n_mframes, time_us = 0; - n_pag_blocks = gsm0502_get_n_pag_blocks(&bts->si_common.chan_desc); + n_pag_blocks = _gsm0502_get_n_pag_blocks(&bts->si_common.chan_desc); /* First of all, we need to extend the timeout in relation to the amount * of paging requests in the BSC queue. In here we don't care about the -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icb85fecba142151b05f289adae8894cd50396224 Gerrit-Change-Number: 30295 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: gsm: constify several readonly params

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/30294 ) Change subject: gsm: constify several readonly params ...................................................................... gsm: constify several readonly params Change-Id: Ib11bfe57f546a5618f70152b9b75115808e54bf6 --- M include/osmocom/gsm/gsm0502.h M include/osmocom/gsm/gsm48.h M src/gsm/gsm0502.c M src/gsm/gsm48.c 4 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/30294/1 diff --git a/include/osmocom/gsm/gsm0502.h b/include/osmocom/gsm/gsm0502.h index b6a1807..8a8e51a 100644 --- a/include/osmocom/gsm/gsm0502.h +++ b/include/osmocom/gsm/gsm0502.h @@ -33,7 +33,7 @@ /* Table 5 Clause 7 TS 05.02 */ static inline unsigned int -gsm0502_get_n_pag_blocks(struct gsm48_control_channel_descr *chan_desc) +gsm0502_get_n_pag_blocks(const struct gsm48_control_channel_descr *chan_desc) { if (chan_desc->ccch_conf == RSL_BCCH_CCCH_CONF_1_C) return 3 - chan_desc->bs_ag_blks_res; @@ -58,7 +58,7 @@ } unsigned int -gsm0502_calc_paging_group(struct gsm48_control_channel_descr *chan_desc, uint64_t imsi); +gsm0502_calc_paging_group(const struct gsm48_control_channel_descr *chan_desc, uint64_t imsi); enum gsm0502_fn_remap_channel { FN_REMAP_TCH_F, diff --git a/include/osmocom/gsm/gsm48.h b/include/osmocom/gsm/gsm48.h index c1ca630..2a93c5e 100644 --- a/include/osmocom/gsm/gsm48.h +++ b/include/osmocom/gsm/gsm48.h @@ -106,7 +106,7 @@ int gsm48_construct_ra(uint8_t *buf, const struct gprs_ra_id *raid) OSMO_DEPRECATED("Use gsm48_encode_ra() instead"); bool gsm48_ra_equal(const struct gprs_ra_id *raid1, const struct gprs_ra_id *raid2); -int gsm48_number_of_paging_subchannels(struct gsm48_control_channel_descr *chan_desc); +int gsm48_number_of_paging_subchannels(const struct gsm48_control_channel_descr *chan_desc); void gsm48_mcc_mnc_to_bcd(uint8_t *bcd_dst, uint16_t mcc, uint16_t mnc) OSMO_DEPRECATED("Use osmo_plmn_to_bcd() instead, to not lose leading zeros in the MNC"); diff --git a/src/gsm/gsm0502.c b/src/gsm/gsm0502.c index 94db94e..b147406 100644 --- a/src/gsm/gsm0502.c +++ b/src/gsm/gsm0502.c @@ -34,7 +34,7 @@ #include <inttypes.h> unsigned int -gsm0502_calc_paging_group(struct gsm48_control_channel_descr *chan_desc, uint64_t imsi) +gsm0502_calc_paging_group(const struct gsm48_control_channel_descr *chan_desc, uint64_t imsi) { int ccch_conf; int bs_cc_chans; diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 30bba91..c5fe550 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -1361,7 +1361,7 @@ * Uses From Table 10.5.33 of GSM 04.08 to determine the number of * paging sub-channels in the given control channel configuration */ -int gsm48_number_of_paging_subchannels(struct gsm48_control_channel_descr *chan_desc) +int gsm48_number_of_paging_subchannels(const struct gsm48_control_channel_descr *chan_desc) { unsigned int n_pag_blocks = gsm0502_get_n_pag_blocks(chan_desc); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib11bfe57f546a5618f70152b9b75115808e54bf6 Gerrit-Change-Number: 30294 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI

by pespin

pespin has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-pcu/+/30293 ) Change subject: pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI ...................................................................... pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI This patch refactors rcv_resource_request() in several ways: * Move the ID_TYPE=DL/UL_TFI handling at the start of the function, so that the function is split in 2 sections: First section gathers a GprsMS object from the ID_TYPE in the PktResReq. Second section handles the packet for the GprsMS based on the expectd ULC slot. * Initial handling of PktResReq when transmitted by the MS on the UL-TBF as an answer to USF. This case is basically the one where the MS wishes to change some parameters of the currently active UL-TBF. In order to do so, for now simply delete the current TBF and re-create a new one to triger the PktUlAss which is expected by the MS. This behavior is not entirely correct since in this case the MS is expected to keep using actively the old TBF until the PktUlAss is received, so in this case ideally we should be keeping the TBF object and simply upgrading it and using itself to trigger a PktUlAss in its ul_tbf->ul_ass_fsm. Doing this however requires far more work, so it can be done later as an incremental step fix. The current behavior is alreday better than the previous one, since the MS has been tested to be PKT_CTRL_ACKing the PKT_UL_ASS and continuing to use the new TBF. Related: OS#4947 Change-Id: Ie6b1b438d26cd977f88ddb4eff6b3041e0739d92 --- M src/pdch.cpp 1 file changed, 167 insertions(+), 142 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/93/30293/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie6b1b438d26cd977f88ddb4eff6b3041e0739d92 Gerrit-Change-Number: 30293 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30293 ) Change subject: pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI ...................................................................... Patch Set 2: (1 comment) File src/pdch.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1292): https://gerrit.osmocom.org/c/osmo-pcu/+/30293/comment/2fbc4cc1_7031081c PS2, Line 722: * This is requried by spec, and MS are know to continue using the TBF (due to delay in between DL and 'requried' may be misspelled - perhaps 'required'? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie6b1b438d26cd977f88ddb4eff6b3041e0739d92 Gerrit-Change-Number: 30293 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 24 Nov 2022 15:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022