November 2022 - gerrit-log - lists.osmocom.org

Change in simtrace2[master]: Fix missing generation of waiting-time-extension in some situations

by laforge

Attention is currently required from: tsaitgaist. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30093 ) Change subject: Fix missing generation of waiting-time-extension in some situations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ib4eb964c073192e8f067004625af818ba2caf003 Gerrit-Change-Number: 30093 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tsaitgaist <kredon(a)sysmocom.de> Gerrit-CC: jtavares <jtavares(a)kvh.com> Gerrit-Attention: tsaitgaist <kredon(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:57:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by laforge

Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 2: (2 comments) File src/bankd/gsmtap.c: https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/ef0283cc_9cdb2bbb PS2, Line 28: osmo_bankd_gsmtap_init > No problem. […] AFAIR, in simtrace2.git they are actually part of libosmo-simtrace2.so, so they are correctly named as it's public ABI of a shared osmocom library. The question is now whether we'd want to simply link remsim-bankd against libosmo-simtrace2.so rather than copy+pasting the code. Right now only remsim-client links against that library, as it neesd to talk to the actual simtrace2 hardware. Thinking about it, I think we don't want to link the bankd against libosmo-simtrace2, even if it means duplicating some code. If it makes sense all, we might introduce some SIM specific helper function to libosmocore/src/gsmtap.c. https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/b54ab0ae_00feb58b PS2, Line 35: perror("unable to open GSMTAP"); > Will do. […] thanks for pointing this out, that's clearly a bug in libosmo-simtrace2 then. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:50:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: [codecs filter] add trans.cc.codecs

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30117 ) Change subject: [codecs filter] add trans.cc.codecs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib3fdeff8d1e1ea0760168d63ee6e1b1fb993aa5f Gerrit-Change-Number: 30117 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:44:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: add codec_mapping.h,c

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30114 ) Change subject: add codec_mapping.h,c ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/libmsc/codec_mapping.c: https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/3f89f8ed_d64313dc PS1, Line 8: * SPDX-License-Identifier: GPL-2.0+ AGPL-3.0+ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744 Gerrit-Change-Number: 30114 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:43:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: [codecs filter] add codec_filter.h,c

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30116 ) Change subject: [codecs filter] add codec_filter.h,c ...................................................................... Patch Set 1: (2 comments) File src/libmsc/codec_filter.c: https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/d98c65fa_ee81bf79 PS1, Line 8: * SPDX-License-Identifier: GPL-2.0+ > no AGPL? Ack https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/f14d710f_d1c70f9b PS1, Line 28: static void sdp_add_all_mobile_codecs(struct sdp_audio_codecs *ac) > why is this called "mobile_codecs" but the one below is "utran_codecs"? Call this oen geran_codecs? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4d90f7ca62f2307a7b93dd164aeecbf4bd98ff0a Gerrit-Change-Number: 30116 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: add codec_mapping.h,c

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30114 ) Change subject: add codec_mapping.h,c ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libmsc/codec_mapping.c: https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/e90e76da_e2e57647 PS1, Line 29: FIXME: I'm not sure about OFR, OHR -- O means octet-aligned?? > I don't know for sure what the 'O' means, but according to 3GPP TS 45.002, section 3.2. […] in any case, just to be clear: OFR/OHR are not supported in our stack so far. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744 Gerrit-Change-Number: 30114 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:42:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: rtp_stream: set_remote_addr: do nothing when unchanged

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30113 ) Change subject: rtp_stream: set_remote_addr: do nothing when unchanged ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15181d84f3eb8a4ab9077cf12fcb138d51733102 Gerrit-Change-Number: 30113 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:38:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: rtp_stream_commit: check missing MGW ep only when ready for RTP

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30112 ) Change subject: rtp_stream_commit: check missing MGW ep only when ready for RTP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I24a81a926b97c9f0fb31df782d1cf931eaff9db1 Gerrit-Change-Number: 30112 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:38:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30111 ) Change subject: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libmsc/sdp_msg.c: https://gerrit.osmocom.org/c/osmo-msc/+/30111/comment/4309fc95_0ff23a4f PS1, Line 271: if (!sdp_audio_codec_is_set(codec)) > Isn't sdp_audio_codec_is_set() implemented by checking codec->subtype_name[0] like before? what's ch […] the previous code did not check if codec->subtype was a valid pointer at all, and unconditionally dereferenced it. The new code is now checkign for a valid pointer, and whether the first character is non-NUL. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1892efd9360585f98419ebbd0df180f7f3a8160d Gerrit-Change-Number: 30111 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:38:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: sdp_msg.c: parse send/recv mode

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30110 ) Change subject: sdp_msg.c: parse send/recv mode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I529c0bfad1cab376e26173ed48db2767c7dfaa64 Gerrit-Change-Number: 30110 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:36:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022