November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-remsim[master]: remsim-client-st2: Proper error if not all endpoints can be found

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30152 ) Change subject: remsim-client-st2: Proper error if not all endpoints can be found ...................................................................... remsim-client-st2: Proper error if not all endpoints can be found Let's avoid a segfault and rather print a proper error message in case we cannot find all the required USB endpoints when opening the user-specified interface/config/device. This can happen if the device is currently in DFU mode, or a completely wrong device/interface was specified. Before this patch: Assert failed rc == 0 user_simtrace2.c:305 After this patch: DMAIN ERROR user_simtrace2.c:448 specified USB dev/config/interface doesn't have at least one IN, OUT and IRQ_IN endpoint Closes: OS#5416 Change-Id: Icfcc482fff106a232c5125ed8ab463ecc13824ae --- M src/client/user_simtrace2.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/52/30152/1 diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index f71c720..29ab196 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -444,6 +444,12 @@ goto close_exit; } + if (!transp->usb_ep.in || !transp->usb_ep.out || !transp->usb_ep.irq_in) { + LOGP(DMAIN, LOGL_ERROR, "specified USB dev/config/interface doesn't have " + "at least one IN, OUT and IRQ_IN endpoint\n"); + goto close_exit; + } + allocate_and_submit_irq(ci); /* submit multiple IN URB in order to work around OS#4409 */ for (i = 0; i < 4; i++) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icfcc482fff106a232c5125ed8ab463ecc13824ae Gerrit-Change-Number: 30152 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: contrib/jenkins.sh : build and publish combined targets

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/30151 ) Change subject: contrib/jenkins.sh : build and publish combined targets ...................................................................... contrib/jenkins.sh : build and publish combined targets This makes production a bit easier. Change-Id: I32f9a0213aaefa50232a3d8dc2e7a4f2f44dbae1 --- M contrib/jenkins.sh 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/51/30151/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1c2e2ea..c560a0a4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -27,20 +27,21 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -BUILDS="" -BUILDS+="simtrace/dfu simtrace/blupdate simtrace/trace simtrace/cardem " -BUILDS+="qmod/dfu qmod/blupdate qmod/cardem " -BUILDS+="owhw/dfu owhw/blupdate owhw/cardem " -BUILDS+="octsimtest/cardem " -BUILDS+="ngff_cardem/dfu ngff_cardem/blupdate ngff_cardem/cardem ngff_cardem/trace " +# dfu target MUST be built first, the combined targets need a bl that can be combined.. +BUILDS="simtrace/dfu qmod/dfu owhw/dfu ngff_cardem/dfu " +# +BUILDS+="simtrace/blupdate qmod/blupdate owhw/blupdate ngff_cardem/blupdate " +BUILDS+="simtrace/cardem qmod/cardem owhw/cardem octsimtest/cardem ngff_cardem/cardem " +BUILDS+="simtrace/trace ngff_cardem/trace " cd $TOPDIR/firmware for build in $BUILDS; do board=`echo $build | cut -d "/" -f 1` app=`echo $build | cut -d "/" -f 2` + comb="" && [ "$app" != "dfu" ] && [ "$app" != "blupdate" ] && [ "$board" != "octsimtest" ] && comb="combined" echo echo "=============== $board / $app START ==============" - PATH="/opt/llvm-arm/bin:$PATH" make USE_CLANG=1 BOARD="$board" APP="$app" + PATH="/opt/llvm-arm/bin:$PATH" make USE_CLANG=1 BOARD="$board" APP="$app" $comb echo "=============== $board / $app RES:$? ==============" done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32f9a0213aaefa50232a3d8dc2e7a4f2f44dbae1 Gerrit-Change-Number: 30151 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: test-hnbap: fix defined but not used error

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30086 ) Change subject: test-hnbap: fix defined but not used error ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fda405af9d4f1f43377ee0a81710e6e2668da13 Gerrit-Change-Number: 30086 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 22:51:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: tests/hnb-test-rua: fix incompat pointer type

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30085 ) Change subject: tests/hnb-test-rua: fix incompat pointer type ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id930a7f0d3d05cfcc8ba9734dd922de885853c8c Gerrit-Change-Number: 30085 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 22:50:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: ranap_common_cn: rename ctx -> priv

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30143 ) Change subject: ranap_common_cn: rename ctx -> priv ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I929548e9224298be94f7d3ed4cdca0580147721d Gerrit-Change-Number: 30143 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 22:50:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: ranap_common_cn: remove unused ctx args

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30142 ) Change subject: ranap_common_cn: remove unused ctx args ...................................................................... Patch Set 1: (1 comment) File include/osmocom/ranap/ranap_common_cn.h: https://gerrit.osmocom.org/c/osmo-iuh/+/30142/comment/1ca7ce97_9e7a0f20 PS1, Line 23: ranap_cn_rx_co_decode_2 we usually have the "2" suffix in our APIs without the underscore. Not a major problem, just something I'm noticing. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8936197d7ae7ffddbe8ee99d909d74ac5b3ab227 Gerrit-Change-Number: 30142 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 22:50:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by laforge

Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 4 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 22:48:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by jtavares

Attention is currently required from: laforge. jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Patch Set 3: Verified-1 > > 1 failed: > [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/998/consoleFull > Fixed lint errors related to (void*) vs (void *) in patchset 4 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 3 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 14 Nov 2022 22:20:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by jtavares

Attention is currently required from: laforge, jtavares. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 to look at the new patch set (#4). Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... bankd: Add GSMTAP functionality for SIM traffic If a --gsmtap-host (-g) address is specified on the command line, trace SIM ATRs and APDUs to the given IP. If --gsmtap-slot (-G) is provided, limit tracing to the specified bank slot number. This feature may be useful when diagnosing issues with the remote SIM framework. Added new log category: DGSMTAP Also, cleaned up alignment in bankd --help output and removed unused -o option. Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 --- M src/bankd/Makefile.am M src/bankd/bankd.h M src/bankd/bankd_main.c A src/bankd/gsmtap.c A src/bankd/gsmtap.h M src/debug.c M src/debug.h 7 files changed, 175 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/39/30139/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 4 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by jtavares

Attention is currently required from: laforge, jtavares. jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Adding laforge on review after uploading patchset 3 to use libosmocore log facilities, and to remove osmo_* prefix from functions in gsmtap.[ch] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 3 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 22:17:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022