November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-iuh[master]: asn1tostruct: fix defines getting redefined

by osmith

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/30088 to look at the new patch set (#4). Change subject: asn1tostruct: fix defines getting redefined ...................................................................... asn1tostruct: fix defines getting redefined Do not write the same define twice for two files in a struct, e.g.: #define ENHANCEDRELOCATIONCOMPLETEREQUESTIES_RANAP_EXTENDEDRNC_ID_PRESENT (1 << 0) #define ENHANCEDRELOCATIONCOMPLETEREQUESTIES_RANAP_EXTENDEDRNC_ID_PRESENT (1 << 1) #define ENHANCEDRELOCATIONCOMPLETEREQUESTIES_RANAP_RAB_SETUPLIST_ENHANCEDRELOCCOMPLETEREQ_PRESENT (1 << 2) typedef struct RANAP_EnhancedRelocationCompleteRequestIEs_s { uint16_t presenceMask; RANAP_IuSignallingConnectionIdentifier_t oldIuSigConId; RANAP_IuSignallingConnectionIdentifier_t iuSigConId; RANAP_GlobalRNC_ID_t relocation_SourceRNC_ID; RANAP_ExtendedRNC_ID_t relocation_SourceExtendedRNC_ID; ///< Optional field RANAP_GlobalRNC_ID_t relocation_TargetRNC_ID; RANAP_ExtendedRNC_ID_t relocation_TargetExtendedRNC_ID; ///< Optional field RANAP_RAB_SetupList_EnhancedRelocCompleteReq_t raB_SetupList_EnhancedRelocCompleteReq; ///< Optional field } RANAP_EnhancedRelocationCompleteRequestIEs_t; The problem is that the type is used and it may not be unique inside a struct. Change the code to use the name of the field if the type is not unique. Keep using the type otherwise so existing code doesn't need to be modified a lot to fix this. Fix for: ../include/osmocom/ranap/ranap_ies_defs.h:514: warning: "RANAP_ENHANCEDRELOCATIONINFORMATIONREQUESTIES_RANAP_IUSIGNALLINGCONNECTIONIDENTIFIER_PRESENT" redefined Change-Id: I2ecae6789899952d1dc5691ab76907abeaa71c12 --- M TODO-RELEASE M asn1/utils/asn1tostruct.py 2 files changed, 28 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/88/30088/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I2ecae6789899952d1dc5691ab76907abeaa71c12 Gerrit-Change-Number: 30088 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: ranap_common_cn: remove unused ctx args

by osmith

Attention is currently required from: osmith, laforge. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/30142 to look at the new patch set (#2). Change subject: ranap_common_cn: remove unused ctx args ...................................................................... ranap_common_cn: remove unused ctx args ranap_cn_rx_co and ranap_cn_rx_cl both have a void *ctx argument, that gets passed to: * a callback function and * to various decode functions in the same file. As it is named "ctx", it looks like a talloc context. But the decode functions don't use ctx at all and so in reality it is private userdata for the callback. It is used as such by test/hnb-test-rua and in osmo-msc. Start cleaning this up by removing the unused ctx args, a future patch will rename it to priv and yet another patch will fix a compiler warning in test/hnb-test-rua by properly using it as userdata arg. Change-Id: I8936197d7ae7ffddbe8ee99d909d74ac5b3ab227 --- M TODO-RELEASE M include/osmocom/ranap/ranap_common_cn.h M src/ranap_common_cn.c 3 files changed, 35 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/42/30142/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8936197d7ae7ffddbe8ee99d909d74ac5b3ab227 Gerrit-Change-Number: 30142 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: ranap_common_cn: remove unused ctx args

by pespin

Attention is currently required from: osmith, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30142 ) Change subject: ranap_common_cn: remove unused ctx args ...................................................................... Patch Set 1: -Code-Review (1 comment) File include/osmocom/ranap/ranap_common_cn.h: https://gerrit.osmocom.org/c/osmo-iuh/+/30142/comment/a41aec70_efa98174 PS1, Line 23: ranap_cn_rx_co_decode_2 > we usually have the "2" suffix in our APIs without the underscore. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8936197d7ae7ffddbe8ee99d909d74ac5b3ab227 Gerrit-Change-Number: 30142 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Nov 2022 09:12:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd, client, server: add -L option to disable log coloring

by jtavares

jtavares has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30154 ) Change subject: bankd, client, server: add -L option to disable log coloring ...................................................................... bankd, client, server: add -L option to disable log coloring When the stderr of these services is sent to syslog, for example by using systemd's StandardError=syslog, syslog's escaping of ANSI color ESC sequences in log messages really clutter the log files. This option allows log coloring to be disabled on the command line. Change-Id: I6955b0af1ceb11a4029383e32bb298ee8da7503f --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/54/30154/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 3fd4d6b..063013e 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -301,6 +301,7 @@ " -s --permit-shared-pcsc Permit SHARED access to PC/SC readers (default: exclusive)\n" " -g --gsmtap-ip A.B.C.D Enable GSMTAP and send APDU traces to given IP\n" " -G --gsmtap-slot <0-1023> Limit tracing to given bank slot, only (default: all slots)\n" +" -L --log-color-disable Output log messages without color\n" ); } @@ -325,10 +326,11 @@ { "permit-shared-pcsc", 0, 0, 's' }, { "gsmtap-ip", 1, 0, 'g' }, { "gsmtap-slot", 1, 0, 'G' }, + { "log-color-disable", 0, 0, 'L' }, { 0, 0, 0, 0 } }; - c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:", long_options, &option_index); + c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:L", long_options, &option_index); if (c == -1) break; @@ -374,6 +376,9 @@ case 'G': g_bankd->cfg.gsmtap_slot = atoi(optarg); break; + case 'L': + log_set_use_color(osmo_stderr_target, 0); + break; } } } diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index 5a23d82..eb54310 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -35,6 +35,7 @@ " -a --atr HEXSTRING default ATR to simulate (until bankd overrides it)\n" " -r --atr-ignore-rspro Ignore any ATR from bankd; use only ATR given by -a)\n" " -e --event-script <path> event script to be called by client\n" + " -L --log-color-disable Output log messages without color\n" #ifdef USB_SUPPORT " -V --usb-vendor VENDOR_ID\n" " -P --usb-product PRODUCT_ID\n" @@ -64,6 +65,7 @@ { "atr", 1, 0, 'a' }, { "atr-ignore-rspro", 0, 0, 'r' }, { "event-script", 1, 0, 'e' }, + {" log-color-disable", 0, 0, 'L' }, #ifdef USB_SUPPORT { "usb-vendor", 1, 0, 'V' }, { "usb-product", 1, 0, 'P' }, @@ -76,7 +78,7 @@ { 0, 0, 0, 0 } }; - c = getopt_long(argc, argv, "hvd:i:p:c:n:a:re:" + c = getopt_long(argc, argv, "hvd:i:p:c:n:a:re:L" #ifdef USB_SUPPORT "V:P:C:I:S:A:H:" #endif @@ -122,6 +124,9 @@ case 'e': osmo_talloc_replace_string(cfg, &cfg->event_script, optarg); break; + case 'L': + log_set_use_color(osmo_stderr_target, 0); + break; #ifdef USB_SUPPORT case 'V': cfg->usb.vendor_id = strtol(optarg, NULL, 16); diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 419dcad..7f5267c 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -33,9 +33,10 @@ static void print_help() { printf( " Some useful help...\n" - " -h --help This text\n" - " -V --version Print version of the program\n" - " -d --debug option Enable debug logging (e.g. DMAIN:DST2)\n" + " -h --help This text\n" + " -V --version Print version of the program\n" + " -d --debug option Enable debug logging (e.g. DMAIN:DST2)\n" + " -L --log-color-disable Output log messages without color\n" ); } @@ -47,10 +48,11 @@ { "help", 0, 0, 'h' }, { "version", 0, 0, 'V' }, { "debug", 1, 0, 'd' }, - {0, 0, 0, 0} + { "log-color-disable", 0, 0, 'L' }, + { 0, 0, 0, 0 } }; - c = getopt_long(argc, argv, "hVd:", long_options, &option_index); + c = getopt_long(argc, argv, "hVd:L", long_options, &option_index); if (c == -1) break; @@ -66,6 +68,9 @@ printf("osmo-resmim-server version %s\n", VERSION); exit(0); break; + case 'L': + log_set_use_color(osmo_stderr_target, 0); + break; default: /* ignore */ break; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6955b0af1ceb11a4029383e32bb298ee8da7503f Gerrit-Change-Number: 30154 Gerrit-PatchSet: 1 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by jtavares

Attention is currently required from: laforge. jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 4: (4 comments) File src/bankd/gsmtap.c: https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/24f26a73_911cfbe4 PS2, Line 28: osmo_bankd_gsmtap_init > AFAIR, in simtrace2.git they are actually part of libosmo-simtrace2. […] Ack https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/797ceb81_8c09e6d2 PS2, Line 35: perror("unable to open GSMTAP"); > thanks for pointing this out, that's clearly a bug in libosmo-simtrace2 then. Ack https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/2dad9545_26974017 PS2, Line 56: uint8_t *buf = malloc(gross_len); > Nice-- I'd never heard of writev(). Very useful. […] Ack https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/39602826_d6a4de6f PS2, Line 83: perr > normally we'd want to use the libosmocore logging framework with LOGL_ERROR here. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 4 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Nov 2022 02:42:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by jtavares

jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Marking issues as resolved. @laforge, is there anyone else you want listed as Reviewer on this PR? Right now it only has you with a +1. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 4 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Nov 2022 02:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: contrib/jenkins.sh : build and publish combined targets

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30151 ) Change subject: contrib/jenkins.sh : build and publish combined targets ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks. I'm not sure if we want to publish *all* combined image or if it's sufficient to have one specific combination for each BOARD. Best to check with mschramm -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32f9a0213aaefa50232a3d8dc2e7a4f2f44dbae1 Gerrit-Change-Number: 30151 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 00:57:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: conrtrib/upload : upload elf files

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30153 ) Change subject: conrtrib/upload : upload elf files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ifceb16d385388356ac1bf8b13f5df62c643bebf8 Gerrit-Change-Number: 30153 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 00:55:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: conrtrib/upload : upload elf files

by Hoernchen

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/30153 to look at the new patch set (#2). Change subject: conrtrib/upload : upload elf files ...................................................................... conrtrib/upload : upload elf files Due to popular demand people want elf files that can be loaded to get debug symbols, so publish the elf file, but not the stub-less bin file. This elf file can ONLY be used to look up symbols, it should NOT be "load"ed into flash, because the preceding crc stub has to match. Mixing older crc stubs that are still in flash and newer elf files means the device will end up in DFU mode upon reset. Change-Id: Ifceb16d385388356ac1bf8b13f5df62c643bebf8 --- M contrib/prepare_upload.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/53/30153/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ifceb16d385388356ac1bf8b13f5df62c643bebf8 Gerrit-Change-Number: 30153 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: conrtrib/upload : upload elf files

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/30153 ) Change subject: conrtrib/upload : upload elf files ...................................................................... conrtrib/upload : upload elf files Due to popular demand people want elf files that can be loaded to get debug symbols, so publish the elf file, but not the stub-less bin file. Change-Id: Ifceb16d385388356ac1bf8b13f5df62c643bebf8 --- M contrib/prepare_upload.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/53/30153/1 diff --git a/contrib/prepare_upload.sh b/contrib/prepare_upload.sh index f134d2a..cdd144f 100755 --- a/contrib/prepare_upload.sh +++ b/contrib/prepare_upload.sh @@ -9,7 +9,7 @@ cd firmware/bin for ext in bin elf; do for file in *."$ext"; do - if ! [[ "$file" =~ ^(.*padded.*|.*nocrcstub.*)$ ]];then + if ! [[ "$file" =~ ^(.*padded.*|.*nocrcstub.*bin)$ ]];then without_ext="${file%.*}" cp -v "$file" "$without_ext-latest.$ext" cp -v "$file" "$without_ext-$GIT_VERSION.$ext" -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ifceb16d385388356ac1bf8b13f5df62c643bebf8 Gerrit-Change-Number: 30153 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022