November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-remsim[master]: rspro_client: implement re-establish delay

by jtavares

Attention is currently required from: laforge. jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30138 ) Change subject: rspro_client: implement re-establish delay ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Will send new patchset to address comments and lint issues File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/3370b447_da2b1bb3 PS1, Line 236: LOGPFS > I am not sure those are worth LOGL_NOTICE. […] Understood, will change to DEBUG -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I86cdc3ba37482e6577b429194d273a2399f32208 Gerrit-Change-Number: 30138 Gerrit-PatchSet: 1 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 14 Nov 2022 15:23:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: nm_rcarrier_fsm: fix indention of ENABLED state

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30146 ) Change subject: nm_rcarrier_fsm: fix indention of ENABLED state ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I52945babd2b31b20a578ec6818af763b0dd98d1a Gerrit-Change-Number: 30146 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Nov 2022 15:09:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: asn1tostruct: fix defines getting redefined

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30088 ) Change subject: asn1tostruct: fix defines getting redefined ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: > Yes. Here is the diff of the generated files with this patch: https://gitea.osmocom. […] ACK. IIUC you didn't detect any code change required after this change in the users of the lib? In any case it may make sense to apply the renaming only for fields count > 1 (so that if there's 2 or more fields colliding, the first one is kept the old way). -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I2ecae6789899952d1dc5691ab76907abeaa71c12 Gerrit-Change-Number: 30088 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 15:09:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by pespin

Attention is currently required from: neels, laforge, fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 20: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 20 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Nov 2022 15:01:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by jtavares

jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 2: (1 comment) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/894ce04f_1b353adc PS2, Line 331: c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:", long_options, &option_index); Patchset 2 note: I removed bogus option 'o'. This change is unrelated to the addition of GSMTAP, itself. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 14 Nov 2022 14:54:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: jenkins-gerrit: fix ambiguous use of review api

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30147 ) Change subject: jenkins-gerrit: fix ambiguous use of review api ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2d627f8f3b400fa57a50a228d47df2194f60fd08 Gerrit-Change-Number: 30147 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 14 Nov 2022 14:51:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in pysim[master]: shell: Use a double asterisk for kwargs

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30077 ) Change subject: shell: Use a double asterisk for kwargs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: (CI failure is unrelated, needs rebase on https://gerrit.osmocom.org/c/pysim/+/30004 to work) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 Gerrit-Change-Number: 30077 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: markb <markboldyrev(a)gmail.com> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 14:49:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by jtavares

jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: I believe Jenkins issues have been fixed with Patchset #2 File src/bankd/bankd.h: https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/33c0685b_ff78f35b PS1, Line 136: char* gsmtap_host; > "foo* bar" should be "foo *bar" Please fix. File src/bankd/gsmtap.h: https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/7643990a_2a6340ca PS1, Line 7: const uint8_t *sim_tpdu, unsigned int sim_tpdu_len); > adding a line without newline at end of file Please fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 14 Nov 2022 14:49:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: linuxlist: add llist_entry_empty()

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29792 ) Change subject: linuxlist: add llist_entry_empty() ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4afe3e77f53728db1d139bded5925183dca011f Gerrit-Change-Number: 29792 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by jtavares

Attention is currently required from: jtavares. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 to look at the new patch set (#2). Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... bankd: Add GSMTAP functionality for SIM traffic If a --gsmtap-host (-g) address is specified on the command line, trace SIM ATRs and APDUs to the given IP. If --gsmtap-slot (-G) is provided, limit tracing to the specified bank slot number. This feature may be useful when diagnosing issues with the remote SIM framework. Also, cleaned up alignment in bankd --help output and removed unused -o option. Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 --- M src/bankd/Makefile.am M src/bankd/bankd.h M src/bankd/bankd_main.c A src/bankd/gsmtap.c A src/bankd/gsmtap.h 5 files changed, 150 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/39/30139/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022