Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30088 )
Change subject: asn1tostruct: fix defines getting redefined
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
So you seem to fix some code generation in this patch, but I don't see any .c/.h files changes. Is that because the as1nstruct is called dynamically during build time?
File asn1/utils/asn1tostruct.py:
https://gerrit.osmocom.org/c/osmo-iuh/+/30088/comment/f67e31ea_1fa3837a
PS3, Line 84: use the same type multiple times, in that case we use the actual name
Did you think about simply adding a suffix to it? like a counter if count != 1?
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30088
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I2ecae6789899952d1dc5691ab76907abeaa71c12
Gerrit-Change-Number: 30088
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Nov 2022 12:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30142 )
Change subject: ranap_common_cn: remove unused ctx args
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> IMHO you shouldn't drop the arg. […]
I'm not dropping it from ranap_cn_rx_co and ranap_cn_rx_cl, but only from functions that these are calling in the same file. Because these functions don't use ctx at all, so imho having it there just makes the whole code more confusing as it's not clear whether ctx is for userdata or a talloc context when looking only at parts of it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I8936197d7ae7ffddbe8ee99d909d74ac5b3ab227
Gerrit-Change-Number: 30142
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Nov 2022 12:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30142 )
Change subject: ranap_common_cn: remove unused ctx args
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Ah I see now that you are dropping it from places where it is not really used.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I8936197d7ae7ffddbe8ee99d909d74ac5b3ab227
Gerrit-Change-Number: 30142
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Nov 2022 12:27:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30142 )
Change subject: ranap_common_cn: remove unused ctx args
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
IMHO you shouldn't drop the arg.
It's actually a "priv" data pointer passed by the caller in ranap_cn_rx_cl() which it can then use back in the callback. Agree?
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I8936197d7ae7ffddbe8ee99d909d74ac5b3ab227
Gerrit-Change-Number: 30142
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Nov 2022 12:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment