October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: WIP: Use new mgcp-client VTY commands under mgw node

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29801 ) Change subject: WIP: Use new mgcp-client VTY commands under mgw node ...................................................................... WIP: Use new mgcp-client VTY commands under mgw node Depends: osmo-mgw.git Change-Id: Id55af13d2ecde49d968b9dca6a2f8108a17ec484 Related: SYS#5987 Change-Id: I71e49cb4d6c2fe54a895aab0b0ba5acc4e57c253 --- M doc/manuals/chapters/running.adoc 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/29801/1 diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 6a985cf..930682d 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -136,9 +136,9 @@ ---- network mgw 0 - mgw remote-ip 10.9.8.7 - mgw remote-port 2427 - mgw reset-endpoint rtpbridge/* <1> + remote-ip 10.9.8.7 + remote-port 2427 + reset-endpoint rtpbridge/* <1> ---- <1> The 'reset-endpoint' setting instructs the OsmoBSC to send a wildcarded DLCX to the media gateway. This helps to clear lingering calls from the -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71e49cb4d6c2fe54a895aab0b0ba5acc4e57c253 Gerrit-Change-Number: 29801 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Convert users supporting new MGW Pool VTY node during wr...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29791 ) Change subject: mgcp-client: Convert users supporting new MGW Pool VTY node during write-config ...................................................................... mgcp-client: Convert users supporting new MGW Pool VTY node during write-config If the user (app) already supports the MGW Pool VTY command set (mgcp_client_pool_vty_init() was called), then if single MGW mode is in use it's because the config file was not updated to use the new MGW Pool node. Let's convert it to the new format to help in transitioning to the new VTY command set. Related: SYS#5987 Change-Id: I2f6658cc66f8bcbd4a60ee2b932bb5dd65888233 --- M src/libosmo-mgcp-client/mgcp_client_vty.c 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c index 76f8c4f..1672f97 100644 --- a/src/libosmo-mgcp-client/mgcp_client_vty.c +++ b/src/libosmo-mgcp-client/mgcp_client_vty.c @@ -285,6 +285,11 @@ * \returns CMD_SUCCESS on success, CMD_WARNING on error */ int mgcp_client_config_write(struct vty *vty, const char *indent) { + /* If caller supports MGW pool API (mgcp_client_pool_vty_init was + * called), then skip printing any config in this node and print it when + * the whole 'mgw' node is printed. */ + if (global_mgcp_client_pool) + return CMD_SUCCESS; return config_write(vty, indent, global_mgcp_client_conf); } @@ -339,6 +344,16 @@ config_write(vty, indent, &pool_member->conf); } + /* MGW pool API is supported by user (global_mgcp_client_pool is set + * because mgcp_client_pool_vty_init was called). If single MGW was + * configured through old VTY and no mgw in the new MGW pool VTY is + * replacing it, then output the single MGW converted to the new MGW + * pool VTY. */ + if (llist_empty(&pool->member_list) && pool->mgcp_client_single) { + vty_out(vty, "%smgw 0%s", pool->vty_indent, VTY_NEWLINE); + config_write(vty, indent, global_mgcp_client_conf); + } + talloc_free(indent); return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2f6658cc66f8bcbd4a60ee2b932bb5dd65888233 Gerrit-Change-Number: 29791 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Convert users supporting new MGW Pool VTY node during wr...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29791 ) Change subject: mgcp-client: Convert users supporting new MGW Pool VTY node during write-config ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2f6658cc66f8bcbd4a60ee2b932bb5dd65888233 Gerrit-Change-Number: 29791 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 11:00:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: Update examples to use mgw pooling VTY commands

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29798 to look at the new patch set (#2). Change subject: Update examples to use mgw pooling VTY commands ...................................................................... Update examples to use mgw pooling VTY commands Let's avoid guiding users towards the old deprecated VTY interface. Line "mgw endpoint-range" is removed since it's nowadays deprected and implemented as a NOOP. Related: SYS#5987 Change-Id: Iff74a9efca2a0a2c38d5ac39df704b2b211fd906 --- M doc/examples/osmo-bsc/osmo-bsc-4trx.cfg M doc/examples/osmo-bsc/osmo-bsc.cfg M doc/manuals/chapters/running.adoc M tests/ctrl/osmo-bsc-neigh-test.cfg 4 files changed, 17 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/98/29798/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iff74a9efca2a0a2c38d5ac39df704b2b211fd906 Gerrit-Change-Number: 29798 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Introduce API mgcp_client_pool_config_write

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29795 ) Change subject: mgcp-client: Introduce API mgcp_client_pool_config_write ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7a620cf47886d8ecab30ce369cf123d98ab842c5 Gerrit-Change-Number: 29795 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:59:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Convert users supporting new MGW Pool VTY node during wr...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29791 ) Change subject: mgcp-client: Convert users supporting new MGW Pool VTY node during write-config ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2f6658cc66f8bcbd4a60ee2b932bb5dd65888233 Gerrit-Change-Number: 29791 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:56:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Add new VTY commands under mgw node without mgw prefix

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29800 ) Change subject: mgcp-client: Add new VTY commands under mgw node without mgw prefix ...................................................................... mgcp-client: Add new VTY commands under mgw node without mgw prefix Previous existing ones are left marked as deprecated, to avoid breakage with older configs. Related: SYS#5987 Change-Id: Id55af13d2ecde49d968b9dca6a2f8108a17ec484 --- M src/libosmo-mgcp-client/mgcp_client_vty.c 1 file changed, 75 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/00/29800/1 diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c index b571fa0..6580710 100644 --- a/src/libosmo-mgcp-client/mgcp_client_vty.c +++ b/src/libosmo-mgcp-client/mgcp_client_vty.c @@ -62,8 +62,8 @@ } DEFUN(cfg_mgw_local_ip, cfg_mgw_local_ip_cmd, - "mgw local-ip " VTY_IPV46_CMD, - MGW_STR "local bind to connect to MGW from\n" + "local-ip " VTY_IPV46_CMD, + "local bind to connect to MGW from\n" "local bind IPv4 address\n" "local bind IPv6 address\n") { @@ -78,10 +78,16 @@ "mgcpgw local-ip A.B.C.D", MGW_STR "local bind to connect to MGCP gateway with\n" "local bind IP address\n") +ALIAS_DEPRECATED(cfg_mgw_local_ip, + cfg_mgw_mgw_local_ip_cmd, + "mgw local-ip " VTY_IPV46_CMD, + MGW_STR "local bind to connect to MGW from\n" + "local bind IPv4 address\n" + "local bind IPv6 address\n") DEFUN(cfg_mgw_local_port, cfg_mgw_local_port_cmd, - "mgw local-port <0-65535>", - MGW_STR "local port to connect to MGW from\n" + "local-port <0-65535>", + "local port to connect to MGW from\n" "local bind port\n") { struct mgcp_client_conf *conf = get_mgcp_client_config(vty); @@ -93,10 +99,15 @@ "mgcpgw local-port <0-65535>", MGW_STR "local bind to connect to MGCP gateway with\n" "local bind port\n") +ALIAS_DEPRECATED(cfg_mgw_local_port, + cfg_mgw_mgw_local_port_cmd, + "mgw local-port <0-65535>", + MGW_STR "local port to connect to MGW from\n" + "local bind port\n") DEFUN(cfg_mgw_remote_ip, cfg_mgw_remote_ip_cmd, - "mgw remote-ip " VTY_IPV46_CMD, - MGW_STR "remote IP address to reach the MGW at\n" + "remote-ip " VTY_IPV46_CMD, + "remote IP address to reach the MGW at\n" "remote IPv4 address\n" "remote IPv6 address\n") { @@ -110,10 +121,16 @@ "mgcpgw remote-ip A.B.C.D", MGW_STR "remote bind to connect to MGCP gateway with\n" "remote bind IP address\n") +ALIAS_DEPRECATED(cfg_mgw_remote_ip, + cfg_mgw_mgw_remote_ip_cmd, + "mgw remote-ip " VTY_IPV46_CMD, + MGW_STR "remote IP address to reach the MGW at\n" + "remote IPv4 address\n" + "remote IPv6 address\n") DEFUN(cfg_mgw_remote_port, cfg_mgw_remote_port_cmd, - "mgw remote-port <0-65535>", - MGW_STR "remote port to reach the MGW at\n" + "remote-port <0-65535>", + "remote port to reach the MGW at\n" "remote port\n") { struct mgcp_client_conf *conf = get_mgcp_client_config(vty); @@ -125,6 +142,11 @@ "mgcpgw remote-port <0-65535>", MGW_STR "remote bind to connect to MGCP gateway with\n" "remote bind port\n") +ALIAS_DEPRECATED(cfg_mgw_remote_port, + cfg_mgw_mgw_remote_port_cmd, + "mgw remote-port <0-65535>", + MGW_STR "remote port to reach the MGW at\n" + "remote port\n") DEFUN_DEPRECATED(cfg_mgw_endpoint_range, cfg_mgw_endpoint_range_cmd, "mgw endpoint-range <1-65534> <1-65534>", @@ -164,8 +186,8 @@ DEFUN(cfg_mgw_endpoint_domain_name, cfg_mgw_endpoint_domain_name_cmd, - "mgw endpoint-domain NAME", - MGW_STR "Set the domain name to send in MGCP messages, e.g. the part 'foo' in 'rtpbridge/*@foo'.\n" + "endpoint-domain NAME", + "Set the domain name to send in MGCP messages, e.g. the part 'foo' in 'rtpbridge/*@foo'.\n" "Domain name, should be alphanumeric.\n") { struct mgcp_client_conf *conf = get_mgcp_client_config(vty); @@ -178,11 +200,16 @@ } return CMD_SUCCESS; } +ALIAS_DEPRECATED(cfg_mgw_endpoint_domain_name, + cfg_mgw_mgw_endpoint_domain_name_cmd, + "mgw endpoint-domain NAME", + MGW_STR "Set the domain name to send in MGCP messages, e.g. the part 'foo' in 'rtpbridge/*@foo'.\n" + "Domain name, should be alphanumeric.\n") DEFUN(cfg_mgw_reset_ep_name, cfg_mgw_reset_ep_name_cmd, - "mgw reset-endpoint NAME", - MGW_STR "Add an endpoint name that should be reset (DLCX) on connect to the reset-endpoint list," + "reset-endpoint NAME", + "Add an endpoint name that should be reset (DLCX) on connect to the reset-endpoint list," "e.g. 'rtpbridge/*'\n" "Endpoint name, e.g. 'rtpbridge/*' or 'ds/e1-0/s-3/su16-4'.\n") { @@ -220,11 +247,17 @@ return CMD_SUCCESS; } +ALIAS_DEPRECATED(cfg_mgw_reset_ep_name, + cfg_mgw_mgw_reset_ep_name_cmd, + "mgw reset-endpoint NAME", + MGW_STR "Add an endpoint name that should be reset (DLCX) on connect to the reset-endpoint list," + "e.g. 'rtpbridge/*'\n" + "Endpoint name, e.g. 'rtpbridge/*' or 'ds/e1-0/s-3/su16-4'.\n") DEFUN(cfg_mgw_no_reset_ep_name, cfg_mgw_no_reset_ep_name_cmd, - "no mgw reset-endpoint NAME", - NO_STR MGW_STR "remove an endpoint name from the reset-endpoint list, e.g. 'rtpbridge/*'\n" + "no reset-endpoint NAME", + NO_STR "remove an endpoint name from the reset-endpoint list, e.g. 'rtpbridge/*'\n" "Endpoint name, e.g. 'rtpbridge/*' or 'ds/e1-0/s-3/su16-4'.\n") { struct reset_ep *reset_ep; @@ -241,6 +274,11 @@ vty_out(vty, "%% no such endpoint name configured ('%s')%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } +ALIAS_DEPRECATED(cfg_mgw_no_reset_ep_name, + cfg_mgw_mgw_no_reset_ep_name_cmd, + "no mgw reset-endpoint NAME", + NO_STR MGW_STR "remove an endpoint name from the reset-endpoint list, e.g. 'rtpbridge/*'\n" + "Endpoint name, e.g. 'rtpbridge/*' or 'ds/e1-0/s-3/su16-4'.\n") static int config_write(struct vty *vty, const char *indent, struct mgcp_client_conf *conf) { @@ -253,28 +291,28 @@ addr = conf->local_addr; if (addr) - vty_out(vty, "%smgw local-ip %s%s", indent, addr, + vty_out(vty, "%slocal-ip %s%s", indent, addr, VTY_NEWLINE); port = conf->local_port; if (port >= 0) - vty_out(vty, "%smgw local-port %u%s", indent, + vty_out(vty, "%slocal-port %u%s", indent, (uint16_t)port, VTY_NEWLINE); addr = conf->remote_addr; if (addr) - vty_out(vty, "%smgw remote-ip %s%s", indent, addr, + vty_out(vty, "%sremote-ip %s%s", indent, addr, VTY_NEWLINE); port = conf->remote_port; if (port >= 0) - vty_out(vty, "%smgw remote-port %u%s", indent, + vty_out(vty, "%sremote-port %u%s", indent, (uint16_t)port, VTY_NEWLINE); if (conf->endpoint_domain_name[0]) - vty_out(vty, "%smgw endpoint-domain %s%s", indent, + vty_out(vty, "%sendpoint-domain %s%s", indent, conf->endpoint_domain_name, VTY_NEWLINE); llist_for_each_entry(reset_ep, &conf->reset_epnames, list) - vty_out(vty, "%smgw reset-endpoint %s%s", indent, reset_ep->name, VTY_NEWLINE); + vty_out(vty, "%sreset-endpoint %s%s", indent, reset_ep->name, VTY_NEWLINE); return CMD_SUCCESS; } @@ -297,15 +335,14 @@ { global_mgcp_client_ctx = talloc_ctx; - install_lib_element(node, &cfg_mgw_local_ip_cmd); - install_lib_element(node, &cfg_mgw_local_port_cmd); - install_lib_element(node, &cfg_mgw_remote_ip_cmd); - install_lib_element(node, &cfg_mgw_remote_port_cmd); - install_lib_element(node, &cfg_mgw_endpoint_range_cmd); - install_lib_element(node, &cfg_mgw_rtp_bts_base_port_cmd); - install_lib_element(node, &cfg_mgw_endpoint_domain_name_cmd); - install_lib_element(node, &cfg_mgw_reset_ep_name_cmd); - install_lib_element(node, &cfg_mgw_no_reset_ep_name_cmd); + /* deprecated 'mgw' commands ('mgw' prepended as first arg) */ + install_lib_element(node, &cfg_mgw_mgw_local_ip_cmd); + install_lib_element(node, &cfg_mgw_mgw_local_port_cmd); + install_lib_element(node, &cfg_mgw_mgw_remote_ip_cmd); + install_lib_element(node, &cfg_mgw_mgw_remote_port_cmd); + install_lib_element(node, &cfg_mgw_mgw_endpoint_domain_name_cmd); + install_lib_element(node, &cfg_mgw_mgw_reset_ep_name_cmd); + install_lib_element(node, &cfg_mgw_mgw_no_reset_ep_name_cmd); osmo_fsm_vty_add_cmds(); } @@ -552,6 +589,15 @@ * config */ install_node(pool->vty_node, config_write_pool); vty_init_common(pool, mgw_node); + install_lib_element(mgw_node, &cfg_mgw_local_ip_cmd); + install_lib_element(mgw_node, &cfg_mgw_local_port_cmd); + install_lib_element(mgw_node, &cfg_mgw_remote_ip_cmd); + install_lib_element(mgw_node, &cfg_mgw_remote_port_cmd); + install_lib_element(mgw_node, &cfg_mgw_endpoint_range_cmd); + install_lib_element(mgw_node, &cfg_mgw_rtp_bts_base_port_cmd); + install_lib_element(mgw_node, &cfg_mgw_endpoint_domain_name_cmd); + install_lib_element(mgw_node, &cfg_mgw_reset_ep_name_cmd); + install_lib_element(mgw_node, &cfg_mgw_no_reset_ep_name_cmd); install_element(mgw_node, &cfg_description_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id55af13d2ecde49d968b9dca6a2f8108a17ec484 Gerrit-Change-Number: 29800 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: SMPP: use default port from libsmpp34

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28865 ) Change subject: SMPP: use default port from libsmpp34 ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2140ed57e64f17fb79130014eaf88f58b62d7a00 Gerrit-Change-Number: 28865 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:51:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: SMPP: use default port from libsmpp34

by pespin

Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28865 ) Change subject: SMPP: use default port from libsmpp34 ...................................................................... Patch Set 10: (1 comment) File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28865/comment/4426a07d_d24fe376 PS10, Line 978: bind_addr ? bind_addr : "0.0.0.0", port ? port : SMPP_PORT); You are calling "port ? port : SMPP_PORT" three times. Do once "port = (port ? : SMPP_PORT);" and simplify the code. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2140ed57e64f17fb79130014eaf88f58b62d7a00 Gerrit-Change-Number: 28865 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:21:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: obs: fix master rpm repository description

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29799 ) Change subject: obs: fix master rpm repository description ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29799 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia5a88b064da66d7bf5cebe910961f752262b1bac Gerrit-Change-Number: 29799 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:19:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022