October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 3: (8 comments) Patchset: PS3: Some of my comments were not addressed yet. File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/334133ab_d84069de PS3, Line 959: struct { It probably makes more sense to have this struct declared in the bts_ramp_setup.h and use it here, but not that important. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/42835f41_b088f63b PS3, Line 3089: "Enable BTS setup ramping to limit the number of BTS which configure within a time window.\n" ... the amount of BTS to configure ... https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/6e1debe3_d1eb117c PS3, Line 3090: "Limit number of BTS.\n" amount. number may be misleading here since we use the concept of "BTS number" bts_nr. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/cd4b56fc_432aede4 PS3, Line 3091: "Number of BTS" missing dot. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/3d5d696d_7f22901c PS3, Line 42: /* inform all MOs */ My comment regarding moving this to a generic address was not applied nor got feedback. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/5e03b765_8f21c08f PS3, Line 201: llist_del(&bts->bts_setup_ramp.list); what's the content of &bts->bts_setup_ramp.list after calling llist_del? Because if it's not llist_entry_empty()==true then net time the BTS reconnect you will have problems. File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/12111ba4_be72a166 PS1, Line 345: case NM_EV_RAMP_GO: > Since this only makes sense when in DISABLED_DEPENDENCY or DISABLED_OFFLINE, better move it (duplica […] This has not yet been applied. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: SMPP: drop cmd_id wrapper

by msuraev

msuraev has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 ) Change subject: SMPP: drop cmd_id wrapper ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76 Gerrit-Change-Number: 28848 Gerrit-PatchSet: 38 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: SMPP: use default port from libsmpp34

by msuraev

Attention is currently required from: pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28865 ) Change subject: SMPP: use default port from libsmpp34 ...................................................................... Patch Set 9: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-msc/+/28865/comment/6deb38e3_74f910dd PS9, Line 98: 1.14.1 > You don't need to update this now. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2140ed57e64f17fb79130014eaf88f58b62d7a00 Gerrit-Change-Number: 28865 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:16:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: SMPP: use default port from libsmpp34

by msuraev

Attention is currently required from: fixeria, msuraev. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28865 to look at the new patch set (#10). Change subject: SMPP: use default port from libsmpp34 ...................................................................... SMPP: use default port from libsmpp34 Related: OS#5568 Requires: libsmpp34.git I2fcc15ac60b7b6501c9cb1afd0fe6d66d4b76f5f Change-Id: I2140ed57e64f17fb79130014eaf88f58b62d7a00 --- M TODO-RELEASE M src/libsmpputil/smpp_smsc.c M src/utils/smpp_mirror.c 3 files changed, 5 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/65/28865/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2140ed57e64f17fb79130014eaf88f58b62d7a00 Gerrit-Change-Number: 28865 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/22b0abf3_5c9c4349 PS1, Line 3087: "bts ramp limit <0-999> within <0-999> seconds", > I like to have this in one line as this feature doesn't have a complex configuration. It may not have a complex configuration NOW, but it may LATER, because we add more features and ways to configure it. That's why it's handy to have one command for each config bit. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:08:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 3: (1 comment) File include/osmocom/bsc/nm_bts_ramp.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/59aac33a_3527c221 PS1, Line 40: /*! > Do you know why? I would expect to see this documentation in the header and not in the file. […] Because there can be multiple declarations of the function, but usually only one implementation. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:07:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: obs: fix master rpm repository description

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29799 ) Change subject: obs: fix master rpm repository description ...................................................................... obs: fix master rpm repository description Instead of having the description of the nightly repository (copy paste error), put in "osmocom:master". This gets printed a few times in the log of the gerrit-binpkgs-rpm jenkins job and may lead to confusion - the nightly repository is not used, it's a separate master repository. Related: OS#2385 Change-Id: Ia5a88b064da66d7bf5cebe910961f752262b1bac --- M scripts/obs/data/build_binpkg.Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/99/29799/1 diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile index 201c7e5..925680d 100644 --- a/scripts/obs/data/build_binpkg.Dockerfile +++ b/scripts/obs/data/build_binpkg.Dockerfile @@ -61,7 +61,7 @@ ;; \ almalinux:8) \ { echo "[network_osmocom_master]"; \ - echo "name=Nightly packages of the Osmocom project (CentOS_8)"; \ + echo "name=osmocom:master"; \ echo "type=rpm-md"; \ echo "baseurl=https://downloads.osmocom.org/packages/osmocom:/master/CentOS_8/"; \ echo "gpgcheck=1"; \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29799 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia5a88b064da66d7bf5cebe910961f752262b1bac Gerrit-Change-Number: 29799 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Introduce support for libosmo-mgcp-client MGW pooling

by osmith

Attention is currently required from: pespin, fixeria, daniel, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29782 ) Change subject: Introduce support for libosmo-mgcp-client MGW pooling ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7670ba56fe989706579224a364595fdd4b4708ff Gerrit-Change-Number: 29782 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 08:36:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by fixeria

Attention is currently required from: pespin, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 3: (2 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/1eecab74_f4128382 PS1, Line 1284: "allow-bts-configuration <0-65535>", > copy paste from drop bts connection. […] What I actually suggest is to implement it as 'bts <0-255> bts-unblock-bringup-ramping', so that it's easier to find BTS specific commands. Other commands like 'drop bts connection' can be reworked and deprecated later. Also the upper limit is 255, not 256. File src/osmo-bsc/nm_bts_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/cef0a59d_99df65de PS1, Line 92: struct gsm_bts *bts, > Done Nope, not addressed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Oct 2022 04:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-remsim in Raspbian_10/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-remsim failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 200s] [332/506] installing libxcursor1-1:1.1.15-2 [ 200s] [333/506] installing libxmu6-2:1.1.2-2+b3 [ 200s] [334/506] installing libxrandr2-2:1.5.1-1 [ 201s] [335/506] installing libharfbuzz-icu0-2.3.1-1 [ 201s] [336/506] installing opensp-1.5.2-13 [ 202s] [337/506] installing libosmoabis10-1.3.0.8.c4c3.202210190053 [ 202s] [338/506] installing libosmocoding0-1.7.0.55.6135.202210190053 [ 202s] [339/506] installing libosmoctrl0-1.7.0.55.6135.202210190053 [ 202s] [340/506] installing libosmogb14-1.7.0.55.6135.202210190053 [ 203s] [341/506] installing libosmosim2-1.7.0.55.6135.202210190053 [ 203s] [342/506] installing openjade-1.4devel1-21.3 [ 204s] [343/506] installing libatkmm-1.6-1v5-2.28.0-2 [ 204s] [344/506] installing libosmotrau2-1.3.0.8.c4c3.202210190053 [ 204s] [345/506] installing libgdk-pixbuf2.0-0-2.38.1+dfsg-1 [ 204s] [346/506] installing g++-8-8.3.0-6+rpi1 [ 205s] dpkg-deb (subprocess): decompressing archive member: lzma error: compressed data is corrupt [ 205s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 205s] dpkg: error processing archive .init_b_cache/g++-8.deb (--install): [ 205s] cannot copy extracted data for './usr/lib/gcc/arm-linux-gnueabihf/8/cc1plus' to '/usr/lib/gcc/arm-linux-gnueabihf/8/cc1plus.dpkg-new': unexpected end of file or stream [ 205s] Errors were encountered while processing: [ 205s] .init_b_cache/g++-8.deb [ 205s] exit ... [ 205s] ### VM INTERACTION START ### [ 206s] [ 135.639979] sysrq: SysRq : Power Off [ 206s] [ 135.641795] reboot: Power down [ 206s] ### VM INTERACTION END ### [ 206s] [ 206s] armbuild01 failed "build osmo-remsim_1.0.0.30.f4be.202210190053.dsc" at Wed Oct 19 04:27:47 UTC 2022. [ 206s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022