October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: coverity/prepare_source_Osmocom.sh: execute with '-xe'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29553 ) Change subject: coverity/prepare_source_Osmocom.sh: execute with '-xe' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 Gerrit-Change-Number: 29553 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:32:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29554 ) Change subject: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d52dbf0f81332dc1856944a6a3c7376cb1e0638 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:32:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: mncc: move MNCC_F_ALL from mncc.c to mncc.h

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29562 ) Change subject: mncc: move MNCC_F_ALL from mncc.c to mncc.h ...................................................................... mncc: move MNCC_F_ALL from mncc.c to mncc.h Move it closer to the other MNCC_F_* entries, so that it's more likely that it gets updated when new flags are added. Change-Id: If1a12a696b87184c9eee14f475594c317927427b Related: OS#5282 --- M include/osmocom/msc/mncc.h M src/libmsc/mncc.c 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified keith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Objections: pespin: I would prefer this is not merged as is diff --git a/include/osmocom/msc/mncc.h b/include/osmocom/msc/mncc.h index 06a5dcc..8a1e4ad 100644 --- a/include/osmocom/msc/mncc.h +++ b/include/osmocom/msc/mncc.h @@ -126,6 +126,9 @@ #define MNCC_F_SIGNAL 0x2000 #define MNCC_F_GCR 0x4000 +/* UPDATEME when adding new MNCC_F_* entries above */ +#define MNCC_F_ALL 0x7fff + struct gsm_mncc { /* context based information */ uint32_t msg_type; diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index f446f98..24e79a7 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -110,8 +110,6 @@ * MNCC validation code. Move to libosmocore once headers are merged ************************************************************************/ -#define MNCC_F_ALL 0x7fff - static int check_string_terminated(const char *str, unsigned int size) { int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1a12a696b87184c9eee14f475594c317927427b Gerrit-Change-Number: 29562 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: mncc: cosmetic: fix coding style in mncc_prim_check_sign()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29563 ) Change subject: mncc: cosmetic: fix coding style in mncc_prim_check_sign() ...................................................................... mncc: cosmetic: fix coding style in mncc_prim_check_sign() Change-Id: I94d9cba7aca19f28c906e05dd86bfe3020abd5b1 Related: OS#5282 --- M src/libmsc/mncc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index 24e79a7..026dae0 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -155,7 +155,7 @@ { int rc; - if (mncc_prim->fields & ~ MNCC_F_ALL) { + if (mncc_prim->fields & ~MNCC_F_ALL) { LOGP(DMNCC, LOGL_ERROR, "Unknown MNCC field mask 0x%x\n", mncc_prim->fields); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I94d9cba7aca19f28c906e05dd86bfe3020abd5b1 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: mncc: cosmetic: fix coding style in mncc_prim_check_sign()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29563 ) Change subject: mncc: cosmetic: fix coding style in mncc_prim_check_sign() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I94d9cba7aca19f28c906e05dd86bfe3020abd5b1 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:31:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: mncc: move MNCC_F_ALL from mncc.c to mncc.h

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29562 ) Change subject: mncc: move MNCC_F_ALL from mncc.c to mncc.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1a12a696b87184c9eee14f475594c317927427b Gerrit-Change-Number: 29562 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:31:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Fix TC_gy_charging_volume_quota_threshold expectations

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29564 ) Change subject: ggsn: Fix TC_gy_charging_volume_quota_threshold expectations ...................................................................... ggsn: Fix TC_gy_charging_volume_quota_threshold expectations in Diameter, the CC-Input/Output direction is defined as follows in RFC4006: """ 8.24. CC-Input-Octets AVP The CC-Input-Octets AVP (AVP Code 412) is of type Unsigned64 and contains the number of requested, granted, or used octets that can be/have been received from the end user. 8.25. CC-Output-Octets AVP The CC-Output-Octets AVP (AVP Code 414) is of type Unsigned64 and contains the number of requested, granted, or used octets that can be/have been sent to the end user. """ So: * 3GPP uplink is from end user to PGW, and hence 'CC-Input-Octets' * 3GPP downlink is to end user to PGW, and hence 'CC-Output-Octets' This test started failing a few days ago since a bug was recently fixed in open5gs which was swapping the counters in open5gs-upfd: https://github.com/open5gs/open5gs/pull/1793 https://github.com/open5gs/open5gs/commit/f72a1edc6ed35cf5289243d660a73beb0… Change-Id: I2f64649ce70d85634f14b84eff98731f7711cbad --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 0a3bad0..21fdec7 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -2465,11 +2465,11 @@ "TImeout waiting for Gy UPDATE triggered by Volume-Quota-Threshold"); } } - f_validate_gy_cc_report(g_rx_gy, THRESHOLD, (0..6), 0, (1200..1400)); + f_validate_gy_cc_report(g_rx_gy, THRESHOLD, (0..6), (1200..1400), 0); /* ICMP Resp (echo back) generates one report: */ as_DIA_Gy_CCR(ctx, UPDATE_REQUEST); - f_validate_gy_cc_report(g_rx_gy, THRESHOLD, (0..1), (1200..1400), 0); + f_validate_gy_cc_report(g_rx_gy, THRESHOLD, (0..1), 0, (1200..1400)); /* Second update: 0 ul/dl pkt/octet should be reported, since nothing was sent */ as_DIA_Gy_CCR(ctx, UPDATE_REQUEST); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2f64649ce70d85634f14b84eff98731f7711cbad Gerrit-Change-Number: 29564 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Fix TC_gy_charging_volume_quota_threshold expectations

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29564 ) Change subject: ggsn: Fix TC_gy_charging_volume_quota_threshold expectations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2f64649ce70d85634f14b84eff98731f7711cbad Gerrit-Change-Number: 29564 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:30:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Introduce API osmux_xfrm_input_get_deliver_cb_data()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29569 ) Change subject: osmux: Introduce API osmux_xfrm_input_get_deliver_cb_data() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I95433b18802f73fa70e758f4aa02128eee940d88 Gerrit-Change-Number: 29569 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:30:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Log remote address upon rx of osmux pkt

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29570 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie2a375711c7c0989161ae651ea6f0695799e2670 Gerrit-Change-Number: 29570 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:29:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022