October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmux: Log remote address upon rx of osmux pkt

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29572 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... osmux: Log remote address upon rx of osmux pkt Related: SYS#5987 Change-Id: I391bc02a16eae1602680cb96128252f262852e14 --- M src/common/osmux.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/72/29572/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index 02faab4..e178e0c 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -263,9 +263,11 @@ while ((osmuxh = osmux_xfrm_output_pull(msg)) != NULL) { struct gsm_lchan *lchan = osmux_lchan_find(bts, &rem_addr, osmuxh->circuit_id); if (!lchan) { + char addr_str[64]; + osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr); LOGP(DOSMUX, LOGL_NOTICE, - "Cannot find lchan for circuit_id=%d\n", - osmuxh->circuit_id); + "Cannot find lchan for %s CID=%d\n", + addr_str, osmuxh->circuit_id); continue; } osmux_xfrm_output_sched(lchan->abis_ip.osmux.out, osmuxh); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I391bc02a16eae1602680cb96128252f262852e14 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Lower log level when osmux batch received for unknown CID

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29573 ) Change subject: osmux: Lower log level when osmux batch received for unknown CID ...................................................................... osmux: Lower log level when osmux batch received for unknown CID This is actually quite common, since our peer may be sending some osmux packets to us a while after we have closed the conn on our side, specially if latency is high in the network (eg satellite links). Related: SYS#598 Change-Id: I102047685b9b9f4cba43970945f955c4fe9c4c95 --- M src/common/osmux.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/29573/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index e178e0c..8a5d1ee 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -265,7 +265,7 @@ if (!lchan) { char addr_str[64]; osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr); - LOGP(DOSMUX, LOGL_NOTICE, + LOGP(DOSMUX, LOGL_DEBUG, "Cannot find lchan for %s CID=%d\n", addr_str, osmuxh->circuit_id); continue; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I102047685b9b9f4cba43970945f955c4fe9c4c95 Gerrit-Change-Number: 29573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Match remote address in osmux_lchan_find()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29571 ) Change subject: osmux: Match remote address in osmux_lchan_find() ...................................................................... osmux: Match remote address in osmux_lchan_find() Related: SYS#5987 Depends: libosmo-netif.git I95433b18802f73fa70e758f4aa02128eee940d88 Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 --- M src/common/osmux.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/71/29571/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index cacc3aa..02faab4 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -234,10 +234,15 @@ subslots = ts_subslots(ts); for (subslot = 0; subslot < subslots; subslot++) { struct gsm_lchan *lchan = &ts->lchan[subslot]; + struct osmux_handle *h; if (!lchan->abis_ip.osmux.use) continue; - if (lchan->abis_ip.osmux.local_cid == osmux_cid) - return lchan; + if (lchan->abis_ip.osmux.local_cid != osmux_cid) + continue; + h = osmux_xfrm_input_get_deliver_cb_data(lchan->abis_ip.osmux.in); + if (osmo_sockaddr_cmp(&h->rem_addr, rem_addr) != 0) + continue; + return lchan; /* Found it! */ } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 Gerrit-Change-Number: 29571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Log remote address upon rx of osmux pkt

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29570 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... osmux: Log remote address upon rx of osmux pkt Change-Id: Ie2a375711c7c0989161ae651ea6f0695799e2670 --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/70/29570/1 diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 8b12533..aae9579 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -410,16 +410,19 @@ uint32_t rem; struct mgcp_trunk *trunk = ofd->data; struct rate_ctr_group *all_rtp_stats = trunk->ratectr.all_osmux_conn_stats; + char addr_str[64]; msg = osmux_recv(ofd, &rem_addr); if (!msg) return -1; rate_ctr_inc(rate_ctr_group_get_ctr(all_rtp_stats, OSMUX_PACKETS_RX_CTR)); + osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr); if (trunk->cfg->osmux_use == OSMUX_USAGE_OFF) { LOGP(DOSMUX, LOGL_ERROR, - "bsc-nat wants to use Osmux but bsc did not request it\n"); + "Peer %s wants to use Osmux but MGCP Client did not request it\n", + addr_str); goto out; } @@ -435,8 +438,8 @@ &rem_addr); if (!conn_src) { LOGP(DOSMUX, LOGL_DEBUG, - "Cannot find a src conn for circuit_id=%d\n", - osmuxh->circuit_id); + "Cannot find a src conn for %s CID=%d\n", + addr_str, osmuxh->circuit_id); rem = msg->len; continue; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie2a375711c7c0989161ae651ea6f0695799e2670 Gerrit-Change-Number: 29570 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Match remote address in osmux_conn_lookup()

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29565 to look at the new patch set (#4). Change subject: osmux: Match remote address in osmux_conn_lookup() ...................................................................... osmux: Match remote address in osmux_conn_lookup() Depends: libosmo-netif.git I95433b18802f73fa70e758f4aa02128eee940d88 Change-Id: Ia717efa5f68e9412b86ef44a4c42a0715ff0e469 --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/65/29565/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia717efa5f68e9412b86ef44a4c42a0715ff0e469 Gerrit-Change-Number: 29565 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Fill in from_addr in struct osmo_rtp_msg_ctx

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29567 to look at the new patch set (#4). Change subject: osmux: Fill in from_addr in struct osmo_rtp_msg_ctx ...................................................................... osmux: Fill in from_addr in struct osmo_rtp_msg_ctx Change-Id: I9783978e295b964ca914f8d90d73effa8785f10d --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/67/29567/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9783978e295b964ca914f8d90d73effa8785f10d Gerrit-Change-Number: 29567 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Match remote address in osmux_conn_lookup() i Depends: libosmo...

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29565 to look at the new patch set (#3). Change subject: osmux: Match remote address in osmux_conn_lookup() i Depends: libosmo-netif.git I95433b18802f73fa70e758f4aa02128eee940d88 Change-Id: Ia717efa5f68e9412b86ef44a4c42a0715ff0e469 ...................................................................... osmux: Match remote address in osmux_conn_lookup() i Depends: libosmo-netif.git I95433b18802f73fa70e758f4aa02128eee940d88 Change-Id: Ia717efa5f68e9412b86ef44a4c42a0715ff0e469 --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/65/29565/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia717efa5f68e9412b86ef44a4c42a0715ff0e469 Gerrit-Change-Number: 29565 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Fill in from_addr in struct osmo_rtp_msg_ctx

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29567 to look at the new patch set (#3). Change subject: osmux: Fill in from_addr in struct osmo_rtp_msg_ctx ...................................................................... osmux: Fill in from_addr in struct osmo_rtp_msg_ctx Change-Id: I9783978e295b964ca914f8d90d73effa8785f10d --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/67/29567/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9783978e295b964ca914f8d90d73effa8785f10d Gerrit-Change-Number: 29567 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Update MNCC field validation mask.

by keith

keith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29559 ) Change subject: Update MNCC field validation mask. ...................................................................... Update MNCC field validation mask. In c6921e5068ba62cde67707fb3c8103919d1e0c0e, 0x4000 was added to the possible MNCC field flags, but before this commit, using it would result in an ERROR of "Unknown MNCC field mask 0x....." Related: OS#5282 Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d --- M src/libmsc/mncc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve keith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index 0a38997..f446f98 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -110,7 +110,7 @@ * MNCC validation code. Move to libosmocore once headers are merged ************************************************************************/ -#define MNCC_F_ALL 0x3fff +#define MNCC_F_ALL 0x7fff static int check_string_terminated(const char *str, unsigned int size) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d Gerrit-Change-Number: 29559 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Update MNCC field validation mask.

by keith

Attention is currently required from: fixeria. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29559 ) Change subject: Update MNCC field validation mask. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d Gerrit-Change-Number: 29559 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 15:24:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022