October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmux: Log remote address upon rx of osmux pkt

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29572 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... osmux: Log remote address upon rx of osmux pkt Related: SYS#5987 Change-Id: I391bc02a16eae1602680cb96128252f262852e14 --- M src/common/osmux.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/osmux.c b/src/common/osmux.c index 02faab4..e178e0c 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -263,9 +263,11 @@ while ((osmuxh = osmux_xfrm_output_pull(msg)) != NULL) { struct gsm_lchan *lchan = osmux_lchan_find(bts, &rem_addr, osmuxh->circuit_id); if (!lchan) { + char addr_str[64]; + osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr); LOGP(DOSMUX, LOGL_NOTICE, - "Cannot find lchan for circuit_id=%d\n", - osmuxh->circuit_id); + "Cannot find lchan for %s CID=%d\n", + addr_str, osmuxh->circuit_id); continue; } osmux_xfrm_output_sched(lchan->abis_ip.osmux.out, osmuxh); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I391bc02a16eae1602680cb96128252f262852e14 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Lower log level when osmux batch received for unknown CID

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29573 ) Change subject: osmux: Lower log level when osmux batch received for unknown CID ...................................................................... osmux: Lower log level when osmux batch received for unknown CID This is actually quite common, since our peer may be sending some osmux packets to us a while after we have closed the conn on our side, specially if latency is high in the network (eg satellite links). Related: SYS#598 Change-Id: I102047685b9b9f4cba43970945f955c4fe9c4c95 --- M src/common/osmux.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/osmux.c b/src/common/osmux.c index e178e0c..8a5d1ee 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -265,7 +265,7 @@ if (!lchan) { char addr_str[64]; osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr); - LOGP(DOSMUX, LOGL_NOTICE, + LOGP(DOSMUX, LOGL_DEBUG, "Cannot find lchan for %s CID=%d\n", addr_str, osmuxh->circuit_id); continue; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I102047685b9b9f4cba43970945f955c4fe9c4c95 Gerrit-Change-Number: 29573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Match remote address in osmux_lchan_find()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29571 ) Change subject: osmux: Match remote address in osmux_lchan_find() ...................................................................... osmux: Match remote address in osmux_lchan_find() Related: SYS#5987 Depends: libosmo-netif.git I95433b18802f73fa70e758f4aa02128eee940d88 Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 --- M src/common/osmux.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/osmux.c b/src/common/osmux.c index cacc3aa..02faab4 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -234,10 +234,15 @@ subslots = ts_subslots(ts); for (subslot = 0; subslot < subslots; subslot++) { struct gsm_lchan *lchan = &ts->lchan[subslot]; + struct osmux_handle *h; if (!lchan->abis_ip.osmux.use) continue; - if (lchan->abis_ip.osmux.local_cid == osmux_cid) - return lchan; + if (lchan->abis_ip.osmux.local_cid != osmux_cid) + continue; + h = osmux_xfrm_input_get_deliver_cb_data(lchan->abis_ip.osmux.in); + if (osmo_sockaddr_cmp(&h->rem_addr, rem_addr) != 0) + continue; + return lchan; /* Found it! */ } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 Gerrit-Change-Number: 29571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Log remote address upon rx of osmux pkt

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29572 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I391bc02a16eae1602680cb96128252f262852e14 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:02:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Match remote address in osmux_lchan_find()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29571 ) Change subject: osmux: Match remote address in osmux_lchan_find() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 Gerrit-Change-Number: 29571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:02:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Log remote address upon rx of osmux pkt

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29572 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I391bc02a16eae1602680cb96128252f262852e14 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:00:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Match remote address in osmux_lchan_find()

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29571 ) Change subject: osmux: Match remote address in osmux_lchan_find() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 Gerrit-Change-Number: 29571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:58:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: vty: 'hopping arfcn add': succeed if adding arfcn already in set

by osmith

Attention is currently required from: neels, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29551 ) Change subject: vty: 'hopping arfcn add': succeed if adding arfcn already in set ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: +1 Given that this breaks apply-config-file, this is a bug. I do understand how fixeria described that it would be useful during initial config file parsing to avoid unintentional mistakes. Maybe one idea would be (for a future patch) to complain about it only during startup, and possibly add a cli argument to ignore it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4e70d20d48a28c46a21dd10358577e5c798744c Gerrit-Change-Number: 29551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:54:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: coverity: fix prepare_source_Osmocom.sh terminating early

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29588 ) Change subject: coverity: fix prepare_source_Osmocom.sh terminating early ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I21a01478b64015fd699ed31634bf2fb1dc8f6750 Gerrit-Change-Number: 29588 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:43:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: dont return a length when msgb->lXh is NULL

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29591 ) Change subject: msgb: dont return a length when msgb->lXh is NULL ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > one could actually argue that we should OSMO_ASSERT in this case, as using msgb_lXlen() on a msgb wi […] That would also make sense, but one could also say that the data length of a NULL pointer is always 0. Lets see what the others think about this. (At least by the git log in osmo-bts I can see that the problem is not new) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1795c559f190713ebbabfbabf3453ab77da46a49 Gerrit-Change-Number: 29591 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022