October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1-hardware[master]: icE1usb fw: Add Notify PPS on Carrier Detect option

by Jenkins Builder

Attention is currently required from: tnt. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 ) Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option ...................................................................... Patch Set 2: (1 comment) File firmware/ice40-riscv/icE1usb/usb_gps.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1-hardware-lint-69): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/9cb19a65_3364… PS2, Line 173: else if (g_usb_gps.pps.set) else should follow close brace '}' -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie5d163434323a23912228003add9870fafefedf9 Gerrit-Change-Number: 29611 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw: Add Notify PPS on Carrier Detect option

by tnt

Attention is currently required from: tnt. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 to look at the new patch set (#2). Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option ...................................................................... icE1usb fw: Add Notify PPS on Carrier Detect option This is disabled by default because turns out the kernel doesn't actually support PPS on CD for USB-CDC devices :( And this also increase the interrupt traffic ... Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ie5d163434323a23912228003add9870fafefedf9 --- M firmware/ice40-riscv/icE1usb/usb_desc_app.c M firmware/ice40-riscv/icE1usb/usb_gps.c 2 files changed, 66 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/11/29611/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie5d163434323a23912228003add9870fafefedf9 Gerrit-Change-Number: 29611 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Close osmux socket when bts is freed

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29576 ) Change subject: osmux: Close osmux socket when bts is freed ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29576/comment/7d841efd_2e8dbdf3 PS2, Line 301: close(bts->osmux.fd.fd); > why not use osmo_fd_close() instead of these three lines? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibd3faa33b28d45048c340b177f13d5685f41a784 Gerrit-Change-Number: 29576 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:16:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: socket: Introduce API osmo_sockaddr_is_any

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29586 ) Change subject: socket: Introduce API osmo_sockaddr_is_any ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/29586/comment/fdebd417_4b97024c PS2, Line 1181: local "ANY"? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2810a889fc14052d0e0be6a2b500ad4e5088ffa9 Gerrit-Change-Number: 29586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:15:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: obs: build_srcpkg_if_needed: switch if branches

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29593 ) Change subject: obs: build_srcpkg_if_needed: switch if branches ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4f1d4e250eb4d8163f1ded29106a44deb0d0feff Gerrit-Change-Number: 29593 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:15:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: obs: lib.git.get_default_branch: add function

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29592 ) Change subject: obs: lib.git.get_default_branch: add function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If3f0ab500ff165d81f61b19ad41af90bd39dce8f Gerrit-Change-Number: 29592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:14:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmux: Close osmux socket when bts is freed

by pespin

Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/29576 to look at the new patch set (#5). Change subject: osmux: Close osmux socket when bts is freed ...................................................................... osmux: Close osmux socket when bts is freed Related: SYS#5987 Change-Id: Ibd3faa33b28d45048c340b177f13d5685f41a784 --- M src/common/osmux.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/76/29576/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibd3faa33b28d45048c340b177f13d5685f41a784 Gerrit-Change-Number: 29576 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: socket.h: Reorder sockaddr APIs to have them all together

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29585 ) Change subject: socket.h: Reorder sockaddr APIs to have them all together ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iab2ee2854be8027ee5978e06a83248b530a39bf7 Gerrit-Change-Number: 29585 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:12:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw: Add Notify PPS on Carrier Detect option

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 ) Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option ...................................................................... Patch Set 1: (2 comments) File firmware/ice40-riscv/icE1usb/usb_gps.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1-hardware-lint-66): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/e28bfa68_e277… PS1, Line 157: /* Check if PPS occured */ 'occured' may be misspelled - perhaps 'occurred'? Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1-hardware-lint-66): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/f38f7f1c_55b8… PS1, Line 173: else if (g_usb_gps.pps.set) else should follow close brace '}' -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie5d163434323a23912228003add9870fafefedf9 Gerrit-Change-Number: 29611 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 04 Oct 2022 14:11:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw: Add Notify PPS on Carrier Detect option

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 ) Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option ...................................................................... icE1usb fw: Add Notify PPS on Carrier Detect option This is disabled by default because turns out the kernel doesn't actually support PPS on CD for USB-CDC devices :( And this also increase the interrupt traffic ... Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ie5d163434323a23912228003add9870fafefedf9 --- M firmware/ice40-riscv/icE1usb/usb_desc_app.c M firmware/ice40-riscv/icE1usb/usb_gps.c 2 files changed, 66 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/11/29611/1 diff --git a/firmware/ice40-riscv/icE1usb/usb_desc_app.c b/firmware/ice40-riscv/icE1usb/usb_desc_app.c index 25472e0..7dfc304 100644 --- a/firmware/ice40-riscv/icE1usb/usb_desc_app.c +++ b/firmware/ice40-riscv/icE1usb/usb_desc_app.c @@ -250,7 +250,11 @@ .bmAttributes = 0x03, /* Longest notif is SERIAL_STATE with 2 data bytes */ .wMaxPacketSize = sizeof(struct usb_ctrl_req) + 2, +#ifdef GPS_PPS_ON_CD + .bInterval = 1, +#else .bInterval = 0x40, +#endif }, .intf_data = { .bLength = sizeof(struct usb_intf_desc), diff --git a/firmware/ice40-riscv/icE1usb/usb_gps.c b/firmware/ice40-riscv/icE1usb/usb_gps.c index 1c10033..42da5a2 100644 --- a/firmware/ice40-riscv/icE1usb/usb_gps.c +++ b/firmware/ice40-riscv/icE1usb/usb_gps.c @@ -17,6 +17,7 @@ #include <no2usb/usb_cdc_proto.h> #include "console.h" +#include "misc.h" #include "usb_desc_ids.h" @@ -34,9 +35,23 @@ unsigned int rd; char data[BUF_SIZE] __attribute__((aligned(4))); } buf; + +#ifdef GPS_PPS_ON_CD + /* PPS tracking */ + struct { + uint32_t last; + bool set; + } pps; +#endif } g_usb_gps; +struct usb_cdc_notif_serial_state { + struct usb_ctrl_req hdr; + uint16_t bits; +}; + + static void _usb_gps_set_active(bool active) { @@ -120,6 +135,53 @@ else ep_regs->bd[0].csr = 0; } + +#ifdef GPS_PPS_ON_CD + /* IN EP CTL: Send PPS pulse */ + ep_regs = &usb_ep_regs[USB_EP_GPS_CDC_CTL & 0x1f].in; + + if ((ep_regs->bd[0].csr & USB_BD_STATE_MSK) != USB_BD_STATE_RDY_DATA) + { + /* Default request */ + struct usb_cdc_notif_serial_state notif = { + .hdr = { + .bmRequestType = USB_REQ_READ | USB_REQ_TYPE_CLASS | USB_REQ_RCPT_INTF, + .bRequest = USB_NOTIF_CDC_SERIAL_STATE, + .wValue = 0, + .wIndex = USB_INTF_GPS_CDC_CTL, + .wLength = 2 + }, + .bits = 0x00 + }; + + /* Check if PPS occured */ + uint32_t pps_now = time_pps_read(); + + if (pps_now != g_usb_gps.pps.last) + { + /* Update last */ + g_usb_gps.pps.last = pps_now; + + /* Queue CD Set */ + notif.bits = 1; + usb_data_write(ep_regs->bd[0].ptr, &notif, 12); + ep_regs->bd[0].csr = USB_BD_STATE_RDY_DATA | USB_BD_LEN(10); + + /* Need to clear in the future */ + g_usb_gps.pps.set = true; + } + else if (g_usb_gps.pps.set) + { + /* Queue CD Clear */ + notif.bits = 0; + usb_data_write(ep_regs->bd[0].ptr, &notif, 12); + ep_regs->bd[0].csr = USB_BD_STATE_RDY_DATA | USB_BD_LEN(10); + + /* Cleared */ + g_usb_gps.pps.set = false; + } + } +#endif } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie5d163434323a23912228003add9870fafefedf9 Gerrit-Change-Number: 29611 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022