Attention is currently required from: tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27578?usp=email )
Change subject: usb: Pass not just the actual transfer length but also the buffer size
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
After a long time of being in review, I'd love to get this finally merged.
Why is that needed ? I don't see it used in subsequent patches (yet) ?
the next patch in the series uses size. Not super critical use, but an overflow check.
I'm wondering if 'len' should be ssize_t just for consitency.
consistency with what? I currently can't see any other use of ssize_t in ice1usb other than a local variable in e1_usb_probe. Please explain.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/27578?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I5088a5213d2945fdfaf3b242a63e35d0ed511914
Gerrit-Change-Number: 27578
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: manawyrm
osmocom.account@tbspace.de
Gerrit-Reviewer: tnt
tnt@246tNt.com
Gerrit-Attention: tnt
tnt@246tNt.com
Gerrit-Comment-Date: Sun, 17 Dec 2023 13:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: tnt
tnt@246tNt.com
Gerrit-MessageType: comment