Attention is currently required from: laforge, fixeria, pespin, dexter.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 )

Change subject: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification ......................................................................

Patch Set 2:

(7 comments)

File library/RLCMAC_CSN1_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/ecff3a0c_dffa3... PS1, Line 166: utran_target_cell_presence := omit,

the PRESENCE is used during decoding, not during encoding afaik. […]

Done

File library/RLCMAC_CSN1_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/4252a098_0aec9... PS1, Line 946: fdd_arfcn_presence

This definition is not entirely correct. Below is my understanding of TS 44.060: […]

I think you are right, there is no closing curly brace after the FDD-ARFCN field. Then everything looks different.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/2793cb7b_28f8b... PS1, Line 969: utran_cell_list_index

Actually, this field should also be part of the list. […]

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/2d721537_ae76e... PS1, Line 972: "LENGTHTO(reporting_quantity)"

Note that `n_3g := 0` means that `reporting_quantity` contains 1 element. […]

Ack

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/17a48fab_4444e... PS1, Line 1001: utran_ba_used

missing `optional`

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/797716ca_2855b... PS1, Line 1016: BIT1 ba_psi3_presence,

Add a /* TODO: Rel-8 addition */ here

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/f942bc69_5bd1d... PS1, Line 1030: variant (utran_target_cell) "PRESENCE(arfcn_bsic_presence = '1'B, utran_target_cell_presence = '0'B)"

I think it may make sense to have the ARFCN+BSIC CSN. […]

Essentially you mean something like in GSM_Types.ttcn:type union RslChanNrU. We would add a union and in that union we would pack a newly added record for geran_target_cell (arfcn,bsic) and utran_target_cell. Each of those records gets a tag field. geran_target_cell gets has a one bit tag, and utran_target_cell a two bit tag field.

And then in

variant "TAG(geran_target_cell, tag = '0'B; utran_target_cell, tag = '01)

Is this what you have in mind?