Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 ) Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ...................................................................... Patch Set 2: (3 comments) File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/1f2abde3_300a7121 PS2, Line 281: } nonamr; "fr_efr" instead of "noamr"? btw, iiuc dtx is for AMR, so "dtx" and "fr_efr" structs can be put in a union? https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/af560fd6_212fa9b0 PS2, Line 282: uint8_t last_cmr; isn't this AMR specific? I find it a bit confusing that a "noamr" struct is put inside a struct containing amr specific fields. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/d826be65_c66308ac PS2, Line 1315: if (lchan->type == GSM_LCHAN_TCH_F) "switch (lchan->type)" should make this function less cryptic imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 15 May 2023 12:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment