Attention is currently required from: falconia.

View Change

3 comments:

• File include/osmo-bts/lchan.h:

  • Patch Set #2, Line 281: } nonamr;

    "fr_efr" instead of "noamr"?
    btw, iiuc dtx is for AMR, so "dtx" and "fr_efr" structs can be put in a union?

  • Patch Set #2, Line 282: uint8_t last_cmr;

    isn't this AMR specific? I find it a bit confusing that a "noamr" struct is put inside a struct containing amr specific fields.

• File src/common/l1sap.c:

  • Patch Set #2, Line 1315: if (lchan->type == GSM_LCHAN_TCH_F)

    "switch (lchan->type)" should make this function less cryptic imho.

To view, visit change 32714. To unsubscribe, or for help writing mail filters, visit settings.