Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30114 ) Change subject: add codec_mapping.h,c ...................................................................... Patch Set 4: (3 comments) File include/osmocom/msc/codec_mapping.h: https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/ada5531e_b80ac1f8 PS4, Line 44: for ((CODEC_MAPPING) = codec_map; (CODEC_MAPPING) < codec_map + ARRAY_SIZE(codec_map); (CODEC_MAPPING)++) this looks buggy to me. the size of codec_map is unknown here (see the number of elements missing in line 42) File src/libmsc/codec_mapping.c: https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/d32a893d_4f52253c PS4, Line 290: if (bearer_cap->speech_ver[i] == -1) { Better add this "-1" as a define "FOOBAR_UNSET" https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/381304bf_d8726245 PS4, Line 308: if (bearer_cap->speech_ver[i] == -1) -1 as define -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744 Gerrit-Change-Number: 30114 Gerrit-PatchSet: 4 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 07 Mar 2023 10:32:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment