Attention is currently required from: neels, laforge, fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30114 )

Change subject: add codec_mapping.h,c ......................................................................

Patch Set 4:

(3 comments)

File include/osmocom/msc/codec_mapping.h:

https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/ada5531e_b80ac1f8 PS4, Line 44: for ((CODEC_MAPPING) = codec_map; (CODEC_MAPPING) < codec_map + ARRAY_SIZE(codec_map); (CODEC_MAPPING)++) this looks buggy to me. the size of codec_map is unknown here (see the number of elements missing in line 42)

File src/libmsc/codec_mapping.c:

https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/d32a893d_4f52253c PS4, Line 290: if (bearer_cap->speech_ver[i] == -1) { Better add this "-1" as a define "FOOBAR_UNSET"

https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/381304bf_d8726245 PS4, Line 308: if (bearer_cap->speech_ver[i] == -1) -1 as define