Attention is currently required from: neels, laforge, fixeria.

View Change

3 comments:

• File include/osmocom/msc/codec_mapping.h:

  • Patch Set #4, Line 44: for ((CODEC_MAPPING) = codec_map; (CODEC_MAPPING) < codec_map + ARRAY_SIZE(codec_map); (CODEC_MAPPING)++)

    this looks buggy to me. the size of codec_map is unknown here (see the number of elements missing in line 42)

• File src/libmsc/codec_mapping.c:

  • Patch Set #4, Line 290: if (bearer_cap->speech_ver[i] == -1) {

    Better add this "-1" as a define "FOOBAR_UNSET"

  • Patch Set #4, Line 308: if (bearer_cap->speech_ver[i] == -1)

    -1 as define

To view, visit change 30114. To unsubscribe, or for help writing mail filters, visit settings.