Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32371 )
Change subject: e1d: set fd number back to 0 on failure ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
why moving fd from -1 to 0? It should never be 0 to start with if it is invalid, it should be -1 (0 […]
That's true, I was also wondering about this. Its probably initialized with zero because the struct was allocated with talloc_zero(). This is really ugly, we should think about this...
However, it will probably never hurt since there is technically no way using stdin as E1 timeslot with osmo-e1d ;-)