Attention is currently required from: daniel. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290?usp=email ) Change subject: sccp: Improve spec references in code documentation ...................................................................... Patch Set 1: (1 comment) File src/sccp_scrc.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290/comment/b6ecbb28_d2a4b… : PS1, Line 245: /* "Figure C.1/Q.714 - SCCP routing control procedures (SCRC) (sheet 5 of 12)" I also thought about it, but thought Q.714 in the line is descriptive enough. I know usually we'd do like you mention, but since that spec uses that syntax to name figures, I prefer keeping it that way to make it copy+paste CTRL+F, because it's f*cking complex to find stuff in those state diagrams. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie43f9472322e7b6ed3ce8fc91408c074ddb98378 Gerrit-Change-Number: 40290 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 May 2025 14:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>