Attention is currently required from: daniel.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290?usp=email )
Change subject: sccp: Improve spec references in code documentation ......................................................................
Patch Set 1:
(1 comment)
File src/sccp_scrc.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290/comment/b6ecbb28_d2a4b4... : PS1, Line 245: /* "Figure C.1/Q.714 - SCCP routing control procedures (SCRC) (sheet 5 of 12)"
Not sure if that's too pedantic, but could you change it to […]
I also thought about it, but thought Q.714 in the line is descriptive enough.
I know usually we'd do like you mention, but since that spec uses that syntax to name figures, I prefer keeping it that way to make it copy+paste CTRL+F, because it's f*cking complex to find stuff in those state diagrams.