[M] Change in osmo-hlr[master]: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subs... - gerrit-log

2 May 2023


      Attention is currently required from: laforge, lynxis lazus, msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32511 )
Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File include/osmocom/hlr/gsup_server.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/b8773d67_d23434e3 
PS3, Line 71: osmo_gsup_create_insert_subscriber_data_msg
...
The header won't be installed and can't be used by other projects
Ah, indeed. There exists `libosmo-gsup-client`, but not `libosmo-gsup-server`. Still I find it wrong that the symbol names here start with `osmo_`. Anyways, not related to this patch.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: msuraev msuraev@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Tue, 02 May 2023 17:56:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: lynxis lazus lynxis@fe80.eu
Gerrit-MessageType: comment